From patchwork Thu May 13 04:00:39 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lev Stipakov X-Patchwork-Id: 1812 Return-Path: Delivered-To: patchwork@openvpn.net Delivered-To: patchwork@openvpn.net Received: from director14.mail.ord1d.rsapps.net ([172.28.255.1]) by backend30.mail.ord1d.rsapps.net with LMTP id KMK8OrYeomCsaQAAIUCqbw (envelope-from ) for ; Mon, 17 May 2021 03:43:50 -0400 Received: from proxy9.mail.ord1c.rsapps.net ([172.28.255.1]) by director14.mail.ord1d.rsapps.net with LMTP id UBeLOrYeomAIVgAAeJ7fFg (envelope-from ) for ; Mon, 17 May 2021 03:43:50 -0400 Received: from smtp4.gate.ord1c ([172.28.255.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by proxy9.mail.ord1c.rsapps.net with LMTPS id mGFTOrYeomDNawAAgxtkuw (envelope-from ) for ; Mon, 17 May 2021 03:43:50 -0400 X-Spam-Threshold: 95 X-Spam-Score: 0 X-Spam-Flag: NO X-Virus-Scanned: OK X-Orig-To: openvpnslackdevel@openvpn.net X-Originating-Ip: [216.105.38.7] Authentication-Results: smtp4.gate.ord1c.rsapps.net; iprev=pass policy.iprev="216.105.38.7"; spf=pass smtp.mailfrom="openvpn-devel-bounces@lists.sourceforge.net" smtp.helo="lists.sourceforge.net"; dkim=fail (signature verification failed) header.d=sourceforge.net; dkim=fail (signature verification failed) header.d=sf.net; dkim=fail (signature verification failed) header.d=gmail.com; dmarc=fail (p=none; dis=none) header.from=gmail.com X-Suspicious-Flag: YES X-Classification-ID: 9eb4f4da-b6e3-11eb-a7c3-0024e87f2f2c-1-1 Received: from [216.105.38.7] ([216.105.38.7:36956] helo=lists.sourceforge.net) by smtp4.gate.ord1c.rsapps.net (envelope-from ) (ecelerity 4.2.38.62370 r(:)) with ESMTPS (cipher=DHE-RSA-AES256-GCM-SHA384) id E7/FE-10326-6BE12A06; Mon, 17 May 2021 03:43:50 -0400 Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.92.3) (envelope-from ) id 1liXtm-0005PJ-8A; Mon, 17 May 2021 07:42:46 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.3) (envelope-from ) id 1liXtj-0005PA-90 for openvpn-devel@lists.sourceforge.net; Mon, 17 May 2021 07:42:43 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=aJyWpcI3wLTcd5GjUqZ/MG0E5YykhWG/8xQPIGy/Zrg=; b=kgFJ/X56ODxIUrZwvKEPrXOe9O gLxUL6hJfGecuhmCv7Tp5OiF+iY26t/x+Fh95nz3JixAqnSeOz5Qkf8FsAU4BGh46YBL/EuhSA6E9 azn1dFo8djQE1oy4I3vOAWLyWNhhZSz31Ek6bpelRqlp7lzW1NG2MRZaOGZ4P4EXmTKE=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:MIME-Version: Content-Type:Content-Transfer-Encoding:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=aJyWpcI3wLTcd5GjUqZ/MG0E5YykhWG/8xQPIGy/Zrg=; b=Fz7Ys444OmHOEu7bykYwiZrPCI WMNxDIoaLcu8twGtN5yperJiaBrFNLQAPII9Y/P4V/cOUah+ZY5MxWN2OIwpPufBQmlzw5kkWiqOo GoHiL6C6KxNU08qXgcNL4nqtM/AHh8ZbF11cnVAbIz1DBJLFRCZJI53dMsc+BHZgfZU4=; Received: from mail-wr1-f50.google.com ([209.85.221.50]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.92.3) id 1liXtX-00014Y-Gk for openvpn-devel@lists.sourceforge.net; Mon, 17 May 2021 07:42:43 +0000 Received: by mail-wr1-f50.google.com with SMTP id p7so1538552wru.10 for ; Mon, 17 May 2021 00:42:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=aJyWpcI3wLTcd5GjUqZ/MG0E5YykhWG/8xQPIGy/Zrg=; b=mNidkjRo+lrFrBiHjM7Xe++hK6PFKu1CkhgK+z6K0ul1JuAv12yx9PF89DN7vfaV5q O4Ua1u3tj8yFMbl44x9g553hCvpYX0XpUWsDRokexjfknbrVnOsx13qAW0h1bkV7JBR1 BGxR09ZGFjUy1LqMSj+5+AtbHJ7qJKkgQVLZXmj5diY7OrYBvCB2PfPNXxXUi300Pmu2 lzqL9KELHwxDbKDA/G9N3ECGrJO65cbKOayoX0E807hXUgFWKd4fcH+H6l3TIyQ8+4xT zuvam12s3GnNuADHhI4aFc1ubg94LlccoEsv9fIRToQwlnZSDLuGlupPtYinWGOWQAAf VEAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=aJyWpcI3wLTcd5GjUqZ/MG0E5YykhWG/8xQPIGy/Zrg=; b=G00PE1DPoZeKZuZjHXC+lielYmROZ5L6yOP7PtBDaSVZ3dmQheI/G3KTxb5fR5IVOb /ol4DSQPUts9qho1Gew6estsBLcJxop/rf0GZeACAUfeAbbVk6kjNb37vz4b0jjVB3WG pKZb6r8q4iTx9ZntLWGFWM7UFecNl7rbV+iX5IdSV1SGsRWQ/M2qLXmD8x4hdqrM4cOK UoyIbDk4F6ZYe34gCYW0xic4oziGxM5vxyH2aK/2gjpbPmyvApa8SZNzVXav4dytgsNj +cVRkNQatLdZr2Fq8tzi8KSqxHIGpejTDQWG9ck0MMwO19C5nx2YsiZdtW3PhXimCPSS rKmw== X-Gm-Message-State: AOAM532WSPCey7hQElsn+4+A1cyWp6Mbn7WCOpdrE1mUKvAAII3ftmfs D+UEmMq/qQBNeBcWeibujvxuhXBm35Q= X-Google-Smtp-Source: ABdhPJyPn+bCnob1Kzw2rFXNbjf9GkZBFm+5KlVoEYXaN3KqHtAqAcJkRjBG17+HSlJrfShBCoYl5w== X-Received: by 2002:a5d:654b:: with SMTP id z11mr72981300wrv.167.1621237345709; Mon, 17 May 2021 00:42:25 -0700 (PDT) Received: from LAPTOP-4L3N7KFS.localdomain (nat2.panoulu.net. [185.38.2.2]) by smtp.gmail.com with ESMTPSA id q3sm14155882wrr.43.2021.05.17.00.42.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 May 2021 00:42:24 -0700 (PDT) From: Lev Stipakov To: openvpn-devel@lists.sourceforge.net Date: Thu, 13 May 2021 17:00:39 +0300 Message-Id: <20210513140039.265-1-lstipakov@gmail.com> X-Mailer: git-send-email 2.17.1 X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.221.50 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (lstipakov[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.221.50 listed in wl.mailspike.net] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-Headers-End: 1liXtX-00014Y-Gk Subject: [Openvpn-devel] [PATCH] win32: add missing include header X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lev Stipakov MIME-Version: 1.0 Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox From: Lev Stipakov Commit 5a571fb0 ("Move utility function from win32.c to win32-util.c") moved some functions from win32.[ch] to a new win32-util.[ch], but missed adding new include header, which results in compilation errors like: >cryptoapi.c >C:\Users\lev\Projects\openvpn\src\openvpn\cryptoapi.c(755,53): error C2220: the following warning is treated as an error >C:\Users\lev\Projects\openvpn\src\openvpn\cryptoapi.c(755,53): warning C4047: '=': 'const void *' differs in levels of indirection from 'int' Fix by adding #include "win32-util.h" to "win32.h". While on it, update vcxproj.filters with a new header so that it looks "correct" in VS project view. Signed-off-by: Lev Stipakov Acked-by: Gert Doering --- src/openvpn/openvpn.vcxproj.filters | 3 +++ src/openvpn/win32.h | 1 + 2 files changed, 4 insertions(+) diff --git a/src/openvpn/openvpn.vcxproj.filters b/src/openvpn/openvpn.vcxproj.filters index a4dbb6cd..3b75eecd 100644 --- a/src/openvpn/openvpn.vcxproj.filters +++ b/src/openvpn/openvpn.vcxproj.filters @@ -518,6 +518,9 @@ Header Files + + Header Files + diff --git a/src/openvpn/win32.h b/src/openvpn/win32.h index 23573835..f075e0ae 100644 --- a/src/openvpn/win32.h +++ b/src/openvpn/win32.h @@ -30,6 +30,7 @@ #include "mtu.h" #include "openvpn-msg.h" #include "argv.h" +#include "win32-util.h" /* location of executables */ #define SYS_PATH_ENV_VAR_NAME "SystemRoot" /* environmental variable name that normally contains the system path */