| Message ID | 20210929115905.1281-1-a@unstable.cc |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [Openvpn-devel] networking: add missing brackets | expand |
Acked-by: Gert Doering <gert@greenie.muc.de> This is one of the more silly fixup patches, given that we already had a fixed v2 on the list - apologies. Your patch has been applied to the master branch. I'll bring this to 2.5 as well, but squashed together with the "real" patch. commit cb5d29461e6e734a2250b984b8423d39f7b9ddaa Author: Antonio Quartulli Date: Wed Sep 29 13:59:05 2021 +0200 networking: add missing brackets Signed-off-by: Antonio Quartulli <a@unstable.cc> Acked-by: Gert Doering <gert@greenie.muc.de> Message-Id: <20210929115905.1281-1-a@unstable.cc> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg22908.html Signed-off-by: Gert Doering <gert@greenie.muc.de> -- kind regards, Gert Doering
diff --git a/src/openvpn/networking_iproute2.c b/src/openvpn/networking_iproute2.c index c6623b19..67b8894b 100644 --- a/src/openvpn/networking_iproute2.c +++ b/src/openvpn/networking_iproute2.c @@ -107,7 +107,9 @@ net_addr_ll_set(openvpn_net_ctx_t *ctx, const openvpn_net_iface_t *iface, argv_msg(M_INFO, &argv); if (!openvpn_execve_check(&argv, ctx->es, M_WARN, "Linux ip link set addr failed")) + { ret = -1; + } argv_free(&argv);
Our codestyle demands having brackets also around if-blocks made up by one line only. In patch "networking: add and implement net_addr_ll_set() API" this rule was not respected and a new one-line-if-block was added with no brackets. Fix this by adding the related brackets as needed. Signed-off-by: Antonio Quartulli <a@unstable.cc> --- src/openvpn/networking_iproute2.c | 2 ++ 1 file changed, 2 insertions(+)