From patchwork Fri Oct 15 07:47:33 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Selva Nair X-Patchwork-Id: 1986 Return-Path: Delivered-To: patchwork@openvpn.net Delivered-To: patchwork@openvpn.net Received: from director9.mail.ord1d.rsapps.net ([172.30.191.6]) by backend30.mail.ord1d.rsapps.net with LMTP id gM4VNwnNaWE1SQAAIUCqbw (envelope-from ) for ; Fri, 15 Oct 2021 14:48:41 -0400 Received: from proxy16.mail.ord1d.rsapps.net ([172.30.191.6]) by director9.mail.ord1d.rsapps.net with LMTP id 4J3cNgnNaWGDNwAAalYnBA (envelope-from ) for ; Fri, 15 Oct 2021 14:48:41 -0400 Received: from smtp23.gate.ord1d ([172.30.191.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by proxy16.mail.ord1d.rsapps.net with LMTPS id OEaHNgnNaWErKQAAetu3IA (envelope-from ) for ; Fri, 15 Oct 2021 14:48:41 -0400 X-Spam-Threshold: 95 X-Spam-Score: 0 X-Spam-Flag: NO X-Virus-Scanned: OK X-Orig-To: openvpnslackdevel@openvpn.net X-Originating-Ip: [216.105.38.7] Authentication-Results: smtp23.gate.ord1d.rsapps.net; iprev=pass policy.iprev="216.105.38.7"; spf=pass smtp.mailfrom="openvpn-devel-bounces@lists.sourceforge.net" smtp.helo="lists.sourceforge.net"; dkim=fail (signature verification failed) header.d=sourceforge.net; dkim=fail (signature verification failed) header.d=sf.net; dkim=fail (signature verification failed) header.d=gmail.com; dmarc=fail (p=none; dis=none) header.from=gmail.com X-Suspicious-Flag: YES X-Classification-ID: 83fe2bd0-2de8-11ec-9e31-525400bfb165-1-1 Received: from [216.105.38.7] ([216.105.38.7:42736] helo=lists.sourceforge.net) by smtp23.gate.ord1d.rsapps.net (envelope-from ) (ecelerity 4.2.38.62370 r(:)) with ESMTPS (cipher=DHE-RSA-AES256-GCM-SHA384) id D6/B9-02369-90DC9616; Fri, 15 Oct 2021 14:48:41 -0400 Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1mbSFF-0005a6-WD; Fri, 15 Oct 2021 18:47:54 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mbSFF-0005a0-EP for openvpn-devel@lists.sourceforge.net; Fri, 15 Oct 2021 18:47:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=22EiUXmZFTro4TnC7x6etkNfNr6fdkYMzhJfE4+T31Q=; b=THbXzu8iK0SVAdLp2fYm9bkMWO MZrwXe/anPU8ON89s+MLHbjFkbmCAh6fOj9gUNDlTqfyciprSKkeVkS48ia0GTLFO0BViiFVirI2b b/5o/Zg0gypfq448/jnRgDk5TaDmGZcXPNj1dCECWj/cqRV6cxq3xL+C+1G5xjYxSrxg=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-Id: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=22EiUXmZFTro4TnC7x6etkNfNr6fdkYMzhJfE4+T31Q=; b=N09d8iBwWNaBBQl+AfCyuX8Yx2 Qx4XARj1kX/3g5B/W4hf7JNtOzzju0hgaJfKxuwg5WSrakMDUoV5QjUC3qiJMycvV8P8WYbFMOpxY F058cXEVTCN7KSHjC9y8Qxk6URHiH+r0qdvl6vjQ0jd5S7PbiR9/moYKnexfuqM+nbik=; Received: from mail-il1-f179.google.com ([209.85.166.179]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.92.3) id 1mbSFE-00073i-Qa for openvpn-devel@lists.sourceforge.net; Fri, 15 Oct 2021 18:47:53 +0000 Received: by mail-il1-f179.google.com with SMTP id y17so8138535ilb.9 for ; Fri, 15 Oct 2021 11:47:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=22EiUXmZFTro4TnC7x6etkNfNr6fdkYMzhJfE4+T31Q=; b=d79ECpa9+ndxpxVmJFXqa8yXO2bckrhrNcYWLsPULBtBDmmMK5Wy8KbgtBDRRfSTrm goIzfDbLUtt/UcKCiTzOJtn4PYEjUlGghZkV2QgLquwPHU3o6rz2YGWVnnN7oiKnMiNJ YPxYQEF/ukyocEsHzuYyT5nbk2knkcYd5n3Yp+kfo1o+WB8W7douUEK1yVptOOojVP1b 24fQjKFgOL5/jJRr/b36tJfig6GuhR0wewuSRxs2ID1GWdGj6YQkUlYBf3hlRAmURGzN CGxIeOitxxKpnfUNPaj6Db/gfXhR/pGZc0stoTSXtFLIaf0Rx5LB+IUBJYVb+hN+Xr41 ITJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=22EiUXmZFTro4TnC7x6etkNfNr6fdkYMzhJfE4+T31Q=; b=stc5T5l6dWhthuiH5zh+F+O/2bcVVOir4heXAH36zt4UpMC3xADujM+q/BP7g+5+/J nkA5X5hJmiEQDV5Vm1p6zq26e/TESFTpnbEHi4Y5+WOsuK8uCXUqAtjmeHCcg1IqPs7g STHBVmsi8JHLxuQEDm4+wvYUNgIGxzxxk1XaEbzvYfLy3ynp4WajgVTl9hAU4cduwqFG GEftDHMa6gUvaCWL6TDQY9M+hDVUjVYL8YrFwS5rRSxgfnYCFrVCzDp+XCGn1i/C1CDZ KNF8rsSjsACHVsh0u48HZmp/g4y9arxZQN1104wBBkY+hJGiKJRYeG5/L+uhj2RiTexz Px4g== X-Gm-Message-State: AOAM530jrFB5AZkVSGOaM/oe3HvX45Qi0/n+5dOb2DaOC/XopSY1WoOU H816aStTbJUAThOyR8HphT57KzbPv/s= X-Google-Smtp-Source: ABdhPJyB7ZS6O2tkJmgsFFxy/xmWpbtaUlmuoh4hy9eSPNjc2cQpzFqJeFzlahLlo1+3YW1Wkh112w== X-Received: by 2002:a92:ca48:: with SMTP id q8mr4804546ilo.242.1634323666931; Fri, 15 Oct 2021 11:47:46 -0700 (PDT) Received: from uranus.home.sansel.ca (bras-vprn-tnhlon4053w-lp130-02-70-51-223-227.dsl.bell.ca. [70.51.223.227]) by smtp.gmail.com with ESMTPSA id l12sm2971897ilh.19.2021.10.15.11.47.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Oct 2021 11:47:46 -0700 (PDT) From: selva.nair@gmail.com To: openvpn-devel@lists.sourceforge.net Date: Fri, 15 Oct 2021 14:47:33 -0400 Message-Id: <20211015184733.16988-1-selva.nair@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20211015175330.15760-1-selva.nair@gmail.com> References: <20211015175330.15760-1-selva.nair@gmail.com> MIME-Version: 1.0 X-Spam-Report: Spam detection software, running on the system "util-spamd-1.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Selva Nair Not sure where these came from, but here goes: S_IRUSR = 0 --> _S_IREAD S_IWUSR = 0 --> _S_IWRITE Content analysis details: (-0.2 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [selva.nair[at]gmail.com] -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.166.179 listed in wl.mailspike.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.166.179 listed in list.dnswl.org] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-Headers-End: 1mbSFE-00073i-Qa Subject: [Openvpn-devel] [PATCH for 2.5] Fix some more wrong defines in config-msvc.h X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox From: Selva Nair Not sure where these came from, but here goes: S_IRUSR = 0 --> _S_IREAD S_IWUSR = 0 --> _S_IWRITE ENABLE_DEBUG is on, but I do not think we want it in production build. Changed to ENABLE_DEBUG 0 S_IRGRP is not defined but seems to be used. I have added it, remove if not required. This define is based on mingw and matches MS docs on (https://docs.microsoft.com/en-us/cpp/standard-library/filesystem-enumerations?view=msvc-160) Should fix Trac #1430 but untested (I do not have a setup at hand for msvc build). Signed-off-by: Selva Nair --- config-msvc.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/config-msvc.h b/config-msvc.h index a39eeed8..9fc8d1cc 100644 --- a/config-msvc.h +++ b/config-msvc.h @@ -5,8 +5,7 @@ #define ENABLE_DEF_AUTH 1 #define ENABLE_PF 1 #define ENABLE_CRYPTO_OPENSSL 1 -#define ENABLE_DEBUG 1 -#define ENABLE_EUREPHIA 1 +#define ENABLE_DEBUG 0 #define ENABLE_FRAGMENT 1 #define ENABLE_HTTP_PROXY 1 #define ENABLE_LZO 1 @@ -144,8 +143,9 @@ #define in_addr_t uint32_t #define ssize_t SSIZE_T -#define S_IRUSR 0 -#define S_IWUSR 0 +#define S_IRUSR _S_IREAD +#define S_IWUSR _S_IWRITE +#define S_IRGRP (S_IRUSR >> 3) #define R_OK 4 #define W_OK 2 #define X_OK 1