[Openvpn-devel] ring_buffer.h: fix GCC warning about unused function

Message ID 20211124160347.1245-1-lstipakov@gmail.com
State Accepted
Headers show
Series [Openvpn-devel] ring_buffer.h: fix GCC warning about unused function | expand

Commit Message

Lev Stipakov Nov. 24, 2021, 5:03 a.m. UTC
From: Lev Stipakov <lev@openvpn.net>

With register_ring_buffers() being declared as "static" in header file,
all translation units, which include that header, got a copy of that function.
This causes GCC warning

  warning: "register_ring_buffers" defined but not used [-Wunused-function]

when compiling C files which include header, but don't use function.

Add "inline" keyword to silence this warning.

Signed-off-by: Lev Stipakov <lev@openvpn.net>
 src/openvpn/ring_buffer.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


Gert Doering Nov. 24, 2021, 5:22 a.m. UTC | #1
Acked-by: Gert Doering <gert@greenie.muc.de>

Thanks.  (Found while looking at the compiler warnings reviewing
the OpenSSL config loading patch).  Test built on MinGW, warnings gone.

Your patch has been applied to the master branch.

commit 71371f04afa6eba3ea02a67590a70e018cf203e5 (master)
commit 36b3129d47a6dbfcd43ff4773c69618a28eb48bc (release/2.5)
Author: Lev Stipakov
Date:   Wed Nov 24 18:03:47 2021 +0200

     ring_buffer.h: fix GCC warning about unused function

     Signed-off-by: Lev Stipakov <lev@openvpn.net>
     Acked-by: Gert Doering <gert@greenie.muc.de>
     Message-Id: <20211124160347.1245-1-lstipakov@gmail.com>
     URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg23260.html
     Signed-off-by: Gert Doering <gert@greenie.muc.de>

kind regards,

Gert Doering


diff --git a/src/openvpn/ring_buffer.h b/src/openvpn/ring_buffer.h
index 77579e3f..9661ceb3 100644
--- a/src/openvpn/ring_buffer.h
+++ b/src/openvpn/ring_buffer.h
@@ -94,7 +94,7 @@  struct TUN_PACKET
  *                            that data has been written to receive ring
  * @return                    true if registration is successful, false otherwise - use GetLastError()
-static bool
+static inline bool
 register_ring_buffers(HANDLE device,
                       struct tun_ring *send_ring,
                       struct tun_ring *receive_ring,