From patchwork Wed Dec 8 02:46:55 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maximilian Fillinger X-Patchwork-Id: 2145 Return-Path: Delivered-To: patchwork@openvpn.net Delivered-To: patchwork@openvpn.net Received: from director8.mail.ord1d.rsapps.net ([172.27.255.50]) by backend41.mail.ord1d.rsapps.net with LMTP id 8H96Kbu3sGHdMgAAqwncew (envelope-from ) for ; Wed, 08 Dec 2021 08:48:43 -0500 Received: from proxy7.mail.iad3a.rsapps.net ([172.27.255.50]) by director8.mail.ord1d.rsapps.net with LMTP id SBIWOru3sGG8UwAAfY0hYg (envelope-from ) for ; Wed, 08 Dec 2021 08:48:43 -0500 Received: from smtp7.gate.iad3a ([172.27.255.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by proxy7.mail.iad3a.rsapps.net with LMTPS id CF+lNLu3sGFOcwAAnPvY+A (envelope-from ) for ; Wed, 08 Dec 2021 08:48:43 -0500 X-Spam-Threshold: 95 X-Spam-Score: 0 X-Spam-Flag: NO X-Virus-Scanned: OK X-Orig-To: openvpnslackdevel@openvpn.net X-Originating-Ip: [216.105.38.7] Authentication-Results: smtp7.gate.iad3a.rsapps.net; iprev=pass policy.iprev="216.105.38.7"; spf=pass smtp.mailfrom="openvpn-devel-bounces@lists.sourceforge.net" smtp.helo="lists.sourceforge.net"; dkim=fail (signature verification failed) header.d=sourceforge.net; dkim=fail (signature verification failed) header.d=sf.net; dkim=fail (key not found in DNS) header.d=foxcrypto.com; dmarc=fail (p=none; dis=none) header.from=foxcrypto.com X-Suspicious-Flag: YES X-Classification-ID: 8d55e23a-582d-11ec-ad4f-525400bbebb8-1-1 Received: from [216.105.38.7] ([216.105.38.7:49542] helo=lists.sourceforge.net) by smtp7.gate.iad3a.rsapps.net (envelope-from ) (ecelerity 4.2.38.62370 r(:)) with ESMTPS (cipher=DHE-RSA-AES256-GCM-SHA384) id 5D/01-21366-9B7B0B16; Wed, 08 Dec 2021 08:48:41 -0500 Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.94.2) (envelope-from ) id 1muxIC-00020o-Oe; Wed, 08 Dec 2021 13:47:33 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1muxIC-00020d-0j for openvpn-devel@lists.sourceforge.net; Wed, 08 Dec 2021 13:47:33 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:MIME-Version:Message-ID:Date:Subject: CC:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=GJVwOQ+8HkmHcCDEwWqfJRFVz9Pf/fs3R7Y1pjBBmQE=; b=eiRaFyFR8HwvR0HefqUmp6oEHr 7c645nKhLlExdqIGGE9ZoABMZgXkHoSQfLhUe+ya3rCTQ9N+8L6EWpLZk77I7UAsjLahejCq2Gp1s Y6aG1DvaT7n6PjniCqFhX7XdN3/sw1EcUuw4x4fMzDFLrubuvO+uCTrEZFv5Katfm+so=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:MIME-Version:Message-ID:Date:Subject:CC:To:From:Sender: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=GJVwOQ+8HkmHcCDEwWqfJRFVz9Pf/fs3R7Y1pjBBmQE=; b=a T+FwbYBN6NSjrJxMLKb6o4SglPGGaDJAVil7ZhT3k4kNLQzDzyjmkBxe0ZLZA5TC/8wN8vAokB3lM wIvR2AhleXZlAAsRMsRlUfHgFU+x7o7jHPqFAPDhaYQ1LMCq0oOhySN8XnWJDqKGTP722XnLLsBs/ ZzHfH2JeKGpPOtyA=; Received: from nl-dft-mx-01.fox-it.com ([178.250.144.135]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.3) id 1muxI6-008i7G-An for openvpn-devel@lists.sourceforge.net; Wed, 08 Dec 2021 13:47:33 +0000 From: Max Fillinger To: Date: Wed, 8 Dec 2021 14:46:55 +0100 Message-ID: <20211208134655.28905-1-maximilian.fillinger@foxcrypto.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 X-ClientProxiedBy: FOXDFT1EX01.FOX.local (10.0.0.129) To FOXDFT1EX01.FOX.local (10.0.0.129) X-FE-Policy-ID: 13:3:2:SYSTEM DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; d=foxcrypto.com; s=NL-DFT-MX-01; c=relaxed/relaxed; h=from:to:cc:subject:date:message-id:mime-version:content-type; bh=GJVwOQ+8HkmHcCDEwWqfJRFVz9Pf/fs3R7Y1pjBBmQE=; b=dgHpfjF+gqHReCNyH7irHc7ZAj8wJyd24c9TmA2cgVdmfVELhjoPP7EvKFKjkJ8Nihynw38VSmAs Tjl8wgeru8Jw6cLllEVOluzezxfBRpuefNO4yeFcpynZX8KiW+A2hKjmzu6C1Tmar9CTZ5HiRTF8 6F+OITgEAnFQLDg2K1VYvxvqqJYOs9Svz/wlMQannDx3pVwyCw8wz4RHSg1CcXl51WwXFo57ZVlv KziAg2qGyxQgbhKDRZ2yIn/x5pzmGYBb4ZCYfDNV9dxKa9BN4Mn2q1iCpaYNtaNTwHQNk9oSQrpz eF9i2tDHqXKIUUFhJaGHU9lTtaXW4BIMJyvxhA== X-Spam-Report: Spam detection software, running on the system "util-spamd-1.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Signed-off-by: Max Fillinger --- tests/unit_tests/openvpn/test_ncp.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/tests/unit_tests/openvpn/test_ncp.c b/tests/unit_tests/openvpn/test_ncp.c index 6702133a..f4c28ffd 100644 --- a/tests/unit_tests/openvpn/test_ncp.c +++ b/tests/unit_tests/openvpn/test_ncp [...] Content analysis details: (0.2 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid 0.1 DKIM_INVALID DKIM or DK signature exists, but is not valid X-Headers-End: 1muxI6-008i7G-An Subject: [Openvpn-devel] [PATCH] Don't use BF-CBC in unit tests if we don't have it X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox Signed-off-by: Max Fillinger Acked-by: Gert Doering --- tests/unit_tests/openvpn/test_ncp.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/tests/unit_tests/openvpn/test_ncp.c b/tests/unit_tests/openvpn/test_ncp.c index 6702133a..f4c28ffd 100644 --- a/tests/unit_tests/openvpn/test_ncp.c +++ b/tests/unit_tests/openvpn/test_ncp.c @@ -120,8 +120,11 @@ test_check_ncp_ciphers_list(void **state) assert_string_equal(mutate_ncp_cipher_list("id-aes128-GCM:id-aes256-GCM", &gc), "AES-128-GCM:AES-256-GCM"); #else - assert_string_equal(mutate_ncp_cipher_list("BLOWFISH-CBC", - &gc), "BF-CBC"); + if (have_blowfish) + { + assert_string_equal(mutate_ncp_cipher_list("BLOWFISH-CBC", + &gc), "BF-CBC"); + } #endif gc_free(&gc); }