From patchwork Wed Dec 29 06:27:14 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Antonio Quartulli X-Patchwork-Id: 2189 Return-Path: Delivered-To: patchwork@openvpn.net Delivered-To: patchwork@openvpn.net Received: from director8.mail.ord1d.rsapps.net ([172.27.255.57]) by backend41.mail.ord1d.rsapps.net with LMTP id 6Fz6AbeazGHpbwAAqwncew (envelope-from ) for ; Wed, 29 Dec 2021 12:28:23 -0500 Received: from proxy4.mail.iad3a.rsapps.net ([172.27.255.57]) by director8.mail.ord1d.rsapps.net with LMTP id OIJbEreazGEJfgAAfY0hYg (envelope-from ) for ; Wed, 29 Dec 2021 12:28:23 -0500 Received: from smtp26.gate.iad3a ([172.27.255.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by proxy4.mail.iad3a.rsapps.net with LMTPS id uIbcDLeazGFXFQAA8Zvu4w (envelope-from ) for ; Wed, 29 Dec 2021 12:28:23 -0500 X-Spam-Threshold: 95 X-Spam-Score: 0 X-Spam-Flag: NO X-Virus-Scanned: OK X-Orig-To: openvpnslackdevel@openvpn.net X-Originating-Ip: [216.105.38.7] Authentication-Results: smtp26.gate.iad3a.rsapps.net; iprev=pass policy.iprev="216.105.38.7"; spf=pass smtp.mailfrom="openvpn-devel-bounces@lists.sourceforge.net" smtp.helo="lists.sourceforge.net"; dkim=fail (signature verification failed) header.d=sourceforge.net; dkim=fail (signature verification failed) header.d=sf.net; dmarc=none (p=nil; dis=none) header.from=unstable.cc X-Suspicious-Flag: YES X-Classification-ID: b8a8116a-68cc-11ec-870b-52540063aac2-1-1 Received: from [216.105.38.7] ([216.105.38.7:46338] helo=lists.sourceforge.net) by smtp26.gate.iad3a.rsapps.net (envelope-from ) (ecelerity 4.2.38.62370 r(:)) with ESMTPS (cipher=DHE-RSA-AES256-GCM-SHA384) id 4C/CB-10640-6BA9CC16; Wed, 29 Dec 2021 12:28:23 -0500 Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.94.2) (envelope-from ) id 1n2cjX-0005Bi-Dx; Wed, 29 Dec 2021 17:27:27 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1n2cjV-0005Bb-OK for openvpn-devel@lists.sourceforge.net; Wed, 29 Dec 2021 17:27:25 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:Message-Id: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=PuXEOJdhkQyo1qX/XYqAI/6btVJde/zmnSyrqIIUPJM=; b=Bo9jB9wx3tnR1yCwWh4qj0NoSz 8mABcVYtuD9a474vVHwtigPttkLEgR9ZkDptOswZE56AhlTJW3OWMe+s1684JGBJzmP7xJS32dpcH gWKSjZAAGCVGyBzfq+OdvIz5aUx8a1gnXb2ROa54hgEVvsAFh9/5BV94uCDOawHntu8s=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject:Cc:To:From :Sender:Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=PuXEOJdhkQyo1qX/XYqAI/6btVJde/zmnSyrqIIUPJM=; b=C Nj/lLHFkp6zzGs5IMMDfd08gEWVHFLI5AMC9TwSxbOVhTG/KlfKZGRc9FdTIxHaCVYrgK+H9CVimN bL7a4OThnymWX6nvNx0intiOUIpDDj/U8L9RZKjUOydiRa2x/jfwRdUYJocuVHKGHp/YeAje1iL4v XogtnoydT9Rt4TmU=; Received: from s2.neomailbox.net ([5.148.176.60]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.3) id 1n2cjT-0003eD-On for openvpn-devel@lists.sourceforge.net; Wed, 29 Dec 2021 17:27:25 +0000 From: Antonio Quartulli To: openvpn-devel@lists.sourceforge.net Date: Wed, 29 Dec 2021 18:27:14 +0100 Message-Id: <20211229172714.6424-1-a@unstable.cc> MIME-Version: 1.0 X-Spam-Report: Spam detection software, running on the system "util-spamd-1.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: BF-CBC is the default value for the --cipher option in OpenVPN <2.5 and not <2.6. However, the warning printed to screen talks about "OpenVPN before 2.6", which is wrong and needs to be fixed. Fix message by saying ".. before 2.5" Content analysis details: (-0.0 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record X-Headers-End: 1n2cjT-0003eD-On Subject: [Openvpn-devel] [PATCH] options.c: fix version reported in --cipher warning message X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Antonio Quartulli Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox BF-CBC is the default value for the --cipher option in OpenVPN <2.5 and not <2.6. However, the warning printed to screen talks about "OpenVPN before 2.6", which is wrong and needs to be fixed. Fix message by saying ".. before 2.5" Cc: Arne Schwabe Signed-off-by: Antonio Quartulli Acked-By: Arne Schwabe --- src/openvpn/options.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/openvpn/options.c b/src/openvpn/options.c index b840b767..6fdcf764 100644 --- a/src/openvpn/options.c +++ b/src/openvpn/options.c @@ -3120,7 +3120,7 @@ options_postprocess_cipher(struct options *o) * parts of OpenVPN assert that the ciphername is set */ o->ciphername = "BF-CBC"; - msg(M_INFO, "Note: --cipher is not set. OpenVPN versions before 2.6 " + msg(M_INFO, "Note: --cipher is not set. OpenVPN versions before 2.5 " "defaulted to BF-CBC as fallback when cipher negotiation " "failed in this case. If you need this fallback please add " "'--data-ciphers-fallback 'BF-CBC' to your configuration "