From patchwork Sat Jan 1 05:06:32 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arne Schwabe X-Patchwork-Id: 2191 Return-Path: Delivered-To: patchwork@openvpn.net Delivered-To: patchwork@openvpn.net Received: from director14.mail.ord1d.rsapps.net ([172.27.255.57]) by backend41.mail.ord1d.rsapps.net with LMTP id CFhLHVh80GGYHQAAqwncew (envelope-from ) for ; Sat, 01 Jan 2022 11:07:52 -0500 Received: from proxy13.mail.iad3a.rsapps.net ([172.27.255.57]) by director14.mail.ord1d.rsapps.net with LMTP id WAMfOlh80GHsawAAeJ7fFg (envelope-from ) for ; Sat, 01 Jan 2022 11:07:52 -0500 Received: from smtp40.gate.iad3a ([172.27.255.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by proxy13.mail.iad3a.rsapps.net with LMTPS id cDnyMVh80GEqIgAAwhxzoA (envelope-from ) for ; Sat, 01 Jan 2022 11:07:52 -0500 X-Spam-Threshold: 95 X-Spam-Score: 0 X-Spam-Flag: NO X-Virus-Scanned: OK X-Orig-To: openvpnslackdevel@openvpn.net X-Originating-Ip: [216.105.38.7] Authentication-Results: smtp40.gate.iad3a.rsapps.net; iprev=pass policy.iprev="216.105.38.7"; spf=pass smtp.mailfrom="openvpn-devel-bounces@lists.sourceforge.net" smtp.helo="lists.sourceforge.net"; dkim=fail (signature verification failed) header.d=sourceforge.net; dkim=fail (signature verification failed) header.d=sf.net; dmarc=none (p=nil; dis=none) header.from=rfc2549.org X-Suspicious-Flag: YES X-Classification-ID: f86dece6-6b1c-11ec-b31d-5254003a14f9-1-1 Received: from [216.105.38.7] ([216.105.38.7:46388] helo=lists.sourceforge.net) by smtp40.gate.iad3a.rsapps.net (envelope-from ) (ecelerity 4.2.38.62370 r(:)) with ESMTPS (cipher=DHE-RSA-AES256-GCM-SHA384) id FB/B1-22483-75C70D16; Sat, 01 Jan 2022 11:07:52 -0500 Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.94.2) (envelope-from ) id 1n3gu4-0000Jn-IJ; Sat, 01 Jan 2022 16:06:45 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1n3gu3-0000Jh-Ah for openvpn-devel@lists.sourceforge.net; Sat, 01 Jan 2022 16:06:44 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:Message-Id: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=5h1o1Rl1CS712i52boxfe3g6OjYRwKwo1bwgfSVfQ58=; b=MeaN7FcgS3466DNbrcaPMFma/c S9lXmS1H3v3wppbypDEe5y30sWEFMglxa7aZzJz85Z7vsu2ypq7kTG436fKDJJa2B4TQkJ834rdxy WobzRCdQUIxpOj4d5+pOEHBQL4t9gIb4SddQbdtIqBpRc89+SxlcTipixPVHMZkBrnaU=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject:To:From: Sender:Reply-To:Cc:Content-Type:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=5h1o1Rl1CS712i52boxfe3g6OjYRwKwo1bwgfSVfQ58=; b=V /2PHIVg4Cqjbr+jp0Su7NI+sn2LScE3BtDxg2WFOwIImZmx7bJ/MU8e4SkT3REcU1f7i/08d1JObD Ym0KmpJnG1V60zb3HF3nfvduMbr9Hn6XzJw1E2Wgn0G378rex859kkYWbYiYSG9KFXKFe1ADhNcDA iMQwxhvvxbB0ip8A=; Received: from mail.blinkt.de ([192.26.174.232]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.3) id 1n3gu3-0003bi-CY for openvpn-devel@lists.sourceforge.net; Sat, 01 Jan 2022 16:06:44 +0000 Received: from kamera.blinkt.de ([2001:638:502:390:20c:29ff:fec8:535c]) by mail.blinkt.de with smtp (Exim 4.94.2 (FreeBSD)) (envelope-from ) id 1n3gts-000Fbd-Du for openvpn-devel@lists.sourceforge.net; Sat, 01 Jan 2022 17:06:32 +0100 Received: (nullmailer pid 2250118 invoked by uid 10006); Sat, 01 Jan 2022 16:06:32 -0000 From: Arne Schwabe To: openvpn-devel@lists.sourceforge.net Date: Sat, 1 Jan 2022 17:06:32 +0100 Message-Id: <20220101160632.2250072-1-arne@rfc2549.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Spam-Report: Spam detection software, running on the system "util-spamd-1.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: This code has been dead for years and also does not seem that useful anymore since we already have a proper unit_test for the buffer code. Signed-off-by: Arne Schwabe --- src/openvpn/init.c | 64 1 file changed, 64 deletions(-) Content analysis details: (0.3 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 SPF_NONE SPF: sender does not publish an SPF Record X-Headers-End: 1n3gu3-0003bi-CY Subject: [Openvpn-devel] [PATCH] Remove BUFFER_LIST_AGGREGATE_TEST test code X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox This code has been dead for years and also does not seem that useful anymore since we already have a proper unit_test for the buffer code. Signed-off-by: Arne Schwabe Acked-by: Gert Doering --- src/openvpn/init.c | 64 ---------------------------------------------- 1 file changed, 64 deletions(-) diff --git a/src/openvpn/init.c b/src/openvpn/init.c index e8723714..4e37b885 100644 --- a/src/openvpn/init.c +++ b/src/openvpn/init.c @@ -870,70 +870,6 @@ init_static(void) return false; #endif -#ifdef BUFFER_LIST_AGGREGATE_TEST - /* test buffer_list_aggregate function */ - { - static const char *text[] = { - "It was a bright cold day in April, ", - "and the clocks were striking ", - "thirteen. ", - "Winston Smith, ", - "his chin nuzzled into his breast in an ", - "effort to escape the vile wind, ", - "slipped quickly through the glass doors ", - "of Victory Mansions, though not quickly ", - "enough to prevent a swirl of gritty dust from ", - "entering along with him." - }; - - int iter, listcap; - for (listcap = 0; listcap < 12; ++listcap) - { - for (iter = 0; iter < 512; ++iter) - { - struct buffer_list *bl = buffer_list_new(listcap); - { - int i; - for (i = 0; i < SIZE(text); ++i) - { - buffer_list_push(bl, (unsigned char *)text[i]); - } - } - printf("[cap=%d i=%d] *************************\n", listcap, iter); - if (!(iter & 8)) - { - buffer_list_aggregate(bl, iter/2); - } - if (!(iter & 16)) - { - buffer_list_push(bl, (unsigned char *)"Even more text..."); - } - buffer_list_aggregate(bl, iter); - if (!(iter & 1)) - { - buffer_list_push(bl, (unsigned char *)"More text..."); - } - { - struct buffer *buf; - while ((buf = buffer_list_peek(bl))) - { - int c; - printf("'"); - while ((c = buf_read_u8(buf)) >= 0) - { - putchar(c); - } - printf("'\n"); - buffer_list_advance(bl, 0); - } - } - buffer_list_free(bl); - } - } - return false; - } -#endif /* ifdef BUFFER_LIST_AGGREGATE_TEST */ - #ifdef MSTATS_TEST { int i;