From patchwork Thu Apr 21 03:19:09 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Antonio Quartulli X-Patchwork-Id: 2380 Return-Path: Delivered-To: patchwork@openvpn.net Delivered-To: patchwork@openvpn.net Received: from director10.mail.ord1d.rsapps.net ([172.27.255.56]) by backend41.mail.ord1d.rsapps.net with LMTP id iDkFDDhaYWImCgAAqwncew (envelope-from ) for ; Thu, 21 Apr 2022 09:20:56 -0400 Received: from proxy4.mail.iad3a.rsapps.net ([172.27.255.56]) by director10.mail.ord1d.rsapps.net with LMTP id 4EjFFjhaYWK3PgAApN4f7A (envelope-from ) for ; Thu, 21 Apr 2022 09:20:56 -0400 Received: from smtp9.gate.iad3a ([172.27.255.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by proxy4.mail.iad3a.rsapps.net with LMTPS id 4HPTDzhaYWIVfgAA8Zvu4w (envelope-from ) for ; Thu, 21 Apr 2022 09:20:56 -0400 X-Spam-Threshold: 95 X-Spam-Score: 0 X-Spam-Flag: NO X-Virus-Scanned: OK X-Orig-To: openvpnslackdevel@openvpn.net X-Originating-Ip: [216.105.38.7] Authentication-Results: smtp9.gate.iad3a.rsapps.net; iprev=pass policy.iprev="216.105.38.7"; spf=pass smtp.mailfrom="openvpn-devel-bounces@lists.sourceforge.net" smtp.helo="lists.sourceforge.net"; dkim=fail (signature verification failed) header.d=sourceforge.net; dkim=fail (signature verification failed) header.d=sf.net; dmarc=none (p=nil; dis=none) header.from=unstable.cc X-Suspicious-Flag: YES X-Classification-ID: dfb9238c-c175-11ec-bbb9-52540097fc8c-1-1 Received: from [216.105.38.7] ([216.105.38.7:50326] helo=lists.sourceforge.net) by smtp9.gate.iad3a.rsapps.net (envelope-from ) (ecelerity 4.2.38.62370 r(:)) with ESMTPS (cipher=DHE-RSA-AES256-GCM-SHA384) id 76/81-04747-73A51626; Thu, 21 Apr 2022 09:20:55 -0400 Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.94.2) (envelope-from ) id 1nhWil-0003xD-QS; Thu, 21 Apr 2022 13:19:43 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nhWia-0003w4-KC for openvpn-devel@lists.sourceforge.net; Thu, 21 Apr 2022 13:19:31 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:Message-Id: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Psw42RCC96eIfmxeHwJhRoBeYHLe5djKSDlv/zhQseQ=; b=nUObavWIanN8lAPi1SIVYFTqd5 7aIlOIoy5uHUEt3s2QsJP1d0Q2B5nEcdybOZtKNzUvn4zOsqITEspOLZD4JLRdXQ0Enbv+fetT+JF FzOB+X5PvGJkBkl3zTeuxqoui5/fpmuoGQjiBv9NYSuRe+FUOUILMhfyH/CnhU4eI198=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject:Cc:To:From :Sender:Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=Psw42RCC96eIfmxeHwJhRoBeYHLe5djKSDlv/zhQseQ=; b=j pyEnyogHGTrHL4fKYIMOXtiSO3bPBWRLr3wUGFb+HCzSUg5gbh5kTyx2gaWHRLqlhJT/CC61Uv5zf dP3Cp5WjNy7sTbbDPiLuxH8V6lOS72qRhdskgeXuTwsIkQd4mqD/7YgLhpT7Bg/aaFfKj7N+9pJlg h0dUX7PbZ8M3KI/s=; Received: from s2.neomailbox.net ([5.148.176.60]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.94.2) id 1nhWiY-0006wH-NM for openvpn-devel@lists.sourceforge.net; Thu, 21 Apr 2022 13:19:31 +0000 From: Antonio Quartulli To: openvpn-devel@lists.sourceforge.net Date: Thu, 21 Apr 2022 15:19:09 +0200 Message-Id: <20220421131909.32053-1-a@unstable.cc> MIME-Version: 1.0 X-Spam-Report: Spam detection software, running on the system "util-spamd-1.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On most systems limits.h is pulled in by some other header and thus no error is ever triggered, but it's possible to find the right environment which lackis this and prevents compiling auth-pam.c (pos [...] Content analysis details: (-0.0 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record X-Headers-End: 1nhWiY-0006wH-NM Subject: [Openvpn-devel] [PATCH] auth-pam.c: add missing include limits.h X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Antonio Quartulli , Michelangelo Scopelliti Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox On most systems limits.h is pulled in by some other header and thus no error is ever triggered, but it's possible to find the right environment which lackis this and prevents compiling auth-pam.c (possibly when using LibreSSL). Include the header explicitly as it includes the definition of PATH_MAX. (note that this bug is fixed in Gentoo since 2020 by including a custom patch, but apparently the issue was never reported upstream) Reported-by: Michelangelo Scopelliti Signed-off-by: Antonio Quartulli Acked-by: Gert Doering --- src/plugins/auth-pam/auth-pam.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/plugins/auth-pam/auth-pam.c b/src/plugins/auth-pam/auth-pam.c index f893b51f..70339445 100644 --- a/src/plugins/auth-pam/auth-pam.c +++ b/src/plugins/auth-pam/auth-pam.c @@ -47,6 +47,7 @@ #include #include #include +#include #include "utils.h" #include