From patchwork Fri Apr 22 04:29:44 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arne Schwabe X-Patchwork-Id: 2402 Return-Path: Delivered-To: patchwork@openvpn.net Delivered-To: patchwork@openvpn.net Received: from director10.mail.ord1d.rsapps.net ([172.30.191.6]) by backend41.mail.ord1d.rsapps.net with LMTP id Lk1gAq2+YmLOVQAAqwncew (envelope-from ) for ; Fri, 22 Apr 2022 10:41:49 -0400 Received: from proxy7.mail.ord1d.rsapps.net ([172.30.191.6]) by director10.mail.ord1d.rsapps.net with LMTP id qDjHG62+YmLqfQAApN4f7A (envelope-from ) for ; Fri, 22 Apr 2022 10:41:49 -0400 Received: from smtp1.gate.ord1d ([172.30.191.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by proxy7.mail.ord1d.rsapps.net with LMTPS id cJGXG62+YmJ5LQAAMe1Fpw (envelope-from ) for ; Fri, 22 Apr 2022 10:41:49 -0400 X-Spam-Threshold: 95 X-Spam-Score: 0 X-Spam-Flag: NO X-Virus-Scanned: OK X-Orig-To: openvpnslackdevel@openvpn.net X-Originating-Ip: [216.105.38.7] Authentication-Results: smtp1.gate.ord1d.rsapps.net; iprev=pass policy.iprev="216.105.38.7"; spf=pass smtp.mailfrom="openvpn-devel-bounces@lists.sourceforge.net" smtp.helo="lists.sourceforge.net"; dkim=fail (signature verification failed) header.d=sourceforge.net; dkim=fail (signature verification failed) header.d=sf.net; dmarc=none (p=nil; dis=none) header.from=rfc2549.org X-Suspicious-Flag: YES X-Classification-ID: 56ea00aa-c24a-11ec-b483-5254002d775b-1-1 Received: from [216.105.38.7] ([216.105.38.7:56026] helo=lists.sourceforge.net) by smtp1.gate.ord1d.rsapps.net (envelope-from ) (ecelerity 4.2.38.62370 r(:)) with ESMTPS (cipher=DHE-RSA-AES256-GCM-SHA384) id 63/25-09579-CAEB2626; Fri, 22 Apr 2022 10:41:48 -0400 Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.94.2) (envelope-from ) id 1nhuSl-0005ys-0u; Fri, 22 Apr 2022 14:40:46 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nhuSb-0005xJ-P0 for openvpn-devel@lists.sourceforge.net; Fri, 22 Apr 2022 14:40:37 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=rk8VGpN96rWgml4KvtzPEFh1ML8lDkKbGBUl+uGDQZA=; b=C9g+hslT7fSjw44ng7q9oVIdVu LkMRx5ZCZ6RqPNO5UK88TpteMCj7Q+XR85RbAr97E7WSHl1Bf4Bca0wUAQ6TYdbmFlPFmOLGuT57s cZLigxhNEBSZqP/YIHnK4/LDk4PiWyL6u+AcrmPp7nzwyptQ7Hljp8aTZNeKNUxiDSmY=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-Id: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=rk8VGpN96rWgml4KvtzPEFh1ML8lDkKbGBUl+uGDQZA=; b=lE9VaPXWOMaoHcM9kGSdaL3cFr w2aoTFGxqoMqY+jIDGcsxtKfXuZqdzA2ygm0As0JCHnbuc+EyUp5Ga2/XdtpO30VfCWbRdDYTJXyM huzxNObSPzoxxCGb/qL8TLuuZAs8g0ySxDXvy4HGBQqKVaA6WjTAQ3WfsCXjFuIBnVDs=; Received: from mail.blinkt.de ([192.26.174.232]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.94.2) id 1nhuSa-0006Aj-AF for openvpn-devel@lists.sourceforge.net; Fri, 22 Apr 2022 14:40:36 +0000 Received: from kamera.blinkt.de ([2001:638:502:390:20c:29ff:fec8:535c]) by mail.blinkt.de with smtp (Exim 4.95 (FreeBSD)) (envelope-from ) id 1nhuID-00096l-VH for openvpn-devel@lists.sourceforge.net; Fri, 22 Apr 2022 16:29:53 +0200 Received: (nullmailer pid 3805438 invoked by uid 10006); Fri, 22 Apr 2022 14:29:53 -0000 From: Arne Schwabe To: openvpn-devel@lists.sourceforge.net Date: Fri, 22 Apr 2022 16:29:44 +0200 Message-Id: <20220422142953.3805364-10-arne@rfc2549.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220422142953.3805364-1-arne@rfc2549.org> References: <20220422134038.3801239-1-arne@rfc2549.org> <20220422142953.3805364-1-arne@rfc2549.org> MIME-Version: 1.0 X-Spam-Report: Spam detection software, running on the system "util-spamd-2.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: This functions should accept the type of integer they say to write. Calling the u32 function with an integer that is actually 32 bit unsigned gives compiler warnings. --- src/openvpn/buffer.h | 13 +++ [...] Content analysis details: (0.2 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 SPF_NONE SPF: sender does not publish an SPF Record X-Headers-End: 1nhuSa-0006Aj-AF Subject: [Openvpn-devel] [PATCH 19/28] Make buf_write_u8/16/32 take the type they pretend to take X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox This functions should accept the type of integer they say to write. Calling the u32 function with an integer that is actually 32 bit unsigned gives compiler warnings. Acked-By: Frank Lichtenheld --- src/openvpn/buffer.h | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/src/openvpn/buffer.h b/src/openvpn/buffer.h index 97cc86241..231f1b0d4 100644 --- a/src/openvpn/buffer.h +++ b/src/openvpn/buffer.h @@ -694,23 +694,22 @@ buf_write_prepend(struct buffer *dest, const void *src, int size) } static inline bool -buf_write_u8(struct buffer *dest, int data) +buf_write_u8(struct buffer *dest, uint8_t data) { - uint8_t u8 = (uint8_t) data; - return buf_write(dest, &u8, sizeof(uint8_t)); + return buf_write(dest, &data, sizeof(uint8_t)); } static inline bool -buf_write_u16(struct buffer *dest, int data) +buf_write_u16(struct buffer *dest, uint16_t data) { - uint16_t u16 = htons((uint16_t) data); + uint16_t u16 = htons(data); return buf_write(dest, &u16, sizeof(uint16_t)); } static inline bool -buf_write_u32(struct buffer *dest, int data) +buf_write_u32(struct buffer *dest, uint32_t data) { - uint32_t u32 = htonl((uint32_t) data); + uint32_t u32 = htonl(data); return buf_write(dest, &u32, sizeof(uint32_t)); }