From patchwork Fri May 6 03:28:35 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arne Schwabe X-Patchwork-Id: 2440 Return-Path: Delivered-To: patchwork@openvpn.net Delivered-To: patchwork@openvpn.net Received: from director14.mail.ord1d.rsapps.net ([172.31.255.6]) by backend41.mail.ord1d.rsapps.net with LMTP id +ES5GNgidWK5egAAqwncew (envelope-from ) for ; Fri, 06 May 2022 09:30:00 -0400 Received: from proxy17.mail.iad3b.rsapps.net ([172.31.255.6]) by director14.mail.ord1d.rsapps.net with LMTP id eDZdJtgidWLHWAAAeJ7fFg (envelope-from ) for ; Fri, 06 May 2022 09:30:00 -0400 Received: from smtp14.gate.iad3b ([172.31.255.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by proxy17.mail.iad3b.rsapps.net with LMTPS id OKQlIdgidWLxIgAA5ccGVQ (envelope-from ) for ; Fri, 06 May 2022 09:30:00 -0400 X-Spam-Threshold: 95 X-Spam-Score: 0 X-Spam-Flag: NO X-Virus-Scanned: OK X-Orig-To: openvpnslackdevel@openvpn.net X-Originating-Ip: [216.105.38.7] Authentication-Results: smtp14.gate.iad3b.rsapps.net; iprev=pass policy.iprev="216.105.38.7"; spf=pass smtp.mailfrom="openvpn-devel-bounces@lists.sourceforge.net" smtp.helo="lists.sourceforge.net"; dkim=fail (signature verification failed) header.d=sourceforge.net; dkim=fail (signature verification failed) header.d=sf.net; dmarc=none (p=nil; dis=none) header.from=rfc2549.org X-Suspicious-Flag: YES X-Classification-ID: 9fd32a2a-cd40-11ec-a51c-52540057873d-1-1 Received: from [216.105.38.7] ([216.105.38.7:50092] helo=lists.sourceforge.net) by smtp14.gate.iad3b.rsapps.net (envelope-from ) (ecelerity 4.2.38.62370 r(:)) with ESMTPS (cipher=DHE-RSA-AES256-GCM-SHA384) id 3A/BC-03525-7D225726; Fri, 06 May 2022 09:29:59 -0400 Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.94.2) (envelope-from ) id 1nmy0v-0006aX-2h; Fri, 06 May 2022 13:28:55 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nmy0r-0006aR-Jz for openvpn-devel@lists.sourceforge.net; Fri, 06 May 2022 13:28:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=CxlOvwbU9ue7MJEEJrE/89jYM57FiwvalqpdAdoOHZI=; b=EjEJNeP4xli2aupo/U1nYt+X6W XkB3mGuJPWZqEs1YCk1mb0LSKjKQGNZm2x+Lb7ZjK3YubTqnNPyjFu0LgT1Nn5gizcx1rXRGvp2z2 AeOtGEXe428MOfwGtVDfAaGbaCnSNgSkY8oEAL1mydktPJdL6Atv2UUeI4S1cz5o9CsU=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-Id: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=CxlOvwbU9ue7MJEEJrE/89jYM57FiwvalqpdAdoOHZI=; b=FItIGSbhTmfzGJ0blJLhmZMPvc nuXeWRI7s8jh6KgvemLvpD5TX1/m7QZpFcoh8oVDdBhPBy4616UdwC/XDt/iiBTj2tjrxDXWKDQF0 qNqJvP/nVcT/Qsd2NEMbrshpXraNdWH+zBFplKqWl6DDZugcZsZcYZeh2rN7Oa0AOrCQ=; Received: from mail.blinkt.de ([192.26.174.232]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.94.2) id 1nmy0m-003G4l-IC for openvpn-devel@lists.sourceforge.net; Fri, 06 May 2022 13:28:51 +0000 Received: from kamera.blinkt.de ([2001:638:502:390:20c:29ff:fec8:535c]) by mail.blinkt.de with smtp (Exim 4.95 (FreeBSD)) (envelope-from ) id 1nmy0a-000Hqk-H6 for openvpn-devel@lists.sourceforge.net; Fri, 06 May 2022 15:28:36 +0200 Received: (nullmailer pid 1319035 invoked by uid 10006); Fri, 06 May 2022 13:28:36 -0000 From: Arne Schwabe To: openvpn-devel@lists.sourceforge.net Date: Fri, 6 May 2022 15:28:35 +0200 Message-Id: <20220506132836.1318985-1-arne@rfc2549.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220422142953.3805364-13-arne@rfc2549.org> References: <20220422142953.3805364-13-arne@rfc2549.org> MIME-Version: 1.0 X-Spam-Report: Spam detection software, running on the system "util-spamd-2.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: This adds checking if the code style is still clean github actions with the exact version of uncrustify that is required and might also be helpful for external commiters to get notified about code sty [...] Content analysis details: (0.2 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 SPF_NONE SPF: sender does not publish an SPF Record -0.0 T_SCC_BODY_TEXT_LINE No description available. X-Headers-End: 1nmy0m-003G4l-IC Subject: [Openvpn-devel] [PATCH 1/2] Add uncrustify check to github actions X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox This adds checking if the code style is still clean github actions with the exact version of uncrustify that is required and might also be helpful for external commiters to get notified about code style problem when running the Github actions on their own repository. Signed-off-by: Arne Schwabe Acked-by: Gert Doering --- .github/workflows/build.yaml | 29 +++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+) diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index ac46a72cd..dd23b1426 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -3,6 +3,35 @@ name: Build on: [push, pull_request] jobs: + checkuncrustify: + name: "Check code style with Uncrustify" + # Ubuntu 22.04 has uncrustify 0.72_f + runs-on: ubuntu-22.04 + steps: + - name: Install dependencies + run: sudo apt update && sudo apt install -y uncrustify + - name: Checkout OpenVPN + uses: actions/checkout@v2 + with: + path: openvpn + - name: Show uncrustify version + run: uncrustify --version + - name: Run uncrustify + run: ./dev-tools/reformat-all.sh + working-directory: openvpn + - name: Check for changes + run: git diff --output=uncrustify-changes.patch + working-directory: openvpn + - name: Show changes on standard output + run: git diff + working-directory: openvpn + - uses: actions/upload-artifact@v2 + with: + name: uncrustify-changes.patch + path: 'openvpn/uncrustify-changes.patch' + - name: Set job status + run: test ! -s uncrustify-changes.patch + working-directory: openvpn mingw: strategy: fail-fast: false