Message ID | 20220512231901.1077306-1-heiko@ist.eigentlich.net |
---|---|
State | Accepted |
Headers | show |
Series | [Openvpn-devel] make %x destination unsigned | expand |
Acked-By: Frank Lichtenheld <frank@lichtenheld.com> Trivial and looks correct to me according to the man sscanf. On Fri, May 13, 2022 at 01:19:01AM +0200, Heiko Hund wrote: > The %x specifier requires for the argument to be an unsigned int. > > Signed-off-by: Heiko Hund <heiko@ist.eigentlich.net> > --- > src/openvpn/options.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/openvpn/options.c b/src/openvpn/options.c > index 9ff384d0..3dbd3fab 100644 > --- a/src/openvpn/options.c > +++ b/src/openvpn/options.c > @@ -1104,7 +1104,7 @@ parse_hash_fingerprint(const char *str, int nbytes, int msglevel, struct gc_aren > ALLOC_OBJ_CLEAR_GC(ret, struct verify_hash_list, gc); > > char term = 0; > - int byte; > + unsigned int byte; > > while (*cp && i < nbytes) > { > -- > 2.32.0
Your patch has been applied to the master branch. commit 2f702291484ccecba455b039bc4c04b4cf87e972 Author: Heiko Hund Date: Fri May 13 01:19:01 2022 +0200 make %x destination unsigned Signed-off-by: Heiko Hund <heiko@ist.eigentlich.net> Acked-by: Frank Lichtenheld <frank@lichtenheld.com> Message-Id: <20220512231901.1077306-1-heiko@ist.eigentlich.net> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg24336.html Signed-off-by: Gert Doering <gert@greenie.muc.de> -- kind regards, Gert Doering
diff --git a/src/openvpn/options.c b/src/openvpn/options.c index 9ff384d0..3dbd3fab 100644 --- a/src/openvpn/options.c +++ b/src/openvpn/options.c @@ -1104,7 +1104,7 @@ parse_hash_fingerprint(const char *str, int nbytes, int msglevel, struct gc_aren ALLOC_OBJ_CLEAR_GC(ret, struct verify_hash_list, gc); char term = 0; - int byte; + unsigned int byte; while (*cp && i < nbytes) {
The %x specifier requires for the argument to be an unsigned int. Signed-off-by: Heiko Hund <heiko@ist.eigentlich.net> --- src/openvpn/options.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)