[Openvpn-devel] Fix client-pending-auth error message to say ERROR instead of SUCCESS

Message ID 20220523091724.3418887-1-arne@rfc2549.org
State Accepted
Headers show
Series [Openvpn-devel] Fix client-pending-auth error message to say ERROR instead of SUCCESS | expand

Commit Message

Arne Schwabe May 23, 2022, 9:17 a.m. UTC
---
 src/openvpn/manage.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Frank Lichtenheld May 23, 2022, 10:21 a.m. UTC | #1
Acked-By: Frank Lichtenheld <frank@lichtenheld.com>

Trivial.

> Arne Schwabe <arne@rfc2549.org> hat am 23.05.2022 11:17 geschrieben:
> 
>  
> ---
>  src/openvpn/manage.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/openvpn/manage.c b/src/openvpn/manage.c
> index aeea5f9ff..9c07bf298 100644
> --- a/src/openvpn/manage.c
> +++ b/src/openvpn/manage.c
> @@ -989,7 +989,7 @@ man_client_pending_auth(struct management *man, const char *cid_str,
>              }
>              else
>              {
> -                msg(M_CLIENT, "SUCCESS: client-pending-auth command failed."
> +                msg(M_CLIENT, "ERROR: client-pending-auth command failed."
>                      " Extra paramter might be too long");

We might want to fix "parameter" at the same time.

Regards,
--
Frank Lichtenheld
Gert Doering May 24, 2022, 7:45 a.m. UTC | #2
"paramter" adjusted as suggested. SOB added.

Your patch has been applied to the master and release/2.5 branch.

commit d681e9d42e11b08668fae6e7b61d6a040c93082d (master)
commit 5288c578b8b45dc1486bd51811a3e4462a8a9597 (release/2.5)
Author: Arne Schwabe
Date:   Mon May 23 11:17:24 2022 +0200

     Fix client-pending-auth error message to say ERROR instead of SUCCESS

     Acked-by: Frank Lichtenheld <frank@lichtenheld.com>
     Message-Id: <20220523091724.3418887-1-arne@rfc2549.org>
     URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg24421.html
     Signed-off-by: Gert Doering <gert@greenie.muc.de>


--
kind regards,

Gert Doering

Patch

diff --git a/src/openvpn/manage.c b/src/openvpn/manage.c
index aeea5f9ff..9c07bf298 100644
--- a/src/openvpn/manage.c
+++ b/src/openvpn/manage.c
@@ -989,7 +989,7 @@  man_client_pending_auth(struct management *man, const char *cid_str,
             }
             else
             {
-                msg(M_CLIENT, "SUCCESS: client-pending-auth command failed."
+                msg(M_CLIENT, "ERROR: client-pending-auth command failed."
                     " Extra paramter might be too long");
             }
         }