From patchwork Thu May 26 15:24:54 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiko Hund X-Patchwork-Id: 2495 Return-Path: Delivered-To: patchwork@openvpn.net Delivered-To: patchwork@openvpn.net Received: from director11.mail.ord1d.rsapps.net ([172.27.255.51]) by backend41.mail.ord1d.rsapps.net with LMTP id GB7QDcUokGLVRgAAqwncew (envelope-from ) for ; Thu, 26 May 2022 21:26:29 -0400 Received: from proxy13.mail.iad3a.rsapps.net ([172.27.255.51]) by director11.mail.ord1d.rsapps.net with LMTP id mC9WLcUokGJYewAAvGGmqA (envelope-from ) for ; Thu, 26 May 2022 21:26:29 -0400 Received: from smtp30.gate.iad3a ([172.27.255.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by proxy13.mail.iad3a.rsapps.net with LMTPS id sDjyJMUokGI7QQAAwhxzoA (envelope-from ) for ; Thu, 26 May 2022 21:26:29 -0400 X-Spam-Threshold: 95 X-Spam-Score: 0 X-Spam-Flag: NO X-Virus-Scanned: OK X-Orig-To: openvpnslackdevel@openvpn.net X-Originating-Ip: [216.105.38.7] Authentication-Results: smtp30.gate.iad3a.rsapps.net; iprev=pass policy.iprev="216.105.38.7"; spf=pass smtp.mailfrom="openvpn-devel-bounces@lists.sourceforge.net" smtp.helo="lists.sourceforge.net"; dkim=fail (signature verification failed) header.d=sourceforge.net; dkim=fail (signature verification failed) header.d=sf.net; dmarc=none (p=nil; dis=none) header.from=ist.eigentlich.net X-Suspicious-Flag: YES X-Classification-ID: 076825a2-dd5c-11ec-96e1-525400089674-1-1 Received: from [216.105.38.7] ([216.105.38.7:57074] helo=lists.sourceforge.net) by smtp30.gate.iad3a.rsapps.net (envelope-from ) (ecelerity 4.2.38.62370 r(:)) with ESMTPS (cipher=DHE-RSA-AES256-GCM-SHA384) id 88/1B-00809-3C820926; Thu, 26 May 2022 21:26:28 -0400 Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.94.2) (envelope-from ) id 1nuOjD-0008Aj-T1; Fri, 27 May 2022 01:25:24 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nuOjB-0008Ac-Ir for openvpn-devel@lists.sourceforge.net; Fri, 27 May 2022 01:25:22 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Bj8DwjUIU3/Fj2RzCdj7avTGOF2kt3qfI5hvywA+9Yw=; b=gj22TAeZx8r+5l7dngf0fH1cfn v7HXd1TzvElTWDd3sK6P4mMIE5PWsHuqtErjPRsMcOH4hVzWJyVb8EYWmikOFfD2cEegTqYKe2xFW VY5D0+Td9fkA7SZHaieg4FJ4iCbNGPNGCPMEMd1T7VxbCy4qmbDWYFGk0cbb0G9tPyZs=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-Id: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Bj8DwjUIU3/Fj2RzCdj7avTGOF2kt3qfI5hvywA+9Yw=; b=NeTtJ0Z+l6X+dAZB4ClZc6G5Kd Gx/bagNEz/r6sX/o7TsA7PX+3Gw+5a4Dvr94AZErlPNiyhsXotoc0TvF7oy/OtqzFaoruO9mzM3/V iFDluRTJwQBtuEnKDL8KZ6Q9wm6lganwqjf9xpVCJKb6+TMqask6tOOezQABwZauCugw=; Received: from exit0.net ([85.25.119.185]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.94.2) id 1nuOj7-003WsX-DN for openvpn-devel@lists.sourceforge.net; Fri, 27 May 2022 01:25:21 +0000 Received: from coruscant.fritz.box (unknown [87.123.247.142]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by exit0.net (Postfix) with ESMTPSA id 5DC42648011C for ; Fri, 27 May 2022 03:25:07 +0200 (CEST) From: Heiko Hund To: openvpn-devel@lists.sourceforge.net Date: Fri, 27 May 2022 03:24:54 +0200 Message-Id: <20220527012457.1819262-2-heiko@ist.eigentlich.net> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220527012457.1819262-1-heiko@ist.eigentlich.net> References: <20220527012457.1819262-1-heiko@ist.eigentlich.net> MIME-Version: 1.0 X-Spam-Report: Spam detection software, running on the system "util-spamd-1.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: The call survived since the initial commit 94bfc256d, where it was added as a fallback, since no IPv6 DNS server handling was implemented at the time. Now there's dhcp_option_dns6_parse() which adds t [...] Content analysis details: (0.2 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record X-Headers-End: 1nuOj7-003WsX-DN Subject: [Openvpn-devel] [PATCH 1/4] remove foreign_option() call for IPv6 DNS servers X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox The call survived since the initial commit 94bfc256d, where it was added as a fallback, since no IPv6 DNS server handling was implemented at the time. Now there's dhcp_option_dns6_parse() which adds the servers to the tuntap options, just like how it is done with the v4 servers. Signed-off-by: Heiko Hund Acked-by: Gert Doering --- src/openvpn/options.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/openvpn/options.c b/src/openvpn/options.c index 20cc849d..65f4d889 100644 --- a/src/openvpn/options.c +++ b/src/openvpn/options.c @@ -7825,7 +7825,6 @@ add_option(struct options *options, if (strstr(p[2], ":")) { ipv6dns = true; - foreign_option(options, p, 3, es); dhcp_option_dns6_parse(p[2], o->dns6, &o->dns6_len, msglevel); } else