[Openvpn-devel,2/4] remove dead foreign-option parsing code

Message ID 20220527012457.1819262-3-heiko@ist.eigentlich.net
State Accepted
Headers show
Series [Openvpn-devel,1/4] remove foreign_option() call for IPv6 DNS servers | expand

Commit Message

Heiko Hund May 27, 2022, 1:24 a.m. UTC
Signed-off-by: Heiko Hund <heiko@ist.eigentlich.net>
---
 src/openvpn/options.c | 7 -------
 1 file changed, 7 deletions(-)

Comments

Gert Doering May 27, 2022, 8:20 a.m. UTC | #1
Acked-by: Gert Doering <gert@greenie.muc.de>

Trivial.  Inside #if 0, has been like that since the dawn of times,
so really nobody can ever miss that one.

Your patch has been applied to the master branch.

commit ccdd7096ae9a5fe6f07451f525cbdd40885f3acc
Author: Heiko Hund
Date:   Fri May 27 03:24:55 2022 +0200

     remove dead foreign-option parsing code

     Signed-off-by: Heiko Hund <heiko@ist.eigentlich.net>
     Acked-by: Gert Doering <gert@greenie.muc.de>
     Message-Id: <20220527012457.1819262-3-heiko@ist.eigentlich.net>
     URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg24434.html
     Signed-off-by: Gert Doering <gert@greenie.muc.de>


--
kind regards,

Gert Doering

Patch

diff --git a/src/openvpn/options.c b/src/openvpn/options.c
index 65f4d889..bc3fd6a2 100644
--- a/src/openvpn/options.c
+++ b/src/openvpn/options.c
@@ -5531,13 +5531,6 @@  add_option(struct options *options,
         print_default_gateway(M_INFO, &rgi, &rgi6);
         openvpn_exit(OPENVPN_EXIT_STATUS_GOOD); /* exit point */
     }
-#endif
-#if 0
-    else if (streq(p[0], "foreign-option") && p[1])
-    {
-        VERIFY_PERMISSION(OPT_P_IPWIN32);
-        foreign_option(options, p, 3, es);
-    }
 #endif
     else if (streq(p[0], "echo") || streq(p[0], "parameter"))
     {