From patchwork Mon May 30 05:49:15 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maximilian Fillinger X-Patchwork-Id: 2500 Return-Path: Delivered-To: patchwork@openvpn.net Delivered-To: patchwork@openvpn.net Received: from director13.mail.ord1d.rsapps.net ([172.30.191.6]) by backend41.mail.ord1d.rsapps.net with LMTP id QFRrBdjnlGIvJwAAqwncew (envelope-from ) for ; Mon, 30 May 2022 11:50:48 -0400 Received: from proxy15.mail.ord1d.rsapps.net ([172.30.191.6]) by director13.mail.ord1d.rsapps.net with LMTP id sAZsGdjnlGLTXgAA91zNiA (envelope-from ) for ; Mon, 30 May 2022 11:50:48 -0400 Received: from smtp36.gate.ord1d ([172.30.191.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by proxy15.mail.ord1d.rsapps.net with LMTPS id ON7+F9jnlGJGSAAAAY1PeQ (envelope-from ) for ; Mon, 30 May 2022 11:50:48 -0400 X-Spam-Threshold: 95 X-Spam-Score: 0 X-Spam-Flag: NO X-Virus-Scanned: OK X-Orig-To: openvpnslackdevel@openvpn.net X-Originating-Ip: [216.105.38.7] Authentication-Results: smtp36.gate.ord1d.rsapps.net; iprev=pass policy.iprev="216.105.38.7"; spf=pass smtp.mailfrom="openvpn-devel-bounces@lists.sourceforge.net" smtp.helo="lists.sourceforge.net"; dkim=fail (signature verification failed) header.d=sourceforge.net; dkim=fail (signature verification failed) header.d=sf.net; dkim=fail (key not found in DNS) header.d=foxcrypto.com; dmarc=fail (p=none; dis=none) header.from=foxcrypto.com X-Suspicious-Flag: YES X-Classification-ID: 45aa8efa-e030-11ec-a905-525400c11307-1-1 Received: from [216.105.38.7] ([216.105.38.7:57720] helo=lists.sourceforge.net) by smtp36.gate.ord1d.rsapps.net (envelope-from ) (ecelerity 4.2.38.62370 r(:)) with ESMTPS (cipher=DHE-RSA-AES256-GCM-SHA384) id 93/8B-23213-7D7E4926; Mon, 30 May 2022 11:50:47 -0400 Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.94.2) (envelope-from ) id 1nvheQ-0006zZ-V5; Mon, 30 May 2022 15:49:49 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nvheP-0006zS-J6 for openvpn-devel@lists.sourceforge.net; Mon, 30 May 2022 15:49:48 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:Content-Transfer-Encoding:MIME-Version :Message-ID:Date:Subject:CC:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=0KRDAN1COOp7C5JiWqEjjTscTjgtPEiXvXxS0em3P14=; b=K9NyRjtAsHsi33C9l9KBQKNn1h YceFBEz+2JjT/xmuxtPPME9Hx5MAP3Qz4OiR417EeIyZwH0RIWRsl/JQvIDXaK6wm7lIX0In/z1jH gipVWXVTRrp3ehrSCwT2ZSwdqu3Q0iSnd55TjJQRGC2ZVSKipcOUz39ZuWeL6wTmeOXA=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:Content-Transfer-Encoding:MIME-Version:Message-ID:Date: Subject:CC:To:From:Sender:Reply-To:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=0KRDAN1COOp7C5JiWqEjjTscTjgtPEiXvXxS0em3P14=; b=Z d+Z6af86dbiKy+gC3XbUSqGmbn2vJOw4O0ENwBTG1f5QbPMDkUjz6eFm4rzo5NwOBq0G0o/oDWqwq rUQr3im+3Fyu3zH4o+lEoRSDzf0If1olAAbMGa6PFhPd19S1plnYaHBob4rwvD3hr9qdu0ADE/idy tYlpXWO3xtqv1IkY=; Received: from nl-dft-mx-01.fox-it.com ([178.250.144.135]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.94.2) id 1nvheE-0006od-JF for openvpn-devel@lists.sourceforge.net; Mon, 30 May 2022 15:49:48 +0000 From: Max Fillinger To: Date: Mon, 30 May 2022 17:49:15 +0200 Message-ID: <20220530154915.47349-1-maximilian.fillinger@foxcrypto.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-ClientProxiedBy: FOXDFT1EX01.FOX.local (10.0.0.129) To FOXDFT1EX01.FOX.local (10.0.0.129) X-FE-Policy-ID: 13:3:2:SYSTEM DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; d=foxcrypto.com; s=NL-DFT-MX-01; c=relaxed/relaxed; h=from:to:cc:subject:date:message-id:mime-version:content-type; bh=0KRDAN1COOp7C5JiWqEjjTscTjgtPEiXvXxS0em3P14=; b=DDLWQ8x4cxbNx08YlP9M5H15p2VrSvySsh6aZC4iVRfKfnylEJMT/fY2UmGt3o+Z+P8YDNAFVn5G EQ3S85mF4cDpJGGi3M84m90282sl6IQOOCYolFzufoCo8KLTHv1Hp2i7UkTWxybKZu3VxEhoDi9C S3gnq6QqexUc36Z6kKjfQRobhkem/Qy9ePnnNd4FH4WDgS0uZm8cYgEuX3qIavM+g8y7uyi7YMNA tp3xWXDil6M/Oz0TlkLfq1wOTKYSEEFJeiSfrCWdcPjd/QmRWCrC4kvILzkW/YhlHUJhf7D/2wlq o5xvjoqk5pdIqlrwgh010gIL7b+RVnVOhCAIJw== X-Spam-Report: Spam detection software, running on the system "util-spamd-2.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: When running with --ifconfig-noexec, OpenVPN does not execute ifconfig, but on exit, it still tries to "undo" the configuration it would have done. This patch fixes it by extracting an undo_ifconfig() [...] Content analysis details: (0.2 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.0 T_SCC_BODY_TEXT_LINE No description available. 0.1 DKIM_INVALID DKIM or DK signature exists, but is not valid X-Headers-End: 1nvheE-0006od-JF Subject: [Openvpn-devel] [PATCH v3] Don't "undo" ifconfig on exit if it wasn't done X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox When running with --ifconfig-noexec, OpenVPN does not execute ifconfig, but on exit, it still tries to "undo" the configuration it would have done. This patch fixes it by extracting an undo_ifconfig() function from close_tun(). The undo function is called before close_tun(), but only if --ifconfig-noexec isn't set. This is symmetric to how open_tun() and do_ifconfig() are used. This change also allows us to drop the second argument from close_tun(). v2: Fix tabs-vs-spaces. v3: Fix another style mistake. Signed-off-by: Max Fillinger --- src/openvpn/init.c | 6 +++++- src/openvpn/tun.c | 37 +++++++++++++++++++++---------------- src/openvpn/tun.h | 10 +++++++++- 3 files changed, 35 insertions(+), 18 deletions(-) diff --git a/src/openvpn/init.c b/src/openvpn/init.c index b0c62a85..e52a084e 100644 --- a/src/openvpn/init.c +++ b/src/openvpn/init.c @@ -1858,7 +1858,11 @@ do_close_tun_simple(struct context *c) msg(D_CLOSE, "Closing TUN/TAP interface"); if (c->c1.tuntap) { - close_tun(c->c1.tuntap, &c->net_ctx); + if (!c->options.ifconfig_noexec) + { + undo_ifconfig(c->c1.tuntap, &c->net_ctx); + } + close_tun(c->c1.tuntap); c->c1.tuntap = NULL; } c->c1.tuntap_owned = false; diff --git a/src/openvpn/tun.c b/src/openvpn/tun.c index e12f0369..015bf46d 100644 --- a/src/openvpn/tun.c +++ b/src/openvpn/tun.c @@ -1910,7 +1910,7 @@ open_tun(const char *dev, const char *dev_type, const char *dev_node, struct tun } void -close_tun(struct tuntap *tt, openvpn_net_ctx_t *ctx) +close_tun(struct tuntap *tt) { ASSERT(tt); @@ -2073,7 +2073,7 @@ open_tun(const char *dev, const char *dev_type, const char *dev_node, struct tun void tuncfg(const char *dev, const char *dev_type, const char *dev_node, int persist_mode, const char *username, const char *groupname, - const struct tuntap_options *options, openvpn_net_ctx_t *ctx) + const struct tuntap_options *options) { struct tuntap *tt; @@ -2112,7 +2112,7 @@ tuncfg(const char *dev, const char *dev_type, const char *dev_node, msg(M_ERR, "Cannot ioctl TUNSETGROUP(%s) %s", groupname, dev); } } - close_tun(tt, ctx); + close_tun(tt); msg(M_INFO, "Persist state set to: %s", (persist_mode ? "ON" : "OFF")); } @@ -2179,10 +2179,8 @@ undo_ifconfig_ipv6(struct tuntap *tt, openvpn_net_ctx_t *ctx) } void -close_tun(struct tuntap *tt, openvpn_net_ctx_t *ctx) +undo_ifconfig(struct tuntap *tt, openvpn_net_ctx_t *ctx) { - ASSERT(tt); - if (tt->type != DEV_TYPE_NULL) { if (tt->did_ifconfig_setup) @@ -2199,6 +2197,13 @@ close_tun(struct tuntap *tt, openvpn_net_ctx_t *ctx) net_ctx_reset(ctx); } +} + +void +close_tun(struct tuntap *tt) +{ + ASSERT(tt); + close_tun_generic(tt); free(tt); } @@ -2513,7 +2518,7 @@ solaris_close_tun(struct tuntap *tt) * Close TUN device. */ void -close_tun(struct tuntap *tt, openvpn_net_ctx_t *ctx) +close_tun(struct tuntap *tt) { ASSERT(tt); @@ -2546,7 +2551,7 @@ solaris_error_close(struct tuntap *tt, const struct env_set *es, argv_msg(M_INFO, &argv); openvpn_execve_check(&argv, es, 0, "Solaris ifconfig unplumb failed"); - close_tun(tt, NULL); + close_tun(tt); msg(M_FATAL, "Solaris ifconfig failed"); argv_free(&argv); } @@ -2609,7 +2614,7 @@ open_tun(const char *dev, const char *dev_type, const char *dev_node, struct tun */ void -close_tun(struct tuntap *tt, openvpn_net_ctx_t *ctx) +close_tun(struct tuntap *tt) { ASSERT(tt); @@ -2695,7 +2700,7 @@ open_tun(const char *dev, const char *dev_type, const char *dev_node, struct tun * need to be explicitly destroyed */ void -close_tun(struct tuntap *tt, openvpn_net_ctx_t *ctx) +close_tun(struct tuntap *tt) { ASSERT(tt); @@ -2836,7 +2841,7 @@ open_tun(const char *dev, const char *dev_type, const char *dev_node, struct tun * we need to call "ifconfig ... destroy" for cleanup */ void -close_tun(struct tuntap *tt, openvpn_net_ctx_t *ctx) +close_tun(struct tuntap *tt) { ASSERT(tt); @@ -2952,7 +2957,7 @@ open_tun(const char *dev, const char *dev_type, const char *dev_node, struct tun } void -close_tun(struct tuntap *tt, openvpn_net_ctx_t *ctx) +close_tun(struct tuntap *tt) { ASSERT(tt); @@ -3218,7 +3223,7 @@ open_tun(const char *dev, const char *dev_type, const char *dev_node, struct tun } void -close_tun(struct tuntap *tt, openvpn_net_ctx_t *ctx) +close_tun(struct tuntap *tt) { ASSERT(tt); @@ -3366,7 +3371,7 @@ open_tun(const char *dev, const char *dev_type, const char *dev_node, struct tun /* tap devices need to be manually destroyed on AIX */ void -close_tun(struct tuntap *tt, openvpn_net_ctx_t *ctx) +close_tun(struct tuntap *tt) { ASSERT(tt); @@ -6704,7 +6709,7 @@ netsh_delete_address_dns(const struct tuntap *tt, bool ipv6, struct gc_arena *gc } void -close_tun(struct tuntap *tt, openvpn_net_ctx_t *ctx) +close_tun(struct tuntap *tt) { ASSERT(tt); @@ -6887,7 +6892,7 @@ open_tun(const char *dev, const char *dev_type, const char *dev_node, struct tun } void -close_tun(struct tuntap *tt, openvpn_net_ctx_t *ctx) +close_tun(struct tuntap *tt) { ASSERT(tt); diff --git a/src/openvpn/tun.h b/src/openvpn/tun.h index 4bc35916..71c31e8d 100644 --- a/src/openvpn/tun.h +++ b/src/openvpn/tun.h @@ -247,7 +247,7 @@ tuntap_ring_empty(struct tuntap *tt) void open_tun(const char *dev, const char *dev_type, const char *dev_node, struct tuntap *tt); -void close_tun(struct tuntap *tt, openvpn_net_ctx_t *ctx); +void close_tun(struct tuntap *tt); int write_tun(struct tuntap *tt, uint8_t *buf, int len); @@ -296,6 +296,14 @@ void do_ifconfig_setenv(const struct tuntap *tt, void do_ifconfig(struct tuntap *tt, const char *ifname, int tun_mtu, const struct env_set *es, openvpn_net_ctx_t *ctx); +/** + * undo_ifconfig - undo configuration of the tunnel interface + * + * @param tt the tuntap interface context + * @param ctx the networking API opaque context + */ +void undo_ifconfig(struct tuntap *tt, openvpn_net_ctx_t *ctx); + bool is_dev_type(const char *dev, const char *dev_type, const char *match_type); int dev_type_enum(const char *dev, const char *dev_type);