From patchwork Tue Jun 7 06:30:48 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christopher Ng X-Patchwork-Id: 2510 X-Patchwork-Delegate: davids@openvpn.net Return-Path: Delivered-To: patchwork@openvpn.net Delivered-To: patchwork@openvpn.net Received: from director9.mail.ord1d.rsapps.net ([172.27.255.52]) by backend41.mail.ord1d.rsapps.net with LMTP id 8Hl2FUiLn2JoNgAAqwncew (envelope-from ) for ; Tue, 07 Jun 2022 13:30:48 -0400 Received: from proxy10.mail.iad3a.rsapps.net ([172.27.255.52]) by director9.mail.ord1d.rsapps.net with LMTP id SFvTFUiLn2LGdAAAalYnBA (envelope-from ) for ; Tue, 07 Jun 2022 13:30:48 -0400 Received: from smtp49.gate.iad3a ([172.27.255.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by proxy10.mail.iad3a.rsapps.net with LMTPS id 6M+EDkiLn2LaPQAAnQ/bqA (envelope-from ) for ; Tue, 07 Jun 2022 13:30:48 -0400 X-Spam-Threshold: 95 X-Spam-Score: 0 X-Spam-Flag: NO X-Virus-Scanned: OK X-Orig-To: openvpnslackdevel@openvpn.net X-Originating-Ip: [216.105.38.7] Authentication-Results: smtp49.gate.iad3a.rsapps.net; iprev=pass policy.iprev="216.105.38.7"; spf=pass smtp.mailfrom="openvpn-devel-bounces@lists.sourceforge.net" smtp.helo="lists.sourceforge.net"; dkim=fail (signature verification failed) header.d=sourceforge.net; dkim=fail (signature verification failed) header.d=sf.net; dkim=fail (signature verification failed) header.d=gmail.com; dmarc=fail (p=none; dis=none) header.from=gmail.com X-Suspicious-Flag: YES X-Classification-ID: 9121ffc8-e687-11ec-9dad-525400fffce0-1-1 Received: from [216.105.38.7] ([216.105.38.7:32870] helo=lists.sourceforge.net) by smtp49.gate.iad3a.rsapps.net (envelope-from ) (ecelerity 4.2.38.62370 r(:)) with ESMTPS (cipher=DHE-RSA-AES256-GCM-SHA384) id 65/1A-18465-74B8F926; Tue, 07 Jun 2022 13:30:48 -0400 Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.94.2) (envelope-from ) id 1nyd1Z-0000wm-Gm; Tue, 07 Jun 2022 17:29:48 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nyd1Y-0000wg-TS for openvpn-devel@lists.sourceforge.net; Tue, 07 Jun 2022 17:29:47 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:Message-Id: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Sa60rCtvVuW9Z/NOf6mH4d0GRF4Zi33W/cgiu9OjYsE=; b=KMy2tnXOThbSS29zJuu4pXR1RU SD4Z4mAWqUFvxWyxPT3lFDOnjRJlqs/5uWnqDpxT3/8MZvOwN9BGgmeep0OrJsbvt9KaP1NQlF3AD dM2p8aZ3vYYbCbT32Lt/M380bQ7HMzLtySc/f6qj/yUh5Jz4E0cpwI41u6fWDbhoxIjI=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject:To:From: Sender:Reply-To:Cc:Content-Type:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=Sa60rCtvVuW9Z/NOf6mH4d0GRF4Zi33W/cgiu9OjYsE=; b=W Rz/yEl181+Mf9yoAj1L602mezGmvHKkKhbNnthnc2/AB9u30YcTnaiRze8G4uKMhnvtZyBq/mfW8r xp0dCyNa8gSEtsNhEuSQCq+UF2oPcV1KknRih6WPi7I92kAFU+sxpO+PbseDv/bjNos5B0sFQersj iy5vkSpRVjiSv7fw=; Received: from mail-lj1-f169.google.com ([209.85.208.169]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.94.2) id 1nyd1W-008TZO-Sx for openvpn-devel@lists.sourceforge.net; Tue, 07 Jun 2022 17:29:47 +0000 Received: by mail-lj1-f169.google.com with SMTP id g25so19971881ljm.2 for ; Tue, 07 Jun 2022 10:29:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=Sa60rCtvVuW9Z/NOf6mH4d0GRF4Zi33W/cgiu9OjYsE=; b=Z+9wVeo6ECH8ETq2P9rZTV4BoM99sKjEcJmCVIQ/RH7uVDbKLnToq2YXRgDezzCL+4 G11c35N9byQs4ACQrEltVcHRH/TFwt0gn+zYQJHmDZwokMQtmJHF6mB6gKkOzqA8z6+K hFNKX7PgJIJ/q+82sMgloAzNA6pXJsppS8XoXwzxi8oFC7YvBRJnNurXElLuEy0nOtxI YdjVPTg+nZTugdgvomOrLQp2qFpwehaLFyixp/p85wxJtmpIKWZ6LTRi3d8cQUw+X1P7 XovLf3Bol6JwyrSKno20j2dsqTFoz1zG9w/DJE66/Bcvq+8vqYff+nAajdjsDShAtdy3 4opQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=Sa60rCtvVuW9Z/NOf6mH4d0GRF4Zi33W/cgiu9OjYsE=; b=5J+plmpNdz/FPq38pfODrwEoirSzb/JcdH0Aq4ydBJTq2rxM6n7fTXMcDbavcgsBPk 09xdvXdIJPn9J2I2pH1h8LM6MGupkR+CWyA5epb8/KfpYWwcA4T+kb/hDjckUpi89gPe WyT9WwccZbPKnAnOyW9ySI2+aNzVEdEoXxPaCQ+54a4lQixcZ7GCqIorMJhi1b7VrsAX giBHAExJzp4EfMQOD9zhV3nhRhufSgs76kaBCvsN38dq3yHCjUMprk8Ea7C+8wv8mmRS 8i04Z5tCozs8qziU1vkIrY+MWrR4LOHe/euweGc1TobLK6uTv/jR32uSsKLZVYRt7QaE Nk2A== X-Gm-Message-State: AOAM5307yf+a1TwoMzufbtTB5sUW/67nDMVKItBpOzYAHRTtfTofIKUo 1WUaec/KhepPyyyn387ZAPLxY9TmuS6JaA== X-Google-Smtp-Source: ABdhPJx2Atlbj0nynl3WoDoMvyP1aI8oN3AhPboah2g4aorll9xCCQc8Ka0xRoXGTNU+RijhdQ8GwQ== X-Received: by 2002:a5d:43d2:0:b0:218:3fe6:4127 with SMTP id v18-20020a5d43d2000000b002183fe64127mr11570396wrr.62.1654619467550; Tue, 07 Jun 2022 09:31:07 -0700 (PDT) Received: from localhost.localdomain (33bafc66.skybroadband.com. [51.186.252.102]) by smtp.gmail.com with ESMTPSA id u10-20020adfdd4a000000b002102cc4d63asm21633277wrm.81.2022.06.07.09.31.06 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jun 2022 09:31:06 -0700 (PDT) From: Christopher Ng To: openvpn-devel@lists.sourceforge.net Date: Tue, 7 Jun 2022 17:30:48 +0100 Message-Id: <20220607163049.10056-1-facboy@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Report: Spam detection software, running on the system "util-spamd-2.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Signed-off-by: Christopher Ng --- openvpn/ovpnagent/win/ovpnagent.cpp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/openvpn/ovpnagent/win/ovpnagent.cpp b/openvpn/ovpnagent/win/ovpnagent.cpp index 8a31b0aa..fa020e7d 100644 --- a/openvpn/ovpnagent/win/ovpnagent.cpp +++ b/openvpn/ovpnagent/win/ovpnagent.c [...] Content analysis details: (-0.2 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.208.169 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [facboy[at]gmail.com] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.208.169 listed in wl.mailspike.net] -0.0 T_SCC_BODY_TEXT_LINE No description available. X-Headers-End: 1nyd1W-008TZO-Sx Subject: [Openvpn-devel] [PATCH OpenVPN3 1/2] ovpnagent: fix quoting of omiclient parameters X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox Signed-off-by: Christopher Ng Acked-by: Lev Stipakov --- openvpn/ovpnagent/win/ovpnagent.cpp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/openvpn/ovpnagent/win/ovpnagent.cpp b/openvpn/ovpnagent/win/ovpnagent.cpp index 8a31b0aa..fa020e7d 100644 --- a/openvpn/ovpnagent/win/ovpnagent.cpp +++ b/openvpn/ovpnagent/win/ovpnagent.cpp @@ -444,14 +444,16 @@ public: // create command line for openvpn process std::ostringstream ss; - ss << "client --config " << config_dir << "\\" << config_file << " --exit-event-name " + ss << "client --config \"" << config_dir << "\\" << config_file << "\" --exit-event-name " << exit_event_name << " --auth-retry interact --management " << management_host << " " << management_port << " stdin --management-query-passwords --management-hold " << "--log" - << (log_append ? "-append " : " ") << log; + << (log_append ? "-append \"" : " \"") << log << "\""; std::string cmd = ss.str(); std::unique_ptr buf(new char[cmd.length() + 1]); strcpy(buf.get(), cmd.c_str()); + // OPENVPN_LOG("Launching omiclient: " << config.omiclient_exe.c_str() << " " << buf.get()); + STARTUPINFO startup_info = { 0 }; startup_info.cb = sizeof(startup_info); startup_info.dwFlags = STARTF_USESTDHANDLES;