From patchwork Thu Jun 30 09:05:47 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Selva Nair X-Patchwork-Id: 2570 Return-Path: Delivered-To: patchwork@openvpn.net Delivered-To: patchwork@openvpn.net Received: from director11.mail.ord1d.rsapps.net ([172.30.191.6]) by backend30.mail.ord1d.rsapps.net with LMTP id gCg5BX/0vWK0FwAAIUCqbw (envelope-from ) for ; Thu, 30 Jun 2022 15:07:43 -0400 Received: from proxy14.mail.ord1d.rsapps.net ([172.30.191.6]) by director11.mail.ord1d.rsapps.net with LMTP id yHgABX/0vWKaUAAAvGGmqA (envelope-from ) for ; Thu, 30 Jun 2022 15:07:43 -0400 Received: from smtp30.gate.ord1d ([172.30.191.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by proxy14.mail.ord1d.rsapps.net with LMTPS id mPutBH/0vWKiDQAAtEH5vw (envelope-from ) for ; Thu, 30 Jun 2022 15:07:43 -0400 X-Spam-Threshold: 95 X-Spam-Score: 0 X-Spam-Flag: NO X-Virus-Scanned: OK X-Orig-To: openvpnslackdevel@openvpn.net X-Originating-Ip: [216.105.38.7] Authentication-Results: smtp30.gate.ord1d.rsapps.net; iprev=pass policy.iprev="216.105.38.7"; spf=pass smtp.mailfrom="openvpn-devel-bounces@lists.sourceforge.net" smtp.helo="lists.sourceforge.net"; dkim=fail (signature verification failed) header.d=sourceforge.net; dkim=fail (signature verification failed) header.d=sf.net; dkim=fail (signature verification failed) header.d=gmail.com; dmarc=fail (p=none; dis=none) header.from=gmail.com X-Suspicious-Flag: YES X-Classification-ID: ea37fc7a-f8a7-11ec-ba77-5254001e8e38-1-1 Received: from [216.105.38.7] ([216.105.38.7:44316] helo=lists.sourceforge.net) by smtp30.gate.ord1d.rsapps.net (envelope-from ) (ecelerity 4.2.38.62370 r(:)) with ESMTPS (cipher=DHE-RSA-AES256-GCM-SHA384) id 8F/ED-05693-D74FDB26; Thu, 30 Jun 2022 15:07:42 -0400 Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.94.2) (envelope-from ) id 1o6zUb-0005mN-U3; Thu, 30 Jun 2022 19:06:22 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1o6zUU-0005mG-Qv for openvpn-devel@lists.sourceforge.net; Thu, 30 Jun 2022 19:06:15 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:Message-Id: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=mfdKnNYxxbf552PdnSDHaoZxsJBrdob0VvIdE5DPBoA=; b=OyzUDrW/767xK+VyhXhqc10ZOY rqts4bKV5u2h5zJLBxB2vJmusLejXp4C1gK2UzDseSVBg5udLKtQt1lHdgA2ZG/5SbTOR43qGJrC3 KJSa+krFu7cQniTUq8m1W7EHlLQXTJkNYYcr44wDJ+QWQPDq628ChN4NVVMAkIE325qE=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject:Cc:To:From :Sender:Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=mfdKnNYxxbf552PdnSDHaoZxsJBrdob0VvIdE5DPBoA=; b=O m/Pg64vYBXIb8wc95koiUIJPYKPT5QpnJ8+O535ZWoG8Ai2oXMYq9GO7HxDi47E5wcbxLkEvu7F1o hfsWJVFXNAMUVsrtJ02SBECgBRJd8ev1EISBhblsEsr8Ua/LhUs607eW1eieP0xebPCCHT6bBktcw WZ18WzjKG2otubAI=; Received: from mail-qv1-f45.google.com ([209.85.219.45]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.94.2) id 1o6zUR-002diV-7x for openvpn-devel@lists.sourceforge.net; Thu, 30 Jun 2022 19:06:15 +0000 Received: by mail-qv1-f45.google.com with SMTP id cu16so600463qvb.7 for ; Thu, 30 Jun 2022 12:06:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=mfdKnNYxxbf552PdnSDHaoZxsJBrdob0VvIdE5DPBoA=; b=V5JcF2/w2po1XZTKhk54XpTnOW8sPSeoSpkmGRLem/TC7kgdKIinji6syci/OX6RAH rbLnMXPoCNzOlC24cebMHi0yHIZpSQQCEvExaBAuOSfe/86tG4CzgaSC8xpD11aEPCj5 /tGmfoWijWZN4BmrWoUl7/oMYgBSduP0tKlHkg/wsin9Jeqeav11eIb5KC/yFALkFnim iqocVe6huJAUzpfp1xVqzChOZbkti9snTETXreNoIZYbo65/HA3tpyHgbmxosokqcHmF zB8neEGg5n/ZPO99IyzO9JTr4s7pRXjxiaaarO74G5PVsKbeb/ce6wH82oXaNe4B1W2b vQmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=mfdKnNYxxbf552PdnSDHaoZxsJBrdob0VvIdE5DPBoA=; b=8QevWQBSlXZDnF4LGFuM+k/J2yQQGpnplvL1lzIgQqw0aoQNWbCJbfO2oFMtqz0ExC p/rRkBxaMF2uH6qX2NgucsqEBd3Tx7AXLMjIV3jJ9OdA/wC3Lz7gdEC06t58RCaZ/Oot Vl9FUFd/vgbaK1rJ+eXdbeE0nlEsZdeBC/cvPvknhhskeG1Lxzs4q8tejgkASwuA/+I9 2PdF0IDCWTkeX0cHZIvNJEX+wIf/DxF8+Y6Gq2LhF1Q4X8bbotBuUtgAswzH3uX9j3tk /FoIA80U+R1qM7iPDgiJSs/bQ6Srg56E/TYBhWeYcUwTBHJIrnIyNqX11P8xf4zXXUEL xrEA== X-Gm-Message-State: AJIora/8/BqIQ0CNKtQCXc2DYdQMwuQTzPUVlr2UIeinRd7u2kAHfaFj 69+gQBa430G/RoBE4hkFqEeTo9ZvgtM= X-Google-Smtp-Source: AGRyM1u5O6DmU8vEKY8Powvw4X+wJtQ+F91UcSwi9Tf6/krk/klKify+MKFiJtc8wAd0UrR8Dj5Ghg== X-Received: by 2002:ac8:5b85:0:b0:31c:b896:fb7d with SMTP id a5-20020ac85b85000000b0031cb896fb7dmr9178728qta.188.1656615965094; Thu, 30 Jun 2022 12:06:05 -0700 (PDT) Received: from uranus.home.sansel.ca (bras-vprn-tnhlon4053w-lp130-02-70-51-223-194.dsl.bell.ca. [70.51.223.194]) by smtp.gmail.com with ESMTPSA id ey14-20020a05622a4c0e00b002fcb0d95f65sm13070640qtb.90.2022.06.30.12.06.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jun 2022 12:06:04 -0700 (PDT) From: selva.nair@gmail.com To: openvpn-devel@lists.sourceforge.net Date: Thu, 30 Jun 2022 15:05:47 -0400 Message-Id: <20220630190549.16675-1-selva.nair@gmail.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-Spam-Report: Spam detection software, running on the system "util-spamd-1.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Selva Nair When the port is specified as zero, log the actual port bound to, instead of 0. Signed-off-by: Selva Nair --- src/openvpn/manage.c | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-) Content analysis details: (-0.2 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [selva.nair[at]gmail.com] -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.219.45 listed in list.dnswl.org] X-Headers-End: 1o6zUR-002diV-7x Subject: [Openvpn-devel] [PATCH 1/3] Log the actual management interface port in use X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox From: Selva Nair When the port is specified as zero, log the actual port bound to, instead of 0. Signed-off-by: Selva Nair Acked-by: Gert Doering --- src/openvpn/manage.c | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/src/openvpn/manage.c b/src/openvpn/manage.c index 50f162a3..21c7ccdd 100644 --- a/src/openvpn/manage.c +++ b/src/openvpn/manage.c @@ -1830,8 +1830,22 @@ man_listen(struct management *man) } else #endif - msg(D_MANAGEMENT, "MANAGEMENT: TCP Socket listening on %s", - print_sockaddr(man->settings.local->ai_addr, &gc)); + { + const struct sockaddr *man_addr = man->settings.local->ai_addr; + struct sockaddr_storage addr; + socklen_t addrlen = sizeof(addr); + if (!getsockname(man->connection.sd_top, (struct sockaddr *) &addr, &addrlen)) + { + man_addr = (struct sockaddr *) &addr; + } + else + { + msg(M_WARN|M_ERRNO, + "Failed to get the management socket address"); + } + msg(D_MANAGEMENT, "MANAGEMENT: TCP Socket listening on %s", + print_sockaddr(man_addr, &gc)); + } } #ifdef _WIN32