| Message ID | 20220713121416.1912-1-a@unstable.cc |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [Openvpn-devel] networking_sitnl: always return negative error code in case of failure | expand |
Acked-by: Gert Doering <gert@greenie.muc.de> "obvious in hindsight" :-) Your patch has been applied to the master branch. Not applicable to 2.5, as there is no net_iface_del() yet. commit dab9343a0530ee2468304823181372393d365675 (HEAD -> master) Author: Antonio Quartulli Date: Wed Jul 13 14:14:16 2022 +0200 networking_sitnl: always return negative error code in case of failure Signed-off-by: Antonio Quartulli <a@unstable.cc> Acked-by: Gert Doering <gert@greenie.muc.de> Message-Id: <20220713121416.1912-1-a@unstable.cc> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg24686.html Signed-off-by: Gert Doering <gert@greenie.muc.de> -- kind regards, Gert Doering
diff --git a/src/openvpn/networking_sitnl.c b/src/openvpn/networking_sitnl.c index 0944ad0a..46db2361 100644 --- a/src/openvpn/networking_sitnl.c +++ b/src/openvpn/networking_sitnl.c @@ -1374,7 +1374,7 @@ net_iface_del(openvpn_net_ctx_t *ctx, const char *iface) if (!ifindex) { - return errno; + return -errno; } req.n.nlmsg_len = NLMSG_LENGTH(sizeof(req.i));
The API is designed to always return a negative error code in case of failure, therefore we should return '-errno' when ifindex has failed. Signed-off-by: Antonio Quartulli <a@unstable.cc> --- ** This patch should also go to 2.5 ** src/openvpn/networking_sitnl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)