From patchwork Fri Aug 12 03:06:57 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Antonio Quartulli X-Patchwork-Id: 2664 Return-Path: Delivered-To: patchwork@openvpn.net Delivered-To: patchwork@openvpn.net Received: from director9.mail.ord1d.rsapps.net ([172.31.255.6]) by backend30.mail.ord1d.rsapps.net with LMTP id CCfIDTBS9mJWPgAAIUCqbw (envelope-from ) for ; Fri, 12 Aug 2022 09:14:24 -0400 Received: from proxy10.mail.iad3b.rsapps.net ([172.31.255.6]) by director9.mail.ord1d.rsapps.net with LMTP id OCGeDTBS9mK2fQAAalYnBA (envelope-from ) for ; Fri, 12 Aug 2022 09:14:24 -0400 Received: from smtp38.gate.iad3b ([172.31.255.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by proxy10.mail.iad3b.rsapps.net with LMTPS id gD84CDBS9mJ3FAAA/F5p9A (envelope-from ) for ; Fri, 12 Aug 2022 09:14:24 -0400 X-Spam-Threshold: 95 X-Spam-Score: 0 X-Spam-Flag: NO X-Virus-Scanned: OK X-Orig-To: openvpnslackdevel@openvpn.net X-Originating-Ip: [216.105.38.7] Authentication-Results: smtp38.gate.iad3b.rsapps.net; iprev=pass policy.iprev="216.105.38.7"; spf=pass smtp.mailfrom="openvpn-devel-bounces@lists.sourceforge.net" smtp.helo="lists.sourceforge.net"; dkim=fail (signature verification failed) header.d=sourceforge.net; dkim=fail (signature verification failed) header.d=sf.net; dmarc=fail (p=none; dis=none) header.from=unstable.cc X-Suspicious-Flag: YES X-Classification-ID: aea35a64-1a40-11ed-acbe-5254006f0979-1-1 Received: from [216.105.38.7] ([216.105.38.7:35836] helo=lists.sourceforge.net) by smtp38.gate.iad3b.rsapps.net (envelope-from ) (ecelerity 4.2.38.62370 r(:)) with ESMTPS (cipher=DHE-RSA-AES256-GCM-SHA384) id 5D/27-30867-F2256F26; Fri, 12 Aug 2022 09:14:23 -0400 Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1oMUTA-00015l-Ov; Fri, 12 Aug 2022 13:12:56 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oMUT1-00015Y-Cc for openvpn-devel@lists.sourceforge.net; Fri, 12 Aug 2022 13:12:47 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=jO+Y1PpakNrrF4GC63uLbtsLi8OPjGGLCZbfxlstW3w=; b=X+lc2KoqTVdLlPdQlLIKu2rO+w ajlpTLOHJEtT6uqsP7h51D3/nHPdC1Q9a0dWgEHv3u86btFf8oRbcXj78hJHZCd3doibOf1Zb+QjH t/s5jaEPUDhOuTpsCm7CFOOD4Vvjpf9B215J1EhFYKig+uQLOVrkf4cJkfXuPvhAsK1A=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-Id: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=jO+Y1PpakNrrF4GC63uLbtsLi8OPjGGLCZbfxlstW3w=; b=NIFQGllpjkD+vMXWyBQpD15a+i 2sYCtYy2KfOtz11qM+AN6XaUL9buJNFeAcuG+bKkYlDsW7a0G9UtmNJYYQlJTAiV0M21j8mPy/UUp SILZUgW976GpG0FjOKA5Pd8bp8F/FhYJD/kZahotw+l5z8bhSGJR9cJ4QmbHsI1KkDbY=; Received: from s2.neomailbox.net ([5.148.176.60]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.94.2) id 1oMUT0-0003W3-IO for openvpn-devel@lists.sourceforge.net; Fri, 12 Aug 2022 13:12:47 +0000 From: Antonio Quartulli To: openvpn-devel@lists.sourceforge.net Date: Fri, 12 Aug 2022 15:06:57 +0200 Message-Id: <20220812130657.29899-11-a@unstable.cc> In-Reply-To: <20220812130657.29899-1-a@unstable.cc> References: <20220812130657.29899-1-a@unstable.cc> MIME-Version: 1.0 X-Spam-Report: Spam detection software, running on the system "util-spamd-2.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: This message is purely a debug message, so it should go to the appropriate log level. At the same time make it more clear. Signed-off-by: Antonio Quartulli --- src/openvpn/dco_linux.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Content analysis details: (1.0 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 T_SCC_BODY_TEXT_LINE No description available. X-Headers-End: 1oMUT0-0003W3-IO Subject: [Openvpn-devel] [PATCH v100 10/10] dco: move message to DCO debug level and reword a bit X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Antonio Quartulli Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox This message is purely a debug message, so it should go to the appropriate log level. At the same time make it more clear. Signed-off-by: Antonio Quartulli Acked-by: Gert Doering --- src/openvpn/dco_linux.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/openvpn/dco_linux.c b/src/openvpn/dco_linux.c index 9212339e..98e10507 100644 --- a/src/openvpn/dco_linux.c +++ b/src/openvpn/dco_linux.c @@ -760,7 +760,8 @@ ovpn_handle_msg(struct nl_msg *msg, void *arg) uint32_t ifindex = nla_get_u32(attrs[OVPN_ATTR_IFINDEX]); if (ifindex != dco->ifindex) { - msg(D_DCO, "ovpn-dco: received message type %d with mismatched ifindex %d\n", + msg(D_DCO_DEBUG, + "ovpn-dco: ignoring message (type=%d) for foreign ifindex %d", gnlh->cmd, ifindex); return NL_SKIP; }