From patchwork Fri Aug 12 03:06:55 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Antonio Quartulli X-Patchwork-Id: 2659 Return-Path: Delivered-To: patchwork@openvpn.net Delivered-To: patchwork@openvpn.net Received: from director14.mail.ord1d.rsapps.net ([172.30.191.6]) by backend30.mail.ord1d.rsapps.net with LMTP id ONbhI8FQ9mI8NAAAIUCqbw (envelope-from ) for ; Fri, 12 Aug 2022 09:08:17 -0400 Received: from proxy6.mail.ord1d.rsapps.net ([172.30.191.6]) by director14.mail.ord1d.rsapps.net with LMTP id oDmeI8FQ9mIuHgAAeJ7fFg (envelope-from ) for ; Fri, 12 Aug 2022 09:08:17 -0400 Received: from smtp40.gate.ord1d ([172.30.191.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by proxy6.mail.ord1d.rsapps.net with LMTPS id +DcRI8FQ9mIKNwAAQyIf0w (envelope-from ) for ; Fri, 12 Aug 2022 09:08:17 -0400 X-Spam-Threshold: 95 X-Spam-Score: 0 X-Spam-Flag: NO X-Virus-Scanned: OK X-Orig-To: openvpnslackdevel@openvpn.net X-Originating-Ip: [216.105.38.7] Authentication-Results: smtp40.gate.ord1d.rsapps.net; iprev=pass policy.iprev="216.105.38.7"; spf=pass smtp.mailfrom="openvpn-devel-bounces@lists.sourceforge.net" smtp.helo="lists.sourceforge.net"; dkim=fail (signature verification failed) header.d=sourceforge.net; dkim=fail (signature verification failed) header.d=sf.net; dmarc=fail (p=none; dis=none) header.from=unstable.cc X-Suspicious-Flag: YES X-Classification-ID: d44ae51c-1a3f-11ed-8464-525400f204c2-1-1 Received: from [216.105.38.7] ([216.105.38.7:49714] helo=lists.sourceforge.net) by smtp40.gate.ord1d.rsapps.net (envelope-from ) (ecelerity 4.2.38.62370 r(:)) with ESMTPS (cipher=DHE-RSA-AES256-GCM-SHA384) id 98/37-23997-0C056F26; Fri, 12 Aug 2022 09:08:17 -0400 Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1oMUNV-0000th-CN; Fri, 12 Aug 2022 13:07:05 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oMUNP-0000sp-W0 for openvpn-devel@lists.sourceforge.net; Fri, 12 Aug 2022 13:07:00 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=AcwjARYDBg8dXAwYVx7n6OL+faR7Bm/sPtNj2YXE/1w=; b=fsouwAQByOe1elzd6tovoMhh/Z EQ36pGmDHZLlyiZWhOmk5HbFSuQVvc+Va7+ovc/TbQM7dBMK+z8/ips47FLSKdYrFinNGlcyTCvRU qHUdJdYLvt6xCba+y0vCRUgpOw+3M13OC2cddHN0StQ0zO42qJ55itB0R7xWeXEuo0lw=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-Id: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=AcwjARYDBg8dXAwYVx7n6OL+faR7Bm/sPtNj2YXE/1w=; b=i/8idYUimcPpQWoaH5YcVqlkFG ITd7LHT03k3cqsdvzOy39cagO4Yb3/7Yhm36hx3+RO/GtgLEUjLgZDeRtSv8YuNfXqjDEj339qLqN Yev24ZsqqOabeb9DJZAglekNVr9b7duxqOaieGtzaGRI/H0qfGqw5FTb++oHM7fAkPOc=; Received: from s2.neomailbox.net ([5.148.176.60]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.94.2) id 1oMUN0-0002MJ-9o for openvpn-devel@lists.sourceforge.net; Fri, 12 Aug 2022 13:06:49 +0000 From: Antonio Quartulli To: openvpn-devel@lists.sourceforge.net Date: Fri, 12 Aug 2022 15:06:55 +0200 Message-Id: <20220812130657.29899-9-a@unstable.cc> In-Reply-To: <20220812130657.29899-1-a@unstable.cc> References: <20220812130657.29899-1-a@unstable.cc> MIME-Version: 1.0 X-Spam-Report: Spam detection software, running on the system "util-spamd-2.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Netlink errors detected during dco availability detection are not really required and can confuse the user. Have them printed to the dco debug level. Signed-off-by: Antonio Quartulli --- src/openvpn/dco_linux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Content analysis details: (1.0 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 T_SCC_BODY_TEXT_LINE No description available. X-Headers-End: 1oMUN0-0002MJ-9o Subject: [Openvpn-devel] [PATCH v100 08/10] ovpn-dco: print some netlink messages to debug level X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Antonio Quartulli Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox Netlink errors detected during dco availability detection are not really required and can confuse the user. Have them printed to the dco debug level. Signed-off-by: Antonio Quartulli Acked-by: Gert Doering --- src/openvpn/dco_linux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/openvpn/dco_linux.c b/src/openvpn/dco_linux.c index f86ea819..9212339e 100644 --- a/src/openvpn/dco_linux.c +++ b/src/openvpn/dco_linux.c @@ -913,7 +913,7 @@ nla_put_failure: bool dco_available(int msglevel) { - if (resolve_ovpn_netlink_id(msglevel) < 0) + if (resolve_ovpn_netlink_id(D_DCO_DEBUG) < 0) { msg(msglevel, "Note: Kernel support for ovpn-dco missing, disabling data channel offload.");