From patchwork Sat Sep 17 04:05:18 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Antonio Quartulli X-Patchwork-Id: 2765 Return-Path: Delivered-To: patchwork@openvpn.net Delivered-To: patchwork@openvpn.net Received: from director7.mail.ord1d.rsapps.net ([172.31.255.6]) by backend30.mail.ord1d.rsapps.net with LMTP id GJL+EGrUJWN6AgAAIUCqbw (envelope-from ) for ; Sat, 17 Sep 2022 10:06:34 -0400 Received: from proxy3.mail.iad3b.rsapps.net ([172.31.255.6]) by director7.mail.ord1d.rsapps.net with LMTP id EF75EGrUJWMMQgAAovjBpQ (envelope-from ) for ; Sat, 17 Sep 2022 10:06:34 -0400 Received: from smtp26.gate.iad3b ([172.31.255.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by proxy3.mail.iad3b.rsapps.net with LMTPS id EK/dCGrUJWNrbAAAM8Wetg (envelope-from ) for ; Sat, 17 Sep 2022 10:06:34 -0400 X-Spam-Threshold: 95 X-Spam-Score: 0 X-Spam-Flag: NO X-Virus-Scanned: OK X-Orig-To: openvpnslackdevel@openvpn.net X-Originating-Ip: [216.105.38.7] Authentication-Results: smtp26.gate.iad3b.rsapps.net; iprev=pass policy.iprev="216.105.38.7"; spf=pass smtp.mailfrom="openvpn-devel-bounces@lists.sourceforge.net" smtp.helo="lists.sourceforge.net"; dkim=fail (signature verification failed) header.d=sourceforge.net; dkim=fail (signature verification failed) header.d=sf.net; dkim=fail (signature verification failed) header.d=unstable.cc; dmarc=none (p=nil; dis=none) header.from=unstable.cc X-Suspicious-Flag: YES X-Classification-ID: ef43b1e6-3691-11ed-9ddd-5254001088d3-1-1 Received: from [216.105.38.7] ([216.105.38.7:53592] helo=lists.sourceforge.net) by smtp26.gate.iad3b.rsapps.net (envelope-from ) (ecelerity 4.2.38.62370 r(:)) with ESMTPS (cipher=DHE-RSA-AES256-GCM-SHA384) id DC/8A-29610-964D5236; Sat, 17 Sep 2022 10:06:33 -0400 Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1oZYRi-0004k9-UA; Sat, 17 Sep 2022 14:05:39 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oZYRh-0004k3-F8 for openvpn-devel@lists.sourceforge.net; Sat, 17 Sep 2022 14:05:38 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:Message-Id: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=4gbRO9OfiFux9EtoDJ594SKHZEO3eyDphpf/LXti33g=; b=fRcT0t0kJbDdIOzGXhVVav5/3E KpqrrPAB5NRYrAqQ0/dR877Q/BaBzlVAM9YqxaP+2gjKIHo7v5pDc0rQQOgAgJHdIfM/GrUV3WyEc DnItYKgHM3vM/CutcZzW47cYtCIN+98tXRm3E/GMm3bNWRbdXsFVzQ+oTwTQakpTxtPc=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject:Cc:To:From :Sender:Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=4gbRO9OfiFux9EtoDJ594SKHZEO3eyDphpf/LXti33g=; b=J eyrXA2J5eL+8rXp4hZg4GSKRpiTJrhidi4TOuUmHmlIdDHB2mk2fjZQAbr0XaS2LgazWK29Jl16OV fq9eDZZ9/KDiB7Vi3MwdAsAWgByvELWewri2LX34LX4fFpi4tSUrynCWJ9nw0NZ49HISbecPLeE3z PEYTiD8hP4ZEPZps=; Received: from wilbur.contactoffice.com ([212.3.242.68]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1oZYRr-00BGqT-R1 for openvpn-devel@lists.sourceforge.net; Sat, 17 Sep 2022 14:05:37 +0000 Received: from smtpauth1.co-bxl (smtpauth1.co-bxl [10.2.0.15]) by wilbur.contactoffice.com (Postfix) with ESMTP id 7A77D8A2; Sat, 17 Sep 2022 16:05:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1663423529; s=20220809-q8oc; d=unstable.cc; i=a@unstable.cc; h=From:Cc:Date:Message-Id:MIME-Version:Content-Transfer-Encoding; l=798; bh=4gbRO9OfiFux9EtoDJ594SKHZEO3eyDphpf/LXti33g=; b=GDGPemALKL/m6PR852j1aVyittUTt/THXzi7i9nH0lkhTrenuOJenrEnfTNPAg3U Pz/snRyo/Stc2cYidXKxVn/X10r+nTFmV/QXlj4/iWHvolMeR2Q5L7+bHaM4R3viaKN Qbk36PeqVmQp67VgA7r4KIzW8Rm8ZIJA2U6FP4mLr4t5jYYYGbAggpGasZZNnjpeOgV xtaCxgw31NiHcrIcYY1oJtpLv4s18GrruRtRRwCsYxhGiDYGkk8OuvKByqsxT32yRlE wIWYCMGMc8/Fie5kIQjnbY1p2zWieD8GEzHH2ei5LLrehLLRhVndlifZ86uWzWxHWxX 1UTHOJZ3rQ== Received: by smtp.mailfence.com with ESMTPSA ; Sat, 17 Sep 2022 16:05:25 +0200 (CEST) From: Antonio Quartulli To: openvpn-devel@lists.sourceforge.net Date: Sat, 17 Sep 2022 16:05:18 +0200 Message-Id: <20220917140518.2497-1-a@unstable.cc> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 X-Spam-Status: No, hits=-2.9 required=4.7 symbols=ALL_TRUSTED, BAYES_00 device=10.2.0.1 X-ContactOffice-Account: com:375058688 X-Spam-Report: Spam detection software, running on the system "util-spamd-2.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Alexandr Kutashov It's better to have distinct enums for more straightforward debug of exit function. Signed-off-by: Alexandr Kutashov --- src/openvpn/error.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Content analysis details: (-0.9 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [212.3.242.68 listed in list.dnswl.org] 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: unstable.cc] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-Headers-End: 1oZYRr-00BGqT-R1 Subject: [Openvpn-devel] [PATCH] Changes open vpn exit code defines X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandr Kutashov Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox From: Alexandr Kutashov It's better to have distinct enums for more straightforward debug of exit function. Signed-off-by: Alexandr Kutashov --- src/openvpn/error.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/openvpn/error.h b/src/openvpn/error.h index 89adb3e6..6289c0d8 100644 --- a/src/openvpn/error.h +++ b/src/openvpn/error.h @@ -58,8 +58,8 @@ struct gc_arena; #define OPENVPN_EXIT_STATUS_GOOD 0 #define OPENVPN_EXIT_STATUS_ERROR 1 -#define OPENVPN_EXIT_STATUS_USAGE 1 -#define OPENVPN_EXIT_STATUS_CANNOT_OPEN_DEBUG_FILE 1 +#define OPENVPN_EXIT_STATUS_USAGE 2 +#define OPENVPN_EXIT_STATUS_CANNOT_OPEN_DEBUG_FILE 3 /* * Special command line debugging mode.