From patchwork Wed Nov 30 10:56:09 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Selva Nair X-Patchwork-Id: 2873 Return-Path: Delivered-To: patchwork@openvpn.net Delivered-To: patchwork@openvpn.net Received: from director11.mail.ord1d.rsapps.net ([172.31.255.6]) by backend30.mail.ord1d.rsapps.net with LMTP id GPGeDP02h2PBDgAAIUCqbw (envelope-from ) for ; Wed, 30 Nov 2022 05:57:01 -0500 Received: from proxy14.mail.iad3b.rsapps.net ([172.31.255.6]) by director11.mail.ord1d.rsapps.net with LMTP id 6EJpDP02h2NsRAAAvGGmqA (envelope-from ) for ; Wed, 30 Nov 2022 05:57:01 -0500 Received: from smtp12.gate.iad3b ([172.31.255.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by proxy14.mail.iad3b.rsapps.net with LMTPS id sM6ZBf02h2OlPAAA+7ETDg (envelope-from ) for ; Wed, 30 Nov 2022 05:57:01 -0500 X-Spam-Threshold: 95 X-Spam-Score: 0 X-Spam-Flag: NO X-Virus-Scanned: OK X-Orig-To: openvpnslackdevel@openvpn.net X-Originating-Ip: [216.105.38.7] Authentication-Results: smtp12.gate.iad3b.rsapps.net; iprev=pass policy.iprev="216.105.38.7"; spf=pass smtp.mailfrom="openvpn-devel-bounces@lists.sourceforge.net" smtp.helo="lists.sourceforge.net"; dkim=fail (signature verification failed) header.d=sourceforge.net; dkim=fail (signature verification failed) header.d=sf.net; dkim=fail (signature verification failed) header.d=gmail.com; dmarc=fail (p=none; dis=none) header.from=gmail.com X-Suspicious-Flag: YES X-Classification-ID: b6ce49b6-709d-11ed-ad79-525400ae1f9d-1-1 Received: from [216.105.38.7] ([216.105.38.7:58670] helo=lists.sourceforge.net) by smtp12.gate.iad3b.rsapps.net (envelope-from ) (ecelerity 4.2.38.62370 r(:)) with ESMTPS (cipher=DHE-RSA-AES256-GCM-SHA384) id 22/12-08564-CF637836; Wed, 30 Nov 2022 05:57:00 -0500 Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1p0Klb-0008Fe-Md; Wed, 30 Nov 2022 10:56:39 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1p0Kla-0008FU-L0 for openvpn-devel@lists.sourceforge.net; Wed, 30 Nov 2022 10:56:38 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:Message-Id: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ZwbdU4Bx8uO8Yfz1e8ziuZrTFwLAL977YyrIUC8n3ak=; b=DYuN5bz1/2O+bfDhLZ4d4pu03H S4ehI31fP32QMtKWClO2res4cenCEMIurL9LhqFpLvbpX/guvUlB8h8UuGOZ2PkT2ePFmoSZmTAfJ 1hsv8ZdR4ywJnUYrRwUy4B76CGW5Ut8Z/9wl7Rc6kUPYP5SLvVWpMxcXEQtqG08Ew9qg=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject:Cc:To:From :Sender:Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=ZwbdU4Bx8uO8Yfz1e8ziuZrTFwLAL977YyrIUC8n3ak=; b=Z arm+A0Rh9MNDvC7DcOkaUvJLhQA+YAqdqN/gnkAhamjJRtL8mCwfj5vNLZJzTMeaiQy8IVcjUN56b dPEMqtDBQgJbBCsNlTQcjff6pQ/7p+nljjXjLr86BcQlSnI8Xo5qCiU1lXpkQoskM7tf7U+HSUPDm O5g60JtaBXtuZLcw=; Received: from mail-il1-f170.google.com ([209.85.166.170]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1p0Kla-001K1x-5R for openvpn-devel@lists.sourceforge.net; Wed, 30 Nov 2022 10:56:38 +0000 Received: by mail-il1-f170.google.com with SMTP id q13so7950959ild.3 for ; Wed, 30 Nov 2022 02:56:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ZwbdU4Bx8uO8Yfz1e8ziuZrTFwLAL977YyrIUC8n3ak=; b=R57ihH7NJPCbSN49n7LVyamUygzC8qnLo5cdeJaD7IpRfa9CqJ8rvGmQdx5nK0BoAk kAmybYZ5Men5JKoxNgQd5Ep+J137pFfhJMkXIs6DLpiAk5yudIw317AIpyjT5gXZXda+ ZA18X/nwcVwd2TRuxvK+0t5sDgrT03FKIJvHu9d6rpgXqIBTdV0hO9C0I+v8NKi5S+tY fBVHNoTMQpjmS4iXrCZw4usd9/OIVb0OEs1S8sPYp+wPWJXAQiEcxVGy+rqvj7m9oR01 JHRqsfpPypefgnJDNiV/ipdp//+ulJry/P7kBTS4/gToZ4ZJibNjyF5bv4l7LB73Gkpa BziA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ZwbdU4Bx8uO8Yfz1e8ziuZrTFwLAL977YyrIUC8n3ak=; b=XHpmDomYhLfTSKbc8BKkPtcASrrDH3zkbfVf2n5Z0pCttZ0BmwzBK9e7QGpgukg4u0 i3roHF7nH1StRKL0cC5dHdniaynCqkZQ/QBhDTLN0OR9PvmkFcFSQwtqXXVPU8bsc5e/ vMw8GaOTlYXK4ZG8S0GW8g+igSVEDE6VL0jkVnggT45VWOFjaa5L2sVbOkTXsMTtoAe4 Hw35gAoVDnb6TFFdMy6NCYE44mXAP38Tf+lPCyL5SHbqOOt1Lk4y2Yi4tFErVg6lKfWv 2FeYEJ2TnwkwjR9zVwYalJUcMQxaWdR2dObS9VwcatQfcNn4zGf8FUum29VSdWhB3TNX MX+Q== X-Gm-Message-State: ANoB5plXD1D4dqWTyn9niJzMCah53xSpwcgPLZFVEYJ6Jzcusl0UekHU p09tKYjlCBb6Hp7G+jwB0heFYkzKcvM= X-Google-Smtp-Source: AA0mqf7Ba5TDbt/4fwsNSEqVx0s42xl6T7SSzE/N+b8NkolW7H8nqaE5sxfNGow+uVVUpLozq3zeAw== X-Received: by 2002:a92:d144:0:b0:300:5d50:15d3 with SMTP id t4-20020a92d144000000b003005d5015d3mr17943848ilg.173.1669805792345; Wed, 30 Nov 2022 02:56:32 -0800 (PST) Received: from uranus.sansel.ca (bras-vprn-tnhlon4053w-lp130-01-70-51-222-66.dsl.bell.ca. [70.51.222.66]) by smtp.gmail.com with ESMTPSA id q9-20020a920509000000b00302f450957csm455273ile.1.2022.11.30.02.56.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Nov 2022 02:56:32 -0800 (PST) From: selva.nair@gmail.com To: openvpn-devel@lists.sourceforge.net Date: Wed, 30 Nov 2022 05:56:09 -0500 Message-Id: <20221130105609.662402-1-selva.nair@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Report: Spam detection software, running on the system "util-spamd-2.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Selva Nair This makes auth-token push during reneg consistent with regular PUSH_REPLY. Signed-off-by: Selva Nair --- src/openvpn/push.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Content analysis details: (-0.2 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.166.170 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [selva.nair[at]gmail.com] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.166.170 listed in wl.mailspike.net] X-Headers-End: 1p0Kla-001K1x-5R Subject: [Openvpn-devel] [PATCH] Do not add leading space to pushed options X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox From: Selva Nair This makes auth-token push during reneg consistent with regular PUSH_REPLY. Signed-off-by: Selva Nair Acked-by: Gert Doering --- src/openvpn/push.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/openvpn/push.c b/src/openvpn/push.c index 92a0bc2d..f8c747d4 100644 --- a/src/openvpn/push.c +++ b/src/openvpn/push.c @@ -746,7 +746,7 @@ send_push_reply_auth_token(struct tls_multi *multi) /* Construct a mimimal control channel push reply message */ struct buffer buf = alloc_buf_gc(PUSH_BUNDLE_SIZE, &gc); - buf_printf(&buf, "%s, %s", push_reply_cmd, e->option); + buf_printf(&buf, "%s,%s", push_reply_cmd, e->option); send_control_channel_string_dowork(multi, BSTR(&buf), D_PUSH); gc_free(&gc); }