From patchwork Thu Dec 1 12:59:02 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lev Stipakov X-Patchwork-Id: 2882 Return-Path: Delivered-To: patchwork@openvpn.net Delivered-To: patchwork@openvpn.net Received: from director10.mail.ord1d.rsapps.net ([172.30.191.6]) by backend30.mail.ord1d.rsapps.net with LMTP id iB96FUmliGNkIwAAIUCqbw (envelope-from ) for ; Thu, 01 Dec 2022 07:59:53 -0500 Received: from proxy4.mail.ord1d.rsapps.net ([172.30.191.6]) by director10.mail.ord1d.rsapps.net with LMTP id +E/kFEmliGPGZwAApN4f7A (envelope-from ) for ; Thu, 01 Dec 2022 07:59:53 -0500 Received: from smtp30.gate.ord1d ([172.30.191.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by proxy4.mail.ord1d.rsapps.net with LMTPS id qBr2FEmliGPpPAAAiYrejw (envelope-from ) for ; Thu, 01 Dec 2022 07:59:53 -0500 X-Spam-Threshold: 95 X-Spam-Score: 0 X-Spam-Flag: NO X-Virus-Scanned: OK X-Orig-To: openvpnslackdevel@openvpn.net X-Originating-Ip: [216.105.38.7] Authentication-Results: smtp30.gate.ord1d.rsapps.net; iprev=pass policy.iprev="216.105.38.7"; spf=pass smtp.mailfrom="openvpn-devel-bounces@lists.sourceforge.net" smtp.helo="lists.sourceforge.net"; dkim=fail (signature verification failed) header.d=sourceforge.net; dkim=fail (signature verification failed) header.d=sf.net; dkim=fail (signature verification failed) header.d=gmail.com; dmarc=fail (p=none; dis=none) header.from=gmail.com X-Suspicious-Flag: YES X-Classification-ID: 0b70a5ec-7178-11ed-85d7-5254001e8e38-1-1 Received: from [216.105.38.7] ([216.105.38.7:38396] helo=lists.sourceforge.net) by smtp30.gate.ord1d.rsapps.net (envelope-from ) (ecelerity 4.2.38.62370 r(:)) with ESMTPS (cipher=DHE-RSA-AES256-GCM-SHA384) id 6A/D0-00540-845A8836; Thu, 01 Dec 2022 07:59:52 -0500 Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1p0j9z-0002DY-3I; Thu, 01 Dec 2022 12:59:27 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1p0j9x-0002DS-UI for openvpn-devel@lists.sourceforge.net; Thu, 01 Dec 2022 12:59:25 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:Message-Id: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=FRToeiPghRJx6v+DswQq2UfIamNXEY/LNR4JN9i6rBY=; b=X4zq3AnVdPEAW0uIAJMuMojxkl HSf/5Pxdjo8A3+u8vEl/OrpXzDUxtHbGPqnbijMflUJL4vRq15W2my9UlnOBJXqdo04VvB/v/5awB 3xqdNj86jAiatq+9Xe3nvjzm2yFa0tgKFgPsfqhYRC8eHLTMByjWtkqLKH290i1jiBuw=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject:Cc:To:From :Sender:Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=FRToeiPghRJx6v+DswQq2UfIamNXEY/LNR4JN9i6rBY=; b=U BjJRjyuHZASCUHH4KJxDmmUNkOGcKbUp8K9PAJZ0tjQt2fqf6Rwj38BaS38vHaKujNcSlviS6irJO 67ZShRtUDLTaTHej8tJ9HaP7J+VoF45AiPd6L3xWe3pJFKE+bxc8cQbG1CF6E2VaRfFntka4AWXiP 4cwpui+HndECLYOY=; Received: from mail-lj1-f170.google.com ([209.85.208.170]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1p0j9x-00025i-EJ for openvpn-devel@lists.sourceforge.net; Thu, 01 Dec 2022 12:59:25 +0000 Received: by mail-lj1-f170.google.com with SMTP id d3so1801000ljl.1 for ; Thu, 01 Dec 2022 04:59:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=FRToeiPghRJx6v+DswQq2UfIamNXEY/LNR4JN9i6rBY=; b=Xrggkdg1jN9yNgpWwiKIHi9n21o0MblPhCSdd+NtGOWalVioz6arIiDnV4y8UyiUlD 9rFeaAAX3WjCTp6R/AgBoE621Mpa0C5OSc7WyhL6ZfC4Wz0nLXqJTRw/RlZI2Gg5HmQ6 Jsw/NdL1g5JeFKD7nrDvvCafuLto2+9a1t0XBqSmnWFSV+wrQdgkLbzPzTgMRgNdC+mk ak9ArasUyW48Rphuzf/TGPtqyWuH6fkWfsLjNVXqHJBC3Aa/PHj0Yt34oPUY375VD7Vl pV39jc7/r77nPaaRru9i7JTN5xUYvCDfv8dk/waPubVCNhFoSYuPnwwWEKK7VFQHw3jA +XEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=FRToeiPghRJx6v+DswQq2UfIamNXEY/LNR4JN9i6rBY=; b=NRSfqV4d4t/HaSoUYN4bijeXbc9R+Xj71qnu3Slae2xSFUqfqvqJHICgs7keewE7EM DBzfFhihy6xDUv6iAeXNEZuIiGuQVZAH7lRFMnIps3Axf8RVI3bh2VEgmuZ4s5IC/Utu ORJXpJ5UwIbAKaMVDhmMuHywqA/teiVh2K/RILc5vnPcnDN81VSGex2DzfJbM9zOxI2u QcZ9XGD5P2OeyQGqK2xvkPL2l7C1kcwOhvzdkYfWxowBROTHrsm0GZtUgtQSxw57S//E xP96CVDUuUEeI+llL58d2SjmBAW+A87BTaHdf8v/BsAmvXQX20OIx8aF3rDCK+3npHwV LetA== X-Gm-Message-State: ANoB5plrrQcmSIDoES7K6C7VCBTUBUjJDl4qvaADKubRqY9pYOb4lNGf WhYLDUbO6vFQIBTNMj4k5UaJL9PdsqI= X-Google-Smtp-Source: AA0mqf7LRGIx5hoVk3l8dZuVeIlCKtHH0nfMeZUy3rLusCTUCBShZGMtf7hiqWaxkvqutijhsECu2g== X-Received: by 2002:a05:651c:984:b0:277:295:982e with SMTP id b4-20020a05651c098400b002770295982emr16535899ljq.11.1669899558340; Thu, 01 Dec 2022 04:59:18 -0800 (PST) Received: from localhost.localdomain ([2a00:1d50:3:0:2d9f:c954:69c6:8c30]) by smtp.gmail.com with ESMTPSA id m8-20020a2e9108000000b0026dffa29989sm78217ljg.23.2022.12.01.04.59.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Dec 2022 04:59:17 -0800 (PST) From: Lev Stipakov To: openvpn-devel@lists.sourceforge.net Date: Thu, 1 Dec 2022 14:59:02 +0200 Message-Id: <20221201125902.400-1-lstipakov@gmail.com> X-Mailer: git-send-email 2.38.1.windows.1 MIME-Version: 1.0 X-Spam-Report: Spam detection software, running on the system "util-spamd-2.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Lev Stipakov At the moment Windows driver requires remote to work. Signed-off-by: Lev Stipakov --- src/openvpn/dco.c | 8 ++++++++ 1 file changed, 8 insertions(+) Content analysis details: (-0.2 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [lstipakov[at]gmail.com] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.208.170 listed in wl.mailspike.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.208.170 listed in list.dnswl.org] X-Headers-End: 1p0j9x-00025i-EJ Subject: [Openvpn-devel] [PATCH] dco: disable dco on Windows if --remote is not defined X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lev Stipakov Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox From: Lev Stipakov At the moment Windows driver requires remote to work. Signed-off-by: Lev Stipakov Acked-by: Gert Doering --- src/openvpn/dco.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/openvpn/dco.c b/src/openvpn/dco.c index 47fb0003..19a449ba 100644 --- a/src/openvpn/dco.c +++ b/src/openvpn/dco.c @@ -251,6 +251,14 @@ dco_check_option_ce(const struct connection_entry *ce, int msglevel) } #endif +#if defined(_WIN32) + if (!ce->remote) + { + msg(msglevel, "NOTE: --remote is not defined, disabling data channel offload."); + return false; + } +#endif + return true; }