From patchwork Thu Dec 15 19:01:41 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arne Schwabe X-Patchwork-Id: 2914 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7300:c95:b0:82:e4b3:40a0 with SMTP id p21csp631570dyk; Thu, 15 Dec 2022 11:02:15 -0800 (PST) X-Google-Smtp-Source: AA0mqf666YRfcQD4f4fm6dBpTRNGJeMezWj6Z/fw9w+p2uxXMRJW0CopJTxb4w4gQyxl3/pJ426o X-Received: by 2002:a05:6102:390a:b0:3af:3240:976b with SMTP id e10-20020a056102390a00b003af3240976bmr24248371vsu.7.1671130935381; Thu, 15 Dec 2022 11:02:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671130935; cv=none; d=google.com; s=arc-20160816; b=q2Bpp6jp0BXoo3xVfvW4rSrpz8flG1mqNLfSR8kKRpPcHq+qa9g9R+6kdv7wN97rVu 2GFi920SOixfSTREHzndjJozD9svyRlew9uWAku64o9mVS3g3RxWtUaqcXcu8MsLYKSS bfAuxj9lch13O/TvDZXbxYMd63AZnmXP2iGV0upIEZxwTPQA1Wm0PHMU+u5PPLOAvZhJ hEbE2HmHKLjAH1DztI04hmL/AZFHojl46+NV6FQJ9sxBnU/WYvYskhXAz5bJW3EKnhic AZTLjpnZltBzusiYEp2x3aAwxRaBLojPp6ty5Q6zwwJlGgIneMePE1pYLESkU5qoATlS 4H7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature; bh=/33Zc3v/30KJVIwK48cide88YgUvgqU/L13eLKI0XhQ=; b=oDWtN1QbiiVbV3U/uLkJ/PNfZLOhe7ik4bXhCDFBkxEJ9VZ0NcY9rztuXtQIRSLNHf +ZhzUVqt+7zVIHP4rOnW47bKPnHYLMv5/kLDa2rmTXiJvczoeHbvYFuPT3aSdKmJF2OD gcbhouvA9P3JtqDizu2S1E5Bwxg1UMS8qkqSV41jMUSxyNsCZxf+wlQRaijf7nJPLptK cfB7MSlhSNpwws1bYf2siovNw8aIsTNYOUyg0/ZYwnZ3uA1oTok9EhzZ6BrXt9cppk0F uYxWffDxECCPLWkNbJGIbD86QULtPKEnQhvpCp92r2RT5d/Civo5Ck5ZoqKcZSE383it wEEg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=imLVIzxp; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=ZjyTurDF; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id b10-20020a67b20a000000b003b3576a2435si1906582vsf.772.2022.12.15.11.02.15 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 15 Dec 2022 11:02:15 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=imLVIzxp; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=ZjyTurDF; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1p5tUS-0001x7-Sy; Thu, 15 Dec 2022 19:01:56 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1p5tUP-0001wj-UE for openvpn-devel@lists.sourceforge.net; Thu, 15 Dec 2022 19:01:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=SNWBrmc6UEoQbPnl8r7iByQwbdUlk1zrLTvGT9IpYXM=; b=imLVIzxpJnbl9EMCW5gk0fFU2N FAUxvOzTJ66ulYI7ILZ+jbk59elbXXc9tA2GCjoVsGtWl9YKv2Q7gdIBor8RQGwShbyhcRsPxO49z 8BAi62YrnCoiYwpH7ovbMT3AoJf2yYVs6uUcoqvBsC20AZAUUyxiljQac2E2Lou4AwCk=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-Id: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=SNWBrmc6UEoQbPnl8r7iByQwbdUlk1zrLTvGT9IpYXM=; b=ZjyTurDFbPLTj+S+V64iEagE6I tbNlhE2h+ZihQIKrG6BNL38ghOlXPzfup1hlZLD+a2AadzB3+rjH9K/n2kr0JWvzdF8haOwqOW/8t FEuncNpqL3c/JPNpCv4bVD36DCvgs7/ARmgqRN569089mOUa0hDiq98mODY1xCGOTL3U=; Received: from mail.blinkt.de ([192.26.174.232]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1p5tUN-0001Gk-Ij for openvpn-devel@lists.sourceforge.net; Thu, 15 Dec 2022 19:01:53 +0000 Received: from kamera.blinkt.de ([2001:638:502:390:20c:29ff:fec8:535c]) by mail.blinkt.de with smtp (Exim 4.95 (FreeBSD)) (envelope-from ) id 1p5tUF-000Kw6-Ca for openvpn-devel@lists.sourceforge.net; Thu, 15 Dec 2022 20:01:43 +0100 Received: (nullmailer pid 2107959 invoked by uid 10006); Thu, 15 Dec 2022 19:01:43 -0000 From: Arne Schwabe To: openvpn-devel@lists.sourceforge.net Date: Thu, 15 Dec 2022 20:01:41 +0100 Message-Id: <20221215190143.2107896-7-arne@rfc2549.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221215190143.2107896-1-arne@rfc2549.org> References: <20221215190143.2107896-1-arne@rfc2549.org> MIME-Version: 1.0 X-Spam-Score: 0.3 (/) X-Spam-Report: Spam detection software, running on the system "util-spamd-2.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Reported-By: Trail of Bits Signed-off-by: Arne Schwabe --- src/openvpn/forward.c | 3 --- src/openvpn/multi.c | 2 -- 2 files changed, 5 deletions(-) diff --git a/src/openvpn/forward.c b/src/openvpn/forward.c index 7924fd5c6..c04511ee1 100644 --- a/src/openvpn/forward.c +++ b/src/openvpn/forward.c @@ -1869,8 +1869,6 @@ process_outgoing_link(struct [...] Content analysis details: (0.3 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 SPF_NONE SPF: sender does not publish an SPF Record X-Headers-End: 1p5tUN-0001Gk-Ij Subject: [Openvpn-devel] [PATCH 6/8] Remove unused gc_arena X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1752307791616957270?= X-GMAIL-MSGID: =?utf-8?q?1752307791616957270?= Reported-By: Trail of Bits Signed-off-by: Arne Schwabe Acked-by: Gert Doering --- src/openvpn/forward.c | 3 --- src/openvpn/multi.c | 2 -- 2 files changed, 5 deletions(-) diff --git a/src/openvpn/forward.c b/src/openvpn/forward.c index 7924fd5c6..c04511ee1 100644 --- a/src/openvpn/forward.c +++ b/src/openvpn/forward.c @@ -1869,8 +1869,6 @@ process_outgoing_link(struct context *c) void process_outgoing_tun(struct context *c) { - struct gc_arena gc = gc_new(); - /* * Set up for write() call to TUN/TAP * device. @@ -1956,7 +1954,6 @@ process_outgoing_tun(struct context *c) buf_reset(&c->c2.to_tun); perf_pop(); - gc_free(&gc); } void diff --git a/src/openvpn/multi.c b/src/openvpn/multi.c index 870e3fa61..fcb308151 100644 --- a/src/openvpn/multi.c +++ b/src/openvpn/multi.c @@ -3497,7 +3497,6 @@ multi_process_incoming_link(struct multi_context *m, struct multi_instance *inst bool multi_process_incoming_tun(struct multi_context *m, const unsigned int mpp_flags) { - struct gc_arena gc = gc_new(); bool ret = true; if (BLEN(&m->top.c2.buf) > 0) @@ -3583,7 +3582,6 @@ multi_process_incoming_tun(struct multi_context *m, const unsigned int mpp_flags } } } - gc_free(&gc); return ret; }