From patchwork Sat Dec 24 19:42:50 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arne Schwabe X-Patchwork-Id: 2940 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7300:c95:b0:82:e4b3:40a0 with SMTP id p21csp1133859dyk; Sat, 24 Dec 2022 11:43:56 -0800 (PST) X-Google-Smtp-Source: AMrXdXtV3zMA5nLHe3BdIom6MtX090sWY16Ll6Xp08Qp6pZdyMs5Y+lJU/YAW6bqUUCE30abmaey X-Received: by 2002:a17:90a:d0c5:b0:219:ba3d:7ee2 with SMTP id y5-20020a17090ad0c500b00219ba3d7ee2mr16859765pjw.30.1671911036607; Sat, 24 Dec 2022 11:43:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671911036; cv=none; d=google.com; s=arc-20160816; b=aI165jq6mhyLAgdG6Fd6ptxf5vUp16CwuP61VosiethAc4mHVpHAjAENjNksZzcdD7 tSHIAqdCQl3m8s6OPO9KQdoBFxXBdKtJpcGSz5NU/LdB3xYN4f5o4j8+BYi+l+pWgaNB OPbFUbmXMwojybdkBlmtJVePxnnkzZCeanMn1RpmUk9dCh0yn1CYiFGp6zY61IMVEqxR ztLPOLlyQqX08ZB1/Q7U9zTIFg6kXOlwj3nQLPTHtB38UjhOHqr2lAX+UPQRaztg9FgW oTNYz2Yxl32Fvp7tOhY4M2FF2ccj92VBNSMtffDAjUv9PDJWIUkBuIgYO+6wy/Cik+EU UtTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature; bh=rnt4cS0VX4757M/SBNd8vqLNHKK0Xnzo63qxq6sjarA=; b=gfzKCz5OtWdUzecek+pVAVzJBJl1gJwgwLlcZ1jNuFBgavBGL1gblNqXz3pSAChACL 1r04SDmx4Jp0bJrumFCIKDClH7JpDl3CoA+5kBMM3F7ozE7NPcViXRqz5ywpMg8XWDp3 37UZMv+Cfpf5oPlw1KH6BQGnYiMSTzTJIweeluBWl3uqozjSL5GmnP4jZ/wU6IHTzszV R5pCFfVNF8rN1Opic/TUea/+3gZV+7ICgG30fNN+t+vtF0XbfmJ+F84EWz50STf2f0gC NRhGyLw6+lP54206iehJae6b3pUog0S091AU+kAH1zLKo4UC2/2iHAMdmt3Yctmuu+p/ 7sIA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=Dpny4hjK; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b="JYP71h6/"; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id oc8-20020a17090b1c0800b00202c850b5a8si12177024pjb.11.2022.12.24.11.43.56 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 24 Dec 2022 11:43:56 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=Dpny4hjK; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b="JYP71h6/"; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1p9AQL-0005qQ-Pp; Sat, 24 Dec 2022 19:43:13 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1p9AQF-0005q3-8n for openvpn-devel@lists.sourceforge.net; Sat, 24 Dec 2022 19:43:07 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=79C34HfRB9kYctsqIuIIiKwBq1k/q73i5AvQWs32PJo=; b=Dpny4hjKxIDiIYT3FDTaYKvATA lHDCqnD51K9kl4hcfSZy4L3d4GCuZWPD7gCyt56wjTSYcjmb55kLokmSLTwkBe6IMiJe79uSwJi1m KR/KwrRPGSGJBJ2QoWdttClMElumZIMBadyv+0HNLwz2kdQGfjouBLZKviyZQq6bhmeU=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-Id: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=79C34HfRB9kYctsqIuIIiKwBq1k/q73i5AvQWs32PJo=; b=JYP71h6/imNVFN44pdm+7Utmgr 3hnXjR3tW1Lg1blBwnx6l1PgMvtRXjFzfQhNwbdmP45/9RhcIQ1CR92OiKt5Z16nnFkM1s9I9SDY5 +1a1XhFVteocZ3yd7e8SJ0jQ2xiJ7JWUTkvRBgWZunFtrUq3X+lsVlCJIXt7XR4PdUb0=; Received: from mail.blinkt.de ([192.26.174.232]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1p9AQE-00BPfM-E7 for openvpn-devel@lists.sourceforge.net; Sat, 24 Dec 2022 19:43:07 +0000 Received: from kamera.blinkt.de ([2001:638:502:390:20c:29ff:fec8:535c]) by mail.blinkt.de with smtp (Exim 4.95 (FreeBSD)) (envelope-from ) id 1p9AQ1-000H1f-Nv for openvpn-devel@lists.sourceforge.net; Sat, 24 Dec 2022 20:42:53 +0100 Received: (nullmailer pid 3202293 invoked by uid 10006); Sat, 24 Dec 2022 19:42:53 -0000 From: Arne Schwabe To: openvpn-devel@lists.sourceforge.net Date: Sat, 24 Dec 2022 20:42:50 +0100 Message-Id: <20221224194253.3202231-7-arne@rfc2549.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221224194253.3202231-1-arne@rfc2549.org> References: <20221224194253.3202231-1-arne@rfc2549.org> MIME-Version: 1.0 X-Spam-Score: 0.3 (/) X-Spam-Report: Spam detection software, running on the system "util-spamd-2.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: libnl increases the sizes we pass to 8192 anyway. Currently when we have a lot of events queued we might run into a NLE_NOMEM message and that terminates the server. So rather let the kernel decide th [...] Content analysis details: (0.3 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 SPF_NONE SPF: sender does not publish an SPF Record X-Headers-End: 1p9AQE-00BPfM-E7 Subject: [Openvpn-devel] [PATCH 6/9] Do not set nl socket buffer size X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1753125787145435801?= X-GMAIL-MSGID: =?utf-8?q?1753125787145435801?= libnl increases the sizes we pass to 8192 anyway. Currently when we have a lot of events queued we might run into a NLE_NOMEM message and that terminates the server. So rather let the kernel decide the buffer sizes. Signed-off-by: Arne Schwabe Acked-by: Gert Doering --- src/openvpn/dco_linux.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/openvpn/dco_linux.c b/src/openvpn/dco_linux.c index 222537fc1..d4bca555d 100644 --- a/src/openvpn/dco_linux.c +++ b/src/openvpn/dco_linux.c @@ -348,9 +348,6 @@ ovpn_dco_init_netlink(dco_context_t *dco) msg(M_ERR, "Cannot create netlink socket"); } - /* TODO: Why are we setting this buffer size? */ - nl_socket_set_buffer_size(dco->nl_sock, 8192, 8192); - int ret = genl_connect(dco->nl_sock); if (ret) {