From patchwork Sat Dec 24 19:42:52 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arne Schwabe X-Patchwork-Id: 2937 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7300:c95:b0:82:e4b3:40a0 with SMTP id p21csp1133667dyk; Sat, 24 Dec 2022 11:43:29 -0800 (PST) X-Google-Smtp-Source: AMrXdXssYMMegX4P3KtUg03Pjd58r9VhMy2C+dBowdp7xItcqh3sxBHaLyFHIiE+xDURwRbtkJOE X-Received: by 2002:a05:6a20:c709:b0:9d:efbe:2078 with SMTP id hi9-20020a056a20c70900b0009defbe2078mr18244497pzb.46.1671911009046; Sat, 24 Dec 2022 11:43:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671911009; cv=none; d=google.com; s=arc-20160816; b=Vi8+vA6/3wzGJDlvdqtPYaJMMtiWGix7XVKdi8lPv7z0srE2mhGWgk0elUUSimJ9jV s4GPQVonT+XVA7xqDIfcn3rRKhWVzWNSAk4+Tjh3siSOwzCoOPQZkER6mwQL44ECmb8i N3MolWjkNA1e1WgISIoSbMKKMih0Ha8R4H75dBp7McEeZHLYLmkESb/xk9iD1uL4mWZB ntGvk81O15fWm8rBHf88QLrf4NvQMa28tpPg8TW91ehSLWBZjqXAGAh1U9DO61FiVmTL i6ynq1bfyNuXNjQKl5svuFWhdJ+f0jr/VK1Y76rV4AfCwbJg+OyTDhatpHwgOq91FKrf WxEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature; bh=5iHa4H0tF4LLrtb1g9QMQRFyRBkNYC8n0ogFZsXSIuA=; b=J3mSfOaYAcNjQKv6BYuVXGcBUR1swue9wNTJq7qpQc/tT26CwHSpreIUC2Ebqza3ty hJCFLWicEgsR/nuUKR+wqnq1zj/TeDVEQ4hkFECaUbxY4MEvoZS+ZS3xRbXk/qHlpKoL 6ihva5kSBnSsqc4vMnTbDj9qFnTLtgnHtI7fui4XD+clao05hXUOT3pJQ7SzR54Xx/Df a3tR8gKvrO+qfSraz3gJE4txlT6CxQ9iyKiRDoBBngpc5kBsPxeN9JSXioh6Nk2n9vqR pe5UodHfrOaUNFZVTnafzccgVqTS32LyVkl+VsLmUjvwafdGkBtAgbkL7fFUolh0z4sw mUAQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=hhmqgmlR; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=gEZ4Edn6; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 19-20020a631753000000b00477c3c222b6si7214396pgx.685.2022.12.24.11.43.28 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 24 Dec 2022 11:43:29 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=hhmqgmlR; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=gEZ4Edn6; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1p9AQL-0005qH-FN; Sat, 24 Dec 2022 19:43:13 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1p9AQE-0005pv-Sa for openvpn-devel@lists.sourceforge.net; Sat, 24 Dec 2022 19:43:06 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=pUDsrAmcV5xakq+J2MemNl23qXgfOAlJU36SH4tlSg4=; b=hhmqgmlRHCE766SNTIfi7GhO4n vcwTVlJoCLfF2y1XyIpxj/bNjNUQBAczqNzjjJvaGQDob3ao+V43ZH35qaqvXL0ZHE1Jegxv9iLor vmlAg876SNG5WeNwflmVKHzHNGyzzTKuN+CoUKkqc6K+zTr9pMDfaEVAK0x9M0pSoY2I=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-Id: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=pUDsrAmcV5xakq+J2MemNl23qXgfOAlJU36SH4tlSg4=; b=gEZ4Edn6OO3F8ErJN9eO7J4jIH B741oZpSQae1A/srElZbScEsdHu2zW7At8g3hFL+7VFLu8IOt7mXvIoZj0dLN8rGhNMn0miqU7XQF +AH018FBBT+CTnkDCaRnlcqZd/JMnaCtep+lC4UYQhJmK7wlg2+xGThANfnlUAamt+sc=; Received: from mail.blinkt.de ([192.26.174.232]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1p9AQE-00BPfP-E2 for openvpn-devel@lists.sourceforge.net; Sat, 24 Dec 2022 19:43:06 +0000 Received: from kamera.blinkt.de ([2001:638:502:390:20c:29ff:fec8:535c]) by mail.blinkt.de with smtp (Exim 4.95 (FreeBSD)) (envelope-from ) id 1p9AQ1-000H1l-QQ for openvpn-devel@lists.sourceforge.net; Sat, 24 Dec 2022 20:42:53 +0100 Received: (nullmailer pid 3202299 invoked by uid 10006); Sat, 24 Dec 2022 19:42:53 -0000 From: Arne Schwabe To: openvpn-devel@lists.sourceforge.net Date: Sat, 24 Dec 2022 20:42:52 +0100 Message-Id: <20221224194253.3202231-9-arne@rfc2549.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221224194253.3202231-1-arne@rfc2549.org> References: <20221224194253.3202231-1-arne@rfc2549.org> MIME-Version: 1.0 X-Spam-Score: 0.3 (/) X-Spam-Report: Spam detection software, running on the system "util-spamd-2.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Signed-off-by: Arne Schwabe --- src/openvpn/multi.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/src/openvpn/multi.c b/src/openvpn/multi.c index d29b7efe3..6c6385c6e 100644 --- a/src/openvpn/multi.c +++ b/src/openvpn/multi.c @@ -3283,7 +3283,17 @@ multi_process_incoming_dco(struct mu [...] Content analysis details: (0.3 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 SPF_NONE SPF: sender does not publish an SPF Record X-Headers-End: 1p9AQE-00BPfP-E2 Subject: [Openvpn-devel] [PATCH 8/9] Improve logging when seeing a message for an unkown peer X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1753125758385162691?= X-GMAIL-MSGID: =?utf-8?q?1753125758385162691?= Signed-off-by: Arne Schwabe Acked-by: Gert Doering --- src/openvpn/multi.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/src/openvpn/multi.c b/src/openvpn/multi.c index d29b7efe3..6c6385c6e 100644 --- a/src/openvpn/multi.c +++ b/src/openvpn/multi.c @@ -3283,7 +3283,17 @@ multi_process_incoming_dco(struct multi_context *m) } else { - msg(D_DCO, "Received packet for peer-id unknown to OpenVPN: %d", peer_id); + int msglevel = D_DCO; + if (dco->dco_message_type == OVPN_CMD_DEL_PEER + && dco->dco_del_peer_reason == OVPN_DEL_PEER_REASON_USERSPACE) + { + /* we get notified after we kill the peer ourselves and probably + * have already forgotten about it. This is expected */ + msglevel = D_DCO_DEBUG; + } + msg(msglevel, "Received packet for peer-id unknown to OpenVPN: %d, " + "type %d, reason %d", peer_id, dco->dco_message_type, + dco->dco_del_peer_reason); /* Also clear the buffer if this was incoming packet for a dropped peer */ buf_init(&dco->dco_packet_in, 0); }