From patchwork Tue Jan 3 20:23:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Antonio Quartulli X-Patchwork-Id: 2970 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7300:c95:b0:82:e4b3:40a0 with SMTP id p21csp7196804dyk; Tue, 3 Jan 2023 12:23:56 -0800 (PST) X-Google-Smtp-Source: AMrXdXvCzFhp3BNJsoimM5Hsa3K0IbU1f/GG88Pco1ZOfUUw582a11OZX/CsyADgc7qtWDfbORA3 X-Received: by 2002:a05:6a21:e313:b0:af:9538:ec5f with SMTP id cb19-20020a056a21e31300b000af9538ec5fmr56242053pzc.38.1672777435913; Tue, 03 Jan 2023 12:23:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672777435; cv=none; d=google.com; s=arc-20160816; b=m/PKf0dOqdjy/h4k0TIgThix34ubd6n6nOtREdvlnAqTD1g6iaOqLhlJ/Ke3b0UIT0 qtn5b85kkviJFG3JECYe9DpxhMJ5LztrGifp/eyoWsFsc46SG5wRoj7h6qzC+GZQWqsJ GVEYIUjgsncwp4bkAKZNlEBlBVHB1pNkGKZ39eMwDj1Lf/OY8n7Ip1WExqRiYLL2rDOB 3NgdBR9wnMJlPGeiX3qOp/sk0wcDv4bKRzQU1vpNKpGCPf064bGgnMIsZRNGHL8h6mUe G5RbOxzHMYWkSalwR/bTSHAHZgm2BcKnlwYbEyZpOcr/SM1v1gfZdtk0r//0jsjG/aBY B7og== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:content-transfer-encoding:cc:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:message-id:date:to:from:dkim-signature:dkim-signature :dkim-signature; bh=3rwMEorGFB8YSiBllP7zWY9S75xD6gE6nTunI+YcTSY=; b=ldT4igDIUhYKEmv7jZsG/aYbYk+psWNuDP4PP3WPn3wyq9dc5g1UZb1JldN6sqj3K9 vktlaCay428kWnNri9ufB+9T3IIbiC/8Djq58cNnMfaOK9qGwsSeYB38fyv8Fw4lYoYg gYWBzDvQ3zAkgwlv9LW/lEF29PjPHtP+x4BqMPyTI4v5H5P0a2BZHBqTDNPo7VK9ihxx LIxkxszf/uFxeeXVd7+uiki9pWfKCT1jsFQSGsoX/1Keo0P9WXBrNXY5SyfVDy4w4ENo Y10KCIGaU66yBfhgNZrg9nfv6KHg+gkqRwW22ImBtDRPHDDKNK+fonnHFvYaiv8nVASX zKzg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=OtS8k4Hc; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=FYzP4T1z; dkim=fail header.i=@unstable.cc header.s=20220809-q8oc header.b=cpAztnM1; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id q5-20020a654945000000b0048be2e2a01esi34392831pgs.174.2023.01.03.12.23.55 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 03 Jan 2023 12:23:55 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=OtS8k4Hc; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=FYzP4T1z; dkim=fail header.i=@unstable.cc header.s=20220809-q8oc header.b=cpAztnM1; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1pCnor-00034c-88; Tue, 03 Jan 2023 20:23:33 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pCnoq-00034S-13 for openvpn-devel@lists.sourceforge.net; Tue, 03 Jan 2023 20:23:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:Message-Id: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=co5qKncLDveICc3LfQKGDSejE1ekRMPwPzeL9YDRM6Y=; b=OtS8k4Hc7u8je2wC9vRL92DAJN 81Jnw1hZpqFwZ6pRle4UGEZh24DyZF8CVKZmKTvIP+ycYmldILr4hKguc0qFm5EytdLfCbdQoys3t ohq+ZIcTTHimUEavSV0kwHGahpQl26k93h8P9wuJxdMZqzmVryK1GmO85t2W5J2EWYxE=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject:Cc:To:From :Sender:Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=co5qKncLDveICc3LfQKGDSejE1ekRMPwPzeL9YDRM6Y=; b=F YzP4T1z74f9YajdU5wVzajxVLGFnMem5+PfzLlh9zTRycyBm12zfsPBpSKWODUrgmNnerIerQmyWy fV/+eXmruEUY8N9ahLcD4ww/fFRISRcCBfOOeZBASPQ+7Y8a3HE4yg8SJUtsRi0q9bJepHRhMk2Ni PotCxP47ANpVpbpM=; Received: from wilbur.contactoffice.com ([212.3.242.68]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1pCnoh-003hFf-7f for openvpn-devel@lists.sourceforge.net; Tue, 03 Jan 2023 20:23:31 +0000 Received: from smtpauth2.co-bxl (smtpauth2.co-bxl [10.2.0.24]) by wilbur.contactoffice.com (Postfix) with ESMTP id 13085A22; Tue, 3 Jan 2023 21:23:13 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1672777393; s=20220809-q8oc; d=unstable.cc; i=a@unstable.cc; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version:Content-Transfer-Encoding; l=767; bh=co5qKncLDveICc3LfQKGDSejE1ekRMPwPzeL9YDRM6Y=; b=cpAztnM1Y1rkbcGd8ozhcbi3TFkxXR2eXGnUC5BJNZy6eKtj4r0sLxw2ftziN5JA Cqc7aFGYl8TBoPsvH9YF0G+iI6YO3hBJEb9HKSfaqb2xT5fnZi03/IlVlYod6uddAFu PVt733FxalBSMVYnUvCIoOoTggOHKJVH7x43sVBo0Rv7pVyiLCtQAZwJv9AkoUA0rtk Al/u++KjGbmGKnOqvYvwEzFs7L7i0WR+Fdo5bMiBXm9CwbX66O7Jrba01ywExa8SAgj 6n98fnFd0WANB8LO86iEUTDEf5AVkgakdN4ugbe3g36fwZ3IyUys+byN1S7id2Cakxq zC67zdXppw== Received: by smtp.mailfence.com with ESMTPSA ; Tue, 3 Jan 2023 21:23:10 +0100 (CET) From: Antonio Quartulli To: openvpn-devel@lists.sourceforge.net Date: Tue, 3 Jan 2023 21:23:28 +0100 Message-Id: <20230103202330.1835-1-a@unstable.cc> X-Mailer: git-send-email 2.38.2 MIME-Version: 1.0 X-Spam-Flag: NO X-Spam-Status: No, hits=-2.9 required=4.7 symbols=ALL_TRUSTED, BAYES_00 device=10.2.0.1 X-ContactOffice-Account: com:375058688 X-Spam-Score: -0.9 (/) X-Spam-Report: Spam detection software, running on the system "util-spamd-2.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: After processing a message, all fields of the dco object should be re-initialized so that future processings are not affected by stale values. This includes dco_del_peer_reason. Since its values can start at 0, re-initialize it with -1. Content analysis details: (-0.9 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [212.3.242.68 listed in list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-Headers-End: 1pCnoh-003hFf-7f Subject: [Openvpn-devel] [PATCH 1/3] dco: properly re-initialize dco_del_peer_reason X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Antonio Quartulli Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1754034272810592963?= X-GMAIL-MSGID: =?utf-8?q?1754034272810592963?= After processing a message, all fields of the dco object should be re-initialized so that future processings are not affected by stale values. This includes dco_del_peer_reason. Since its values can start at 0, re-initialize it with -1. Signed-off-by: Antonio Quartulli Acked-By: Arne Schwabe --- src/openvpn/multi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/openvpn/multi.c b/src/openvpn/multi.c index 3658e1d5..27676de5 100644 --- a/src/openvpn/multi.c +++ b/src/openvpn/multi.c @@ -3301,6 +3301,7 @@ multi_process_incoming_dco(struct multi_context *m) dco->dco_message_type = 0; dco->dco_message_peer_id = -1; + dco->dco_del_peer_reason = -1; dco->dco_read_bytes = 0; dco->dco_write_bytes = 0; return ret > 0;