| Message ID | 20230130172936.3444840-4-arne@rfc2549.org |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [Openvpn-devel,1/5] Fix unaligned access in auth-token | expand |
On Mon, Jan 30, 2023 at 06:29:35PM +0100, Arne Schwabe wrote: > This allows identifying the source of undefined behaviour more easily > from the github action logs. > > Signed-off-by: Arne Schwabe <arne@rfc2549.org> > --- > .github/workflows/build.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml > index 6adb69563..132624547 100644 > --- a/.github/workflows/build.yaml > +++ b/.github/workflows/build.yaml > @@ -242,6 +242,9 @@ jobs: > > name: "clang-asan - ${{matrix.os}} - ${{matrix.ssllib}}" > > + env: > + UBSAN_OPTIONS: print_stacktrace=1 > + > runs-on: ${{matrix.os}} > steps: > - name: Install dependencies > @@ -291,6 +294,7 @@ jobs: > LDFLAGS: ${{ matrix.ldflags }} > OPENSSL_CFLAGS: "-I/usr/local/opt/${{matrix.libdir}}/include" > OPENSSL_LIBS: "-L/usr/local/opt/${{matrix.libdir}}/lib -lcrypto -lssl" > + UBSAN_OPTIONS: print_stacktrace=1 > steps: > - name: Install dependencies > run: brew install openssl@1.1 openssl@3 lzo lz4 man2html cmocka libtool automake autoconf libressl > @@ -400,6 +404,7 @@ jobs: > CFLAGS: ${{ matrix.cflags }} > LDFLAGS: ${{ matrix.ldflags }} > CC: ${{matrix.cc}} > + UBSAN_OPTIONS: print_stacktrace=1 > > steps: > - name: Install dependencies Acked-By: Frank Lichtenheld <frank@lichtenheld.com> Trivial enough. Regards,
I haven't tested it yet, but will have a close look at the GH test
runs after I push this - the route.c fix hasn't been merged yet
(want to stare more at it) so the MacOS/ASAN build should trigger
something now... non-fatal, but red :-)
Your patch has been applied to the master and release/2.6 branch.
commit 98f295004391194d4770a450fda79a30dbaf7d60 (master)
commit 0deb1afdba185de464d0c542f60de71712a34b80 (release/2.6)
Author: Arne Schwabe
Date: Mon Jan 30 18:29:35 2023 +0100
Add printing USAN stack trace on github actions
Signed-off-by: Arne Schwabe <arne@rfc2549.org>
Acked-by: Frank Lichtenheld <frank@lichtenheld.com>
Message-Id: <20230130172936.3444840-4-arne@rfc2549.org>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg26102.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>
--
kind regards,
Gert Doering
diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index 6adb69563..132624547 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -242,6 +242,9 @@ jobs: name: "clang-asan - ${{matrix.os}} - ${{matrix.ssllib}}" + env: + UBSAN_OPTIONS: print_stacktrace=1 + runs-on: ${{matrix.os}} steps: - name: Install dependencies @@ -291,6 +294,7 @@ jobs: LDFLAGS: ${{ matrix.ldflags }} OPENSSL_CFLAGS: "-I/usr/local/opt/${{matrix.libdir}}/include" OPENSSL_LIBS: "-L/usr/local/opt/${{matrix.libdir}}/lib -lcrypto -lssl" + UBSAN_OPTIONS: print_stacktrace=1 steps: - name: Install dependencies run: brew install openssl@1.1 openssl@3 lzo lz4 man2html cmocka libtool automake autoconf libressl @@ -400,6 +404,7 @@ jobs: CFLAGS: ${{ matrix.cflags }} LDFLAGS: ${{ matrix.ldflags }} CC: ${{matrix.cc}} + UBSAN_OPTIONS: print_stacktrace=1 steps: - name: Install dependencies
This allows identifying the source of undefined behaviour more easily from the github action logs. Signed-off-by: Arne Schwabe <arne@rfc2549.org> --- .github/workflows/build.yaml | 5 +++++ 1 file changed, 5 insertions(+)