From patchwork Wed Feb 1 13:52:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Lichtenheld X-Patchwork-Id: 3035 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7300:c95:b0:82:e4b3:40a0 with SMTP id p21csp434998dyk; Wed, 1 Feb 2023 05:53:36 -0800 (PST) X-Google-Smtp-Source: AK7set+R+n+DWE7+elujaLztas2dVCvljzx0t52vlmltonrzKrLF8Q/OodeOhpFkDsluWl8fQAVQ X-Received: by 2002:aa7:9911:0:b0:592:5dd5:7655 with SMTP id z17-20020aa79911000000b005925dd57655mr2054476pff.28.1675259616451; Wed, 01 Feb 2023 05:53:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675259616; cv=none; d=google.com; s=arc-20160816; b=gUi18yR03ePYjnx6m8fq5wFI/VVMJNDQ2yl+VEtg7sda5QBAmgGFtG+HiMmDuFDDQD PteIGbdD0xLK3U8HBovgeilDxRPsn+zkh/OPoZk//9ny936S9wZGdOh7k6xN6LuvWXAy dPxCyI++wdkqGpc8Vglzpt/8dbtdfM/8i3hlSjRy9AHvclUQNIOkkjQNfMbTmAY4/SQn dbjYMJmb1EN3uJX32NVuXuCTfyWlEvMY+TFNd5XY0FsxCefwP3PquAQEO6rFvAqT83pr TPGlTwfNSS4TeWUiA21d89HdG1V1P3ipsxI39X047mmO8RBUzmF8RdVDEDeEX/hy3DJM B0Ig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:message-id:date:to:from:dkim-signature:dkim-signature; bh=/J29yFn8hV85WRmu7+IBQsZS/Onc/NbpTmrDq23gDMM=; b=ZqiYPV1o2Nbxds46tPUTPHMlEyDdoTPKpWva4YHHeBxQLNB4mqnDvBYS1y54EU4abr nK8Mjq4r2u9ZUsQmW36J3qBNW7qURIMEbjL+zMNXbrJoc1jLG7z1R4WxtMK5EnhfXOdi 9HmL8jtCxVRWSghGModfUjbTQE7DUeY8d7OMk3tnASOIYI9qMSeIwKRoS7+6kyxRZ7SI vLyRdaBoPhSEAN/nBb1iFLHBOUz7/HHn99cC603pIlkOMtfzaGFwfmGFnYGl72dMvp5v UYtbN7iqRr7nql7pG63l2bXI0lNSK29yaCx5Kgxg+EbUUkqJz4E0weEan/0HDuql+tVy AIGw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b="EDmadM/C"; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=bJ9ZWl14; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id d1-20020aa78e41000000b00593dd54be42si6802418pfr.213.2023.02.01.05.53.36 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 01 Feb 2023 05:53:36 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b="EDmadM/C"; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=bJ9ZWl14; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1pNDXU-0007em-Kg; Wed, 01 Feb 2023 13:52:39 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pNDXS-0007ef-IF for openvpn-devel@lists.sourceforge.net; Wed, 01 Feb 2023 13:52:37 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:Message-Id: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=EBhfH/j0PMDjYuc8VBavwUGLarKger3l5LGaGODH2A0=; b=EDmadM/CcraqQ4+qPA4zjrBLbh msOqYziUx03PH/K7KZymeXFnn3/MDXQejTZqs3o2ITEvu82LP5uJAXHdKgAH933TjyayvNCZEWI2K lUS3i0C5V5p2TAC5VfCyTeCFXMolz+6xv4K5QTNyEqwf6/2pg1G0flDhhLX2ShaW290A=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject:To:From: Sender:Reply-To:Cc:Content-Type:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=EBhfH/j0PMDjYuc8VBavwUGLarKger3l5LGaGODH2A0=; b=b J9ZWl14Ws9FltU+pp4zXBSD4UdgalSNSRIMkGCU0N97G9hmrUPSkBk10ddS29na+sHFWKa4sFpOST zBqNcxGRMmJOkCHLXcXZ9qMS3itlGiznVVnI+SZuM20XnxrzA25uqjz+q8w7Rs6npzjeI3PxcGQ9c WY+hpAlk7QI40pMI=; Received: from mout-p-202.mailbox.org ([80.241.56.172]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1pNDXN-007Loe-KF for openvpn-devel@lists.sourceforge.net; Wed, 01 Feb 2023 13:52:37 +0000 Received: from smtp2.mailbox.org (smtp2.mailbox.org [IPv6:2001:67c:2050:b231:465::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-202.mailbox.org (Postfix) with ESMTPS id 4P6Ndf4dV5z9sb2 for ; Wed, 1 Feb 2023 14:52:22 +0100 (CET) From: Frank Lichtenheld To: openvpn-devel@lists.sourceforge.net Date: Wed, 1 Feb 2023 14:52:21 +0100 Message-Id: <20230201135221.36135-1-frank@lichtenheld.com> MIME-Version: 1.0 X-Rspamd-Queue-Id: 4P6Ndf4dV5z9sb2 X-Spam-Score: -0.7 (/) X-Spam-Report: Spam detection software, running on the system "util-spamd-1.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: When reviweing OpenVPN/openvpn#231 I noticed this was missing from Changes.rst. Signed-off-by: Frank Lichtenheld --- Changes.rst | 5 +++++ src/openvpn/options.c | 1 - 2 files changed, 5 insertions(+), 1 deletion(-) Content analysis details: (-0.7 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [80.241.56.172 listed in list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 SPF_NONE SPF: sender does not publish an SPF Record X-Headers-End: 1pNDXN-007Loe-KF Subject: [Openvpn-devel] [PATCH] Changes.rst: document removal of --keysize X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1756637027834481666?= X-GMAIL-MSGID: =?utf-8?q?1756637027834481666?= When reviweing OpenVPN/openvpn#231 I noticed this was missing from Changes.rst. Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering --- Changes.rst | 5 +++++ src/openvpn/options.c | 1 - 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/Changes.rst b/Changes.rst index 4942a580..dc829032 100644 --- a/Changes.rst +++ b/Changes.rst @@ -176,6 +176,11 @@ TLS 1.0 and 1.1 are deprecated a PRNG is better left to a crypto library. So we use the PRNG mbed TLS or OpenSSL now. +``--keysize`` has been removed + The ``--keysize`` option was only useful to change the key length when using the + BF, CAST6 or RC2 ciphers. For all other ciphers the key size is fixed with the + chosen cipher. As OpenVPN v2.6 no longer supports any of these variable length + ciphers, this option was removed as well to avoid confusion. Compression no longer enabled by default Unless an explicit compression option is specified in the configuration, diff --git a/src/openvpn/options.c b/src/openvpn/options.c index a5f6d244..34291edf 100644 --- a/src/openvpn/options.c +++ b/src/openvpn/options.c @@ -4176,7 +4176,6 @@ options_postprocess_pull(struct options *o, struct env_set *es) * * --cipher * --auth - * --keysize * --secret * --no-replay *