From patchwork Mon Feb 20 08:56:40 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lev Stipakov X-Patchwork-Id: 3088 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7300:c95:b0:82:e4b3:40a0 with SMTP id p21csp1570082dyk; Mon, 20 Feb 2023 00:57:35 -0800 (PST) X-Google-Smtp-Source: AK7set8QlUEFoJB6xij4par26BYybSBW2gDoB0Weux0ujwG7QfRxev+Ik2vdtmdDlhQlApmBj3C5 X-Received: by 2002:a17:902:e5d2:b0:19a:80b2:e94b with SMTP id u18-20020a170902e5d200b0019a80b2e94bmr2846649plf.33.1676883455202; Mon, 20 Feb 2023 00:57:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676883455; cv=none; d=google.com; s=arc-20160816; b=P51o1/Xx8HXS/Izi0RPF2uzJ1WbQQxPglDMzNCYEGdMm5zS1rwsrjPxwWNtSoiHfRA Glf5UiW41eJA8ByLKDNUaWQv4vSHi6yXXdrp5NhEYsAUnI+d7mtq6HL7LG75CCADHWlt 07uGdcpM1aOqIndb3yCGSLZ/X9CC3i+N8z1oV49/IfpXY03VfiFkA6n5aFts/ILujlMV VZ4QHgcrWFtWekLwOmsk8HWUEjlUIp0oMvnIeRHT213HFv60qKcfoDb+KzjHDpR8Ij7U F3y0siitTS6JqwkMy9eGvPKZD9fL8sLQb/K+Mg+Ou2JMzTJZDzcTdNIJ72Z5fXm331Tj /2Tw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:content-transfer-encoding:cc:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:message-id:date:to:from:dkim-signature:dkim-signature :dkim-signature; bh=H4WlTJeZidLty5JlFrq/uv5HSu3r2FrCTVuugxo3UIg=; b=U+9DbGN7B+7m4WOhUEW5lQcpwKaSYRXGwMyRJTg4Le07u6kdaRi3J6MoyJg/zBSUsj lZ8AXoS/ouFKtCBfUcFIuUjV1j+DomP5ujpdvhBPFDUtPcCssnznbzWy5gHh766DrftD Nvnu3m+zEQceTmTuqbpNx/vl/PETPDOlzbuozea7EGdDXZyPsKIto7WtN7A7n9HHwVc4 KkRuQp2sk/HmqGzMw0Oje2/bk0hrMFn1ZK88Qg7WNNGsSKeRSuSfqD34aY8z+Gkk15JU 3p+lTVNkxSwgS742x41D/QhEE7v/18XluOZLga8fXxjO+WG5Sz72VbtZW36AZOB7O7ya mh7w== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=jt8wEEQ4; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=kkSvc22S; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20210112 header.b=Lgwe6MdY; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id l1-20020a170903244100b001963669c7d4si1485510pls.532.2023.02.20.00.57.34 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 20 Feb 2023 00:57:35 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=jt8wEEQ4; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=kkSvc22S; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20210112 header.b=Lgwe6MdY; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1pU1yt-0003fg-Gj; Mon, 20 Feb 2023 08:57:07 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pU1ys-0003fa-Nh for openvpn-devel@lists.sourceforge.net; Mon, 20 Feb 2023 08:57:06 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:Message-Id: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=5ECFZV9KbMgoZGywKmN85ly9RQ6ecIwqg7t2Cz4lLVE=; b=jt8wEEQ4sWCU93KC4zsQLasmWB nsySXCvpmBApHXnAoSBjxgA39jd6TGQzqEIBgFF3qDvJ5qQ8znW6iR9ejV9mBYbXpkWei3l/KnsRc xvzdZlbw0eaO9xkaBh7lsOOmpHJxJN4p0vcWgv+L4MgyK3jsYPxAjckkXejFya8d5C2E=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject:Cc:To:From :Sender:Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=5ECFZV9KbMgoZGywKmN85ly9RQ6ecIwqg7t2Cz4lLVE=; b=k kSvc22S5BR3bc3AoQklkp528e8h33Xb1iVEDO6aWlLhykHmiFJD4dCRRqlq0MlHFmo2dHmuSRCG+T sYPSpexRquJxFYuujwI5Q+z3aG55FtUCUXYU2+2qt+vhVgeN/T34PxiLgGRKjhFoFQ+X4YOBCKtit 9UjBy7fm0oUN9n+s=; Received: from mail-lj1-f178.google.com ([209.85.208.178]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1pU1yo-00AzW2-KY for openvpn-devel@lists.sourceforge.net; Mon, 20 Feb 2023 08:57:06 +0000 Received: by mail-lj1-f178.google.com with SMTP id f16so340411ljq.10 for ; Mon, 20 Feb 2023 00:57:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=5ECFZV9KbMgoZGywKmN85ly9RQ6ecIwqg7t2Cz4lLVE=; b=Lgwe6MdYstjU++gFtc43jsxeqZ702kbgSrKaMlcHIpot2ElgrcAq56K6lXOrjV27PL 4sTW3n7gGT+I4WbZWhH7oQBY9bafM1lqTQTyADu0lN2gRW1yLJ9N8JqzrGHrqhEzOVRX BCeIG64r10za8aJ6pvNsWx9wvbqyESuusHO7glZgf4h0w5oV72ud3fQa7D++GvBKOj3/ gmufDWRaBGB49D97VBVXitlJrIVCF8765+wRY1H9OmmuwF7TluKXq1uc4l2zDCbCQjUA kbr4gj4WhLegS+eutNLZaqudfhhAVY4A0XEwRT4TJ3pT5U9DIcuLuY1KJ3KedcfuuY+W 7vSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5ECFZV9KbMgoZGywKmN85ly9RQ6ecIwqg7t2Cz4lLVE=; b=jVgLnJ+0HzUbRri6FZZp2o9hxrLSFf6GXZw8YawvPulQXm8j1//OxmwEXgt8ZI8N4m dEZ9oH+0N1IXNuCSGlBcBWChZTvM+CR2JIajAI8hVCqxSqmgxayTe8niapaXhHm7WLNE O/rZYe+Al6KvG5rfdhlX5r2oBfPQu7TAPA66rQ94CFzh/a57wpS8eYC2t0dgQlktFqMr S/kWLzfUmYPE0ABoT1g0G7E/s0l/3w67VAABLzAtKj2tBrPvHwQqliCkd84SzSM9swLd vCHS/fh5boPqus0rPC3DvuoHfkOp7WpR9V6XA2LcOIBVD9KH6g8P2J03GITBlTYn0s4+ dwIA== X-Gm-Message-State: AO0yUKX9fSQPcEt57pFcD7pS1Ra7sx3HaNCkqBIS2yyLXCiUoqig2hAl sa9lXgkjl/IrLmO+j1ZeAU+I6cW/bRo= X-Received: by 2002:a05:651c:31a:b0:292:b368:345d with SMTP id a26-20020a05651c031a00b00292b368345dmr539695ljp.48.1676883415579; Mon, 20 Feb 2023 00:56:55 -0800 (PST) Received: from localhost.localdomain ([2a00:1d50:3:0:e51e:b4b4:af07:6244]) by smtp.gmail.com with ESMTPSA id d28-20020ac244dc000000b004dc6070e121sm100528lfm.83.2023.02.20.00.56.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Feb 2023 00:56:55 -0800 (PST) From: Lev Stipakov To: openvpn-devel@lists.sourceforge.net Date: Mon, 20 Feb 2023 10:56:40 +0200 Message-Id: <20230220085640.1519-1-lstipakov@gmail.com> X-Mailer: git-send-email 2.38.1.windows.1 MIME-Version: 1.0 X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "util-spamd-1.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Lev Stipakov DCO doesn't support proxy and we already disable DCO is proxy is set in profile. Signed-off-by: Lev Stipakov --- src/openvpn/init.c | 6 ++++++ 1 file changed, 6 insertions(+) Content analysis details: (-0.2 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.208.178 listed in wl.mailspike.net] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [lstipakov[at]gmail.com] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.208.178 listed in list.dnswl.org] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-Headers-End: 1pU1yo-00AzW2-KY Subject: [Openvpn-devel] [PATCH] Disabe DCO if proxy is set via management X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lev Stipakov Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1758339745826952585?= X-GMAIL-MSGID: =?utf-8?q?1758339745826952585?= From: Lev Stipakov DCO doesn't support proxy and we already disable DCO is proxy is set in profile. Signed-off-by: Lev Stipakov --- src/openvpn/init.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/openvpn/init.c b/src/openvpn/init.c index b500d354..7c428307 100644 --- a/src/openvpn/init.c +++ b/src/openvpn/init.c @@ -223,6 +223,12 @@ management_callback_proxy_cmd(void *arg, const char **p) } else if (p[2] && p[3]) { + if (!c->options.tuntap_options.disable_dco) + { + msg(M_INFO, "Proxy set via management, disabling Data Channel Offload."); + c->options.tuntap_options.disable_dco = true; + } + if (streq(p[1], "HTTP")) { struct http_proxy_options *ho;