From patchwork Wed Mar 22 15:15:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Selva Nair X-Patchwork-Id: 3151 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7300:2310:b0:9f:bfa4:120f with SMTP id r16csp3282835dye; Wed, 22 Mar 2023 08:16:33 -0700 (PDT) X-Google-Smtp-Source: AK7set//x6fhxHfvBojnVa3DeHCJYkhxw5GgOL/7SJ9RQsK776TcjwBUpngVJH+ia0i1ZBfHYQ/q X-Received: by 2002:a05:6a20:7a99:b0:d9:63c3:e298 with SMTP id u25-20020a056a207a9900b000d963c3e298mr7508pzh.10.1679498193305; Wed, 22 Mar 2023 08:16:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679498193; cv=none; d=google.com; s=arc-20160816; b=QJqjgPmm0AxkiD3i2egEzgej/YdSBJxvBm+CCWGrHG41MZcDX3/GP4WP+Rou/2KkDm Q2jLWpx7L+yxIFu3P2QAc1k7eLJA5MgSG5g6Vq6ey1T7dmYNsiIQcZheWREz8PpoDArT xw4voBtilvS/LFZwiwZm3AKkc8qjgnGCrBlVpVNkz7vOBuZ2EryFjN4WvhH9mPriQSmE IcbTRuZUGYINln+f3Mu8vj5Sr7hhxnDVgiYQEimyfZ5h1HI7lyG6uyFJOYIoQHDfPDqV T11UEHHBDbWfoF7Eg1bjT45L7rvkCZE75jQjxhUri/7fNbBLTV/+3P5tepRq+frtepjY t9Pg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:message-id:date:to:from:dkim-signature:dkim-signature :dkim-signature; bh=1avIM0FbDt0sJ0qseOANeU4b3Q86yy1AMw/8Zhg7My0=; b=ILYZ/WULyOre1+IiVlj6unWzWKtiGNw7HrfjJjQnqbfRvJph5S/hO3NvKsTXJVc2mQ YIEJvXfEvGzV7CpxITprwOyWb0oqDTXv6NeNe312Qn6xWi05YNmkRdYqkbwTkZrkNlsw +xBYvS1tmQKeqidUztzuKR1zVjAZDe2arTN+9l87v8FboJSfXuaNZFyN2RTiZT5GaSHe r2Bj7bGC6DG8XYb5+6PuTYc2EtqJ2Z/RSj6UZYbhs5oWTDgF3BS8QH21AO9egd7Chf5g Jkoli/aHCsZ6S8YTqUsLHPsJjw9XxyjP35Nik+14s/SoW11K6TjKNTbXlpnMuVKMwqHp Mw7w== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=U+VlQeuy; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=Emv6cwnt; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20210112 header.b="Kgyr/lBE"; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from lists.sourceforge.net ([216.105.38.7]) by mx.google.com with ESMTPS id c28-20020a634e1c000000b005032da21acasi15700513pgb.204.2023.03.22.08.16.32 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 22 Mar 2023 08:16:33 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=U+VlQeuy; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=Emv6cwnt; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20210112 header.b="Kgyr/lBE"; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1pf0C4-000458-Ie; Wed, 22 Mar 2023 15:16:05 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pf0C3-00044y-CE for openvpn-devel@lists.sourceforge.net; Wed, 22 Mar 2023 15:16:03 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:Message-Id: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=wK1VjbQW4wiWs9MbJ33pKwAMV2Hl8NM2xzjzcJ6v/uY=; b=U+VlQeuyOkdwyqADDhkUY7Jqcr okYpUyfg0PmewpjMh9YW9+LlvweYLZsQ/lMB5lDUDTRV66FCwJ93Lk/SB11+VC8A21GVCW8MP/tKo fe/tnf51Hd/4ya5oWGZCsgEFO2mhufMmmLXLS+IW386SdTKc5nLZEtd7VmnW02jLvQt8=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject:Cc:To:From :Sender:Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=wK1VjbQW4wiWs9MbJ33pKwAMV2Hl8NM2xzjzcJ6v/uY=; b=E mv6cwntPbrapJICeZNLCwcngGLBgIFGH37+XWkUx30QF8MV3xOYVYjxJ1SRxqsJ3iIBrOLLYPBxhb uWp/a7aVPlzf69jjknFb1tH6mIBTozRezC2GIig7EotaCO+/7k6eXh4jLt09rqXlpQEUyWS/7kP9G AUDTDTF4zT3iR9cw=; Received: from mail-io1-f44.google.com ([209.85.166.44]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1pf0C1-00Gh47-Vf for openvpn-devel@lists.sourceforge.net; Wed, 22 Mar 2023 15:16:03 +0000 Received: by mail-io1-f44.google.com with SMTP id p17so6864380ioj.10 for ; Wed, 22 Mar 2023 08:16:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679498153; x=1682090153; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=wK1VjbQW4wiWs9MbJ33pKwAMV2Hl8NM2xzjzcJ6v/uY=; b=Kgyr/lBEbraCDhv6eJ/3VWk5XtGkxzYzX++cEPWrJ+f6tpU52PPUVzKNda2rjhvWqJ bL2CjdEw0Zq2Y7dg9AMY2PkxhyIO3CwiaTJtCQB7icWAt6zKCuO3gjkYRptifiCL8Bym LgCh2JYvgaGnelDOi+39oabTkpgWYwo6/q4WhpA+dqvAf/49vagcg9EruCHAjWUikYeg U/iXpcE/0pO3fgHYoUswFrPdK1kNUpUfmuaQlwdRhqp9KNSIPA63ljgSi+O73xr2Lhxi 7wzVnruc0JOGe1djTMT5VO6tttFf1mLKB+0SJNE9Eh9L9+1+51OS0/OdTs/+MJ1B2h6g 3n0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679498153; x=1682090153; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=wK1VjbQW4wiWs9MbJ33pKwAMV2Hl8NM2xzjzcJ6v/uY=; b=10rjBeEpiaMKKarbKvvaJwSlYjeQLvogmrWwrkJ/1CQbm+mZcGPf96QLx4ONiwRRjZ mpeiIYkdqSjk+MGFL/3rExi+YgZhB3GzVWo+IQi7AaY+5m6EsBSb7kiYWgSzgftcq1Lb prewhHWQoP9DYWa1OZvUJ7L/cA91JLivKAaxe7fPv4/+2f4SmDvBgHAkZ57Wny4WYmZ6 1eV4IPAekigt5o4+GabeRgZkNYTuksORDRDTzTsfmCPdvOTHEVslAFLEdtHcBPHusAWC yikCHjASKIC4qwxKj6EuK9zJABRWm9+lc8jCG3CuXbI8MV7vIpav1aLfaACEjuIQdSBB PWOw== X-Gm-Message-State: AO0yUKWvi72E1ih6QoEggryBlsoFzY1MOgYC4/wP9hvrW8OGQbPns1mJ YdjNeIV10Gmk+0GeH9HfNUIj7iiBF+0= X-Received: by 2002:a05:6602:707:b0:758:5525:860a with SMTP id f7-20020a056602070700b007585525860amr3000562iox.0.1679498152875; Wed, 22 Mar 2023 08:15:52 -0700 (PDT) Received: from uranus.sansel.ca (bras-vprn-tnhlon4053w-lp130-01-70-51-222-66.dsl.bell.ca. [70.51.222.66]) by smtp.gmail.com with ESMTPSA id n10-20020a5d824a000000b007046e9e138esm4497927ioo.22.2023.03.22.08.15.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Mar 2023 08:15:52 -0700 (PDT) From: selva.nair@gmail.com To: openvpn-devel@lists.sourceforge.net Date: Wed, 22 Mar 2023 11:15:50 -0400 Message-Id: <20230322151550.1596669-1-selva.nair@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "util-spamd-1.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Selva Nair - Unfortunately there are still users out there who disable IPv6 on tun/tap/dco interfaces or even system-wide. Fixes: Github issue #294 Signed-off-by: Selva Nair --- src/openvpnserv/interactive.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Content analysis details: (-0.2 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.166.44 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [selva.nair[at]gmail.com] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.166.44 listed in wl.mailspike.net] X-Headers-End: 1pf0C1-00Gh47-Vf Subject: [Openvpn-devel] [PATCH] Make error in setting metric for IPv6 interface non-fatal X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1761081497494614430?= X-GMAIL-MSGID: =?utf-8?q?1761081497494614430?= From: Selva Nair - Unfortunately there are still users out there who disable IPv6 on tun/tap/dco interfaces or even system-wide. Fixes: Github issue #294 Signed-off-by: Selva Nair Acked-by: Lev Stipakov Acked-by: Gert Doering --- src/openvpnserv/interactive.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/openvpnserv/interactive.c b/src/openvpnserv/interactive.c index a3d43752..98a42b1f 100644 --- a/src/openvpnserv/interactive.c +++ b/src/openvpnserv/interactive.c @@ -847,8 +847,8 @@ AddBlockDNS(const block_dns_message_t *msg, undo_lists_t *lists) BLOCK_DNS_IFACE_METRIC); if (!err) { - err = set_interface_metric(msg->iface.index, AF_INET6, - BLOCK_DNS_IFACE_METRIC); + set_interface_metric(msg->iface.index, AF_INET6, + BLOCK_DNS_IFACE_METRIC); } if (err) {