[Openvpn-devel] tests: do not include t_client.sh in dist

Message ID 20230418134941.86637-1-frank@lichtenheld.com
State Accepted
Headers show
Series [Openvpn-devel] tests: do not include t_client.sh in dist | expand

Commit Message

Frank Lichtenheld April 18, 2023, 1:49 p.m. UTC
It is generated from t_client.sh.in by configure,
so no need to ship it. Due to the dependency on
the configuration it also might break reproducibility
of the dist tarball.

Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
 tests/Makefile.am | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)


Gert Doering May 8, 2023, 12:11 p.m. UTC | #1
Acked-by: Gert Doering <gert@greenie.muc.de>

t_client.sh is built according to configure findings for @SHELL etc.,
so no good packing it.

Verified that the tarball before/after only differs in "t_client.sh",
that "distcheck" still passes, and that "make check" on the resulting
tarball builds & runs a t_client.sh as expected.

Your patch has been applied to the master and release/2.6 branch.

commit d75a2dfc3e11daa1650f838517b610e6632d0445 (master)
commit 477e7f5e91bfc66214c8d5466b24a424e2b401f4 (release/2.6)
Author: Frank Lichtenheld
Date:   Tue Apr 18 15:49:41 2023 +0200

     tests: do not include t_client.sh in dist

     Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
     Acked-by: Gert Doering <gert@greenie.muc.de>
     Message-Id: <20230418134941.86637-1-frank@lichtenheld.com>
     URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg26596.html
     Signed-off-by: Gert Doering <gert@greenie.muc.de>

kind regards,

Gert Doering


diff --git a/tests/Makefile.am b/tests/Makefile.am
index a46f2573..80673d56 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -25,8 +25,10 @@  TESTS_ENVIRONMENT = top_srcdir="$(top_srcdir)"
 TESTS = $(test_scripts)
 dist_noinst_SCRIPTS = \
-	$(test_scripts) \
+	t_cltsrv.sh \
 	t_cltsrv-down.sh \
+	t_lpback.sh \
+	t_net.sh \
 dist_noinst_DATA = \