From patchwork Mon May 15 15:54:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Lichtenheld X-Patchwork-Id: 3215 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7300:7b9a:b0:c3:1364:a2a2 with SMTP id j26csp6879779dyk; Mon, 15 May 2023 08:54:39 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4HEoiFGhiUiJApX53hesKDSDXnIBELvdaztJDk2RCUxLFJ8oAeFLGYen/7u22hOKxxL0Uz X-Received: by 2002:a92:d302:0:b0:331:9a82:33f6 with SMTP id x2-20020a92d302000000b003319a8233f6mr24193454ila.5.1684166079744; Mon, 15 May 2023 08:54:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684166079; cv=none; d=google.com; s=arc-20160816; b=oImnO7wKgE/qt+mZRWuIOPxelmKBemP2EIftRDmfsisvQEn+aedrrvn+FOXLi8ETsq atoRdcuCssu/crf7KpF0kvz9TiH1B5dK56sUygyflRfPe9I66W8bexmtliLk+Glt+6GM dKMyUE/ZvoikPkZv3DK3/ZMH3SjSJJQNc1Noih9z/JB/LnFg8qcyL70cJDyyAynAKixt M5pWM3Tcmkl4Lhj4MCLbGS88QE3VIw4yGVRrPf3h7Mg4O213LLk9oED3pfzlu2CqXLE9 HoIlvIe1wE/paLMFrhpdNxu6vXuw8NIB9j388H8ZOjPx134cXChupSJkcO1KUHsVN0oP r6yQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:message-id:date:to:from:dkim-signature:dkim-signature :dkim-signature; bh=oBAupONJTVrWMP0JCGdJ8cqouT0TNOz4PjTNFXhUhYM=; b=CTOdWJrxEkT1US9NY5Qpw5UgyAOFnrUavT3+BY/d468UiFFUzNp8O3DDcLSLH6xTM9 Z2TZH740nkZmGAq0GZv0l8gIH7rRuelMeVoUDHm9uI0j0pfbZHCRb47TwHuOaMhmttlh ld/7iw77plPV88VS4Dm67htOo5blb5PqWCIJsFLoVgwjAqa92f96sdcVw4rBcVvvUnHs aPmjfPwScvJYLWREtHzspdHFWyo2xOA6U+EwzjFQYdpJbI/AsCMMRDwbkl5oLFO6c4dt iokF5yjuWXwx4UU1kMJo/2Xg//xTM2Lcf0gWwgymKxbY0Nn4p0ZHsc3/CiWmePlyZZcB lUDQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=UYsaECcI; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b="RSI/9flS"; dkim=neutral (body hash did not verify) header.i=@lichtenheld.com header.s=MBO0001 header.b=iMfeEqya; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id s9-20020a056638218900b00417f384450dsi10378005jaj.78.2023.05.15.08.54.39 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 15 May 2023 08:54:39 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=UYsaECcI; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b="RSI/9flS"; dkim=neutral (body hash did not verify) header.i=@lichtenheld.com header.s=MBO0001 header.b=iMfeEqya; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1pyaWi-0001XQ-K8; Mon, 15 May 2023 15:54:20 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pyaWg-0001XJ-Eq for openvpn-devel@lists.sourceforge.net; Mon, 15 May 2023 15:54:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:Message-Id: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=e8V9zRkZem9h8//8dt3sN+r5nMoc66xiKJbcPY8RtT4=; b=UYsaECcIaNb7966wuPGtTklm2A sw9TsxjzXEZjo94BNEFI7WRCkhDdE4WMOrEwC9DvGHcHQwuQgiwsBO/y7WDC9H4Bc6qu0NWa7VmiF zeotTEIeLzGtDKA7lTAhSBYxxgIlqv9gNF5kNVL0a0l6ZWQKNLpWbyy2ck8t2kSt80K8=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject:To:From: Sender:Reply-To:Cc:Content-Type:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=e8V9zRkZem9h8//8dt3sN+r5nMoc66xiKJbcPY8RtT4=; b=R SI/9flS5A/vb+CgPN3p3++5XeVsbCw8Cz9cFuOHUMyQZwo7V/kJlOIL2fyx7jMx/7H8FVFJvqInsH 0TzPM9A7bD1sK6orrlZq4/AJXQyDPwEKARfjs64gdh/nD6/QSUZVW0ENIh6+Kl7HvUZ2nATFMUVHd w+ILU0p6C4Eylh9I=; Received: from mout-p-101.mailbox.org ([80.241.56.151]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1pyaWe-00023l-FT for openvpn-devel@lists.sourceforge.net; Mon, 15 May 2023 15:54:18 +0000 Received: from smtp202.mailbox.org (smtp202.mailbox.org [10.196.197.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4QKkSc26rpz9sTn for ; Mon, 15 May 2023 17:54:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lichtenheld.com; s=MBO0001; t=1684166048; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=e8V9zRkZem9h8//8dt3sN+r5nMoc66xiKJbcPY8RtT4=; b=iMfeEqyaQd+QJcAul2gsqEWfAzVD8uNpNVXdBRq3w6bNrjkYnYTaR9K/SvsxmIvLx3z8VU rgs2iaRxxXVWeF2EOpA56cC+Y4bEkl9EmNw5D7vDeNLRbOT/wDsGshWuCsVf18GnIsroaF lpQRoE+Cz/ODookLFuGnA4QlePbqWvgulFNiaezqDUsL1d43ly/Iy441jBRiEG4vWToBio pEzEbkQmC5xIhzFB6MG/WRsU9gPTrKoVdiwCWhY0mrhcHZJJUHkmzWjF3aH8XFocS7wTp8 nHBfnX563Faw3yEZptxRlWYGqraMbfD6Yav/Z3a1FRmRfaI+ZO4XzStusA2IBw== From: Frank Lichtenheld To: openvpn-devel@lists.sourceforge.net Date: Mon, 15 May 2023 17:54:07 +0200 Message-Id: <20230515155407.38647-1-frank@lichtenheld.com> MIME-Version: 1.0 X-Spam-Score: -0.9 (/) X-Spam-Report: Spam detection software, running on the system "util-spamd-1.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: A fallout of my memleak investigation. These are not leaks, we just assign a value that is never read before overwritten. Not critical, but since I already stumbled over it... Change-Id: I761ea3d289f49a20e42a3d1bfccebce3c7447afe Signed-off-by: Frank Lichtenheld --- src/openvpn/push.c | 1 - src/openvpn/tun.c | 3 +-- 2 files changed, 1 insertion(+), 3 [...] Content analysis details: (-0.9 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [80.241.56.151 listed in list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-Headers-End: 1pyaWe-00023l-FT Subject: [Openvpn-devel] [PATCH] Fix two unused assignments X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1765976131498002203?= X-GMAIL-MSGID: =?utf-8?q?1765976131498002203?= A fallout of my memleak investigation. These are not leaks, we just assign a value that is never read before overwritten. Not critical, but since I already stumbled over it... Change-Id: I761ea3d289f49a20e42a3d1bfccebce3c7447afe Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering --- src/openvpn/push.c | 1 - src/openvpn/tun.c | 3 +-- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/src/openvpn/push.c b/src/openvpn/push.c index 54e53f6a..8e962719 100644 --- a/src/openvpn/push.c +++ b/src/openvpn/push.c @@ -713,7 +713,6 @@ send_push_options(struct context *c, struct buffer *buf, { struct push_entry *e = push_list->head; - e = push_list->head; while (e) { if (e->enable) diff --git a/src/openvpn/tun.c b/src/openvpn/tun.c index 2320e8b1..df10dbd2 100644 --- a/src/openvpn/tun.c +++ b/src/openvpn/tun.c @@ -4337,7 +4337,6 @@ get_unspecified_device_guid(const int device_number, struct gc_arena *gc) { const struct tap_reg *tap_reg = tap_reg_src; - struct buffer ret = clear_buf(); struct buffer actual = clear_buf(); int i; @@ -4381,7 +4380,7 @@ get_unspecified_device_guid(const int device_number, } /* Save GUID for return value */ - ret = alloc_buf_gc(256, gc); + struct buffer ret = alloc_buf_gc(256, gc); buf_printf(&ret, "%s", tap_reg->guid); if (windows_driver != NULL) {