From patchwork Wed May 17 20:01:43 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ilya Shipitsin X-Patchwork-Id: 3225 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7300:7b9a:b0:c3:1364:a2a2 with SMTP id j26csp1437479dyk; Wed, 17 May 2023 13:03:13 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7cffcBCytmVjDFYo09Lk1FogPGxmzeL3az+hRtK7uwHEAkO0mwOBJyahAymcAdVz03ICOl X-Received: by 2002:a05:6602:2101:b0:770:338:c338 with SMTP id x1-20020a056602210100b007700338c338mr4775528iox.0.1684353793727; Wed, 17 May 2023 13:03:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684353793; cv=none; d=google.com; s=arc-20160816; b=H/AgG0iGTMyBglXsr0eum8FExqkV4o10nK7wwwUrxN3pCzVFzFN+rHXvzLQQz0cgEB JAVHE/U3awHSmuC+tYNr5pxBqj8rTOvkqUug9k1xwZxu2NvQ0yYLJYnwtIee975JRIWK FQ4u+kSdmZe63tIEC+xLli8UYsDEC6w7EmME2RjzZKbWNMttGWZMQ2mkviMnvqBE5E0m n8TfrF5xySdSLExLWBM+4lYAFSGJBFBgpKTyaKK4/03N9NxOOpb6X9BDuWjolxbixt4a 1wCDUCWsFotwTmCtO8ss4HEabpdZ1eBAoHo950ziTZNDnKH0rQnUBQAQaLj9Hd3d/BGf QVmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:message-id:date:to:from:dkim-signature:dkim-signature :dkim-signature; bh=ujRRnHt1CJiODK9RZ9XGp2x0puSbrNCXS38yKCXvgaU=; b=Z5hndVLsbxBU1DhuVY+q4g+uk/1g6uqLssE0N/KHg9H7kL1K4Ss9EmD4USQcwB63AU eMjGBj2o3C6a7Jh/mqaAj6IGrBIGOywSPDVwjpWasrNIbgumlFj6zuPrryl6FQ9FsyIF 2Pgce7j+v3iaeYtlOWTAagM8e/Kq+gQcjYmVUBgvz0EPwA2a1qzU7Upc6tNZBDqvpdSY xmMC7qBJphr/P3H7+gKavcG/VMekx4Na/jl/ZnOXZcNltaQGCuUmd3Y0bNvuTDp+VZ/o ABwR1+EnIYZaaHnsZ8Cwd4Htmc4hdOTmhd2U8+FalqaetU/jx3PPXbRyIVsRXAaFmpbe w0oA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=Xhik4S6v; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=X4b2bQho; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20221208 header.b=RCgX0M6s; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id a63-20020a021642000000b00412c1c30d92si14280845jaa.155.2023.05.17.13.03.13 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 17 May 2023 13:03:13 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=Xhik4S6v; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=X4b2bQho; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20221208 header.b=RCgX0M6s; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1pzNLh-0004hD-CN; Wed, 17 May 2023 20:02:13 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pzNLf-0004h6-Fz for openvpn-devel@lists.sourceforge.net; Wed, 17 May 2023 20:02:11 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:Message-Id: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=tEM34E/TPG9MPdhPVsNzHrl/gARAUmLMw/0cC3cXndY=; b=Xhik4S6vH9wMa7Sy8ix1a6bpF0 EAEWkzegQzSvyQ69KIvgaXyPgi8XuXlHe6FjhfUZKeSOGZSsSeYqvP5th10yxri4Ja/hNHU76pYdQ 7TM1kshh87vv4Z2d/NdKSYTrbr2mjH24JAm8cvkfZO/vrC6Omo9CMt3Uq1QwE1A9dzZ8=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject:Cc:To:From :Sender:Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=tEM34E/TPG9MPdhPVsNzHrl/gARAUmLMw/0cC3cXndY=; b=X 4b2bQho5p2KlMkkkaImbd4JAxeTiryYmT0IvB0K3usISjG3AybKWEn53bCo2gLY8edwT8yanlhGRD UlW2z0R1oLVOlq7YXcXP11o1Ll9CteNNsDPQr7pkGtdmmQKV3eqaMoH3fq/9b2QYpsWhZZUqP7xzA giq6Cuqnk2RGsK44=; Received: from mail-ej1-f47.google.com ([209.85.218.47]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1pzNLa-0007v3-VJ for openvpn-devel@lists.sourceforge.net; Wed, 17 May 2023 20:02:11 +0000 Received: by mail-ej1-f47.google.com with SMTP id a640c23a62f3a-965f7bdab6bso226501566b.3 for ; Wed, 17 May 2023 13:02:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684353720; x=1686945720; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=tEM34E/TPG9MPdhPVsNzHrl/gARAUmLMw/0cC3cXndY=; b=RCgX0M6szunvnnly8l5mw+ylhFtqtklcTQVfBOf3DqUinkkGb/shlHBKhz1TIesoTf XVOE1lVLBijlj3Zw8YWWcQ2YyPohMyDXiGuthIufkd+x+KvhqQiT29rw4ZfIkPNtE86D 4GBkVbY97+zeF+qW3d6GzvgAUNLbAg1OV90XWDlUhSqWMoKcZhroUg12u2ip9MbcoD6X Li3tcP+Z/yO4++d0ENJ6lXVqJ+qqLcqMOJzIepsgXLRzFtpoiIgFNxkJgmgXrkR4Yiow mR2Q/WSa3gH1mnjPC0AnC7jnr8gNNhRRSc2weLnX6tLSQj+cehHaN+tYU88ZRtsgU00R ZXsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684353720; x=1686945720; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=tEM34E/TPG9MPdhPVsNzHrl/gARAUmLMw/0cC3cXndY=; b=AsOGcNK5PCueXcHeFVgUZMyfFc0947UGmHvbLBA9cmSRnY1GXGyyjfh4xg1+MIicV0 pADmn4E0bjJRMfsWD+yrH3r9BG6SkXC8GwKiIy04VcbkKo5zRtA75AgLPNCeK2JrPLV4 y7fOCunBSZNLMGbETsxwTQh739hjOhySbkdIBTDpl2p436elDmZFGu6xITnLI4EyXSq/ QdPhldKgKt8TU0p4rwi7BbCdXuWOSvnZCFh5Ml+LXhCz2LDNTmiB6nc5lXsztuCSB+Tm jTufFutopPSaVqZLekLY5DB7b/4lk6VrTFIwvcDryKVed4wHn6s3XB7UfwW3LEone/tr 8Ndw== X-Gm-Message-State: AC+VfDx8OPCzpvg1VloWl2enpvesE7afh5xANtdPbXGuqx+qqX8Q6LEC 8k3Eswxse0FLI/9CNHzzaXjm9EZJbb4= X-Received: by 2002:a17:907:a41e:b0:94a:4b7a:9886 with SMTP id sg30-20020a170907a41e00b0094a4b7a9886mr41737833ejc.12.1684353719852; Wed, 17 May 2023 13:01:59 -0700 (PDT) Received: from localhost.localdomain (93-87-109-148.dynamic.isp.telekom.rs. [93.87.109.148]) by smtp.gmail.com with ESMTPSA id mm10-20020a170906cc4a00b00960005e09a3sm12700749ejb.61.2023.05.17.13.01.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 May 2023 13:01:59 -0700 (PDT) From: Ilya Shipitsin To: openvpn-devel@lists.sourceforge.net Date: Wed, 17 May 2023 22:01:43 +0200 Message-Id: <20230517200143.216-1-chipitsine@gmail.com> X-Mailer: git-send-email 2.35.3.windows.1 MIME-Version: 1.0 X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "util-spamd-1.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: malloc was not checked against NULL, I was able to get core dump in case of failure Signed-off-by: Ilya Shipitsin --- src/openvpn/dco_freebsd.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/openvpn/dco_freebsd.c b/src/openvpn/dco_freebsd.c index 1111abeb..adbd1120 100644 --- a/src/openvpn/dco_freebsd.c +++ b/src/openvpn/dco_freebsd.c @@ -594,6 +594,11 @@ dco_available(in [...] Content analysis details: (-0.2 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [chipitsine[at]gmail.com] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.218.47 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.218.47 listed in wl.mailspike.net] X-Headers-End: 1pzNLa-0007v3-VJ Subject: [Openvpn-devel] [PATCH] src/openvpn/dco_freebsd.c: handle malloc failure X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1766172963473458850?= X-GMAIL-MSGID: =?utf-8?q?1766172963473458850?= malloc was not checked against NULL, I was able to get core dump in case of failure Signed-off-by: Ilya Shipitsin --- src/openvpn/dco_freebsd.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/openvpn/dco_freebsd.c b/src/openvpn/dco_freebsd.c index 1111abeb..adbd1120 100644 --- a/src/openvpn/dco_freebsd.c +++ b/src/openvpn/dco_freebsd.c @@ -594,6 +594,11 @@ dco_available(int msglevel) } buf = malloc(ifcr.ifcr_total * IFNAMSIZ); + if (buf == NULL) + { + close(fd); + return false; + } ifcr.ifcr_count = ifcr.ifcr_total; ifcr.ifcr_buffer = buf;