From patchwork Thu May 18 21:21:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ilya Shipitsin X-Patchwork-Id: 3230 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7300:7b9a:b0:c3:1364:a2a2 with SMTP id j26csp668878dyk; Thu, 18 May 2023 14:22:29 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7yYJKxWanht0MsivaWoFpUf+8LjLYjM5Vi0G5X2bZLR40ahspB5slJjExLnK6uAaxhAV/g X-Received: by 2002:a6b:6f01:0:b0:760:ec21:a8af with SMTP id k1-20020a6b6f01000000b00760ec21a8afmr8303483ioc.0.1684444948858; Thu, 18 May 2023 14:22:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684444948; cv=none; d=google.com; s=arc-20160816; b=TztwSrRVe7e1pk6rs2MIldARtKF5y/M9XJrFYm2ODeBlTMQmpLTg7pX5WC/6W56xmd ki2GEPRKxQ1BMfWUOeFArqxXSLMKcoeXCVO3cMhgsafZED/6FbXdbmkhUG1UXdpBDHqU wK8Y8xGfZuUcb9HIDMpdntMJGiVIE+hT8zLQoT+R0gu7gtYDrR8fvpu637/6V4jgHIyj K9NTf1AP4LjOehoTZ704nYmSGOSRjbdbv1iG/fo0YpAGp6afYK008ef2hTAlQgHhhT3K waUOAaMzxM15TdZr11lqx5JGDDyCVMIa0Hy6wu3IKIfLtnOnYKDPy/u8ZtWgD2Wx9Vvg ja+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:message-id:date:to:from:dkim-signature:dkim-signature :dkim-signature; bh=rOxeDEit5M2lPkDh8BQoMtQdbdmzJu8F46yaC1RoED0=; b=m18g/gmjAf6p19dcESMYRaSlZ6yUg0tXgvM37waH3QgVRMW02BteO3ZuUNYnvRUCIS 1d5w/LSeQGfeF+yVx4Qkon5cjgTCuzYES3aZHFujXTsSTXQ0hSdkhcbzNWJRGGF8zN26 Wf1D2k//aoWvs8rdEq8s1U05Zd3ZdUbh8+/ysAUXxX4fGjsgulvYucLUJnYfQdel6opO K5NJZRlHPgZin++P4pTwhJtP5IFZROou54Ehku7w3sm/sFj5Y4zkcOquRfGOswUS1eVt 6v/HpuWdtI8A/vLQh284tunXM2w2P2TA5N4fJVlgu6at037EIrXL/wWbVKvXWpJjUB3s TS9Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b="QPB/o1dB"; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=Y+4yANmp; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20221208 header.b=rQXtWlfl; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id b17-20020a056602331100b0073d457b4326si1256451ioz.9.2023.05.18.14.22.28 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 18 May 2023 14:22:28 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b="QPB/o1dB"; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=Y+4yANmp; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20221208 header.b=rQXtWlfl; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1pzl4W-00034O-WE; Thu, 18 May 2023 21:22:05 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pzl4V-00034D-Mv for openvpn-devel@lists.sourceforge.net; Thu, 18 May 2023 21:22:03 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:Message-Id: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Y1lmYX6JCr5Vdn/niJThPQU1Jti+A6fjvx0bB2vhIVk=; b=QPB/o1dBmQm4LwMNQRYm4SyD1U 00jNlqlcFGBG18yTjeUNrQ3QFJz3vg717Et3aECu1gv4AJ5JnqUnRwxUjSKjG1FzgHD7BVIDi3Mfo 3d5mXrLRidSycQhh4Fk6Vcnz0anx86sjPx9IxjU900Ri76f3Gv75wVOBqWL69fkF+9kU=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject:Cc:To:From :Sender:Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=Y1lmYX6JCr5Vdn/niJThPQU1Jti+A6fjvx0bB2vhIVk=; b=Y +4yANmphxL4IAFdWrPDHdirBINBvMVubxLofbkVjJp5yRx7aeiSrPi1sJfx0W5ZW0aiFuScRTGCi3 OdP9QPK+cS6Pm8P4jsxQsn/pgTHjUpzzuWxy34sBRBVES8Os4ybpxyhrBuWCQPPVt8EtmKvhjNpnI +Vk/9+V2h6Ueo2ag=; Received: from mail-ej1-f51.google.com ([209.85.218.51]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1pzl4S-0007Om-1x for openvpn-devel@lists.sourceforge.net; Thu, 18 May 2023 21:22:03 +0000 Received: by mail-ej1-f51.google.com with SMTP id a640c23a62f3a-96622bca286so483846566b.1 for ; Thu, 18 May 2023 14:21:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684444913; x=1687036913; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Y1lmYX6JCr5Vdn/niJThPQU1Jti+A6fjvx0bB2vhIVk=; b=rQXtWlflgU6LM2LSaZMqyj6gFjk7DRSLhUgeMwdn2cfCYSobiFTiuk47wTMWX1Y93+ a5jNQX8i8wR9LlpjMuvli6vU6NnlGzc1UN8IO0qpWZIA1W+yPwgDquvyMHtJJ2Jii/rm 3cQCKOuxU4HzVtLr/hGQTfH8wwAxi7JZJmvmz/go5+jhI2CGNbJPedx9zAjzDIqhFrEm OhwoJE/6+SEPnXu6AC8u3TVSQFjG+ixoZ0YAojVPHx21m/vl3zIgBXDlhqQvqt+j0dy+ lK9CLIo6tnXV+pG8zvSdNImXpyFCZfzGVVg/rC369sENMZomeWMCXcpNArI+MGAZSB8k 8RhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684444913; x=1687036913; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Y1lmYX6JCr5Vdn/niJThPQU1Jti+A6fjvx0bB2vhIVk=; b=CX7nr+W2K4v1w2kKyrPFWj8lQB4xzrBsgUamTIK+kH0R1GjsKt94qBj4f23L92bocf p3vFwwiy3eT6H/kP5Ve7MKpKtABkAtsPcrKYZ4un7CaAW+EJwYf/6MCQ8JZ1N7te5jvd ihJms1rUAB1KVtY4Nz2uxCccj79yOS4pgb3BoA84Hr9I0acto2/8qlJdalAkTY/dFlQP PVZi1I//oCZoaTkDKIAPHZH3zQYdVMJwYawiuvG7WpG3oHVx51EK83o2IhZShDdiIZDK CdW2WT9zTdcTtjxGQ7b3aDy5tJDBrGDkmW0C1h1OXAcOmshP4cvNzItsVkCXLxS/zZ9D JXZQ== X-Gm-Message-State: AC+VfDyozHGpuUxG0H/y6hbSNRNQhJOdi/Uzp+4lk87+gWHyKKETjb3Z E9m4KMMAGHsST60TJYiw5zOpvq6Tnfg= X-Received: by 2002:a17:907:97d5:b0:966:391b:5b3e with SMTP id js21-20020a17090797d500b00966391b5b3emr620457ejc.55.1684444912970; Thu, 18 May 2023 14:21:52 -0700 (PDT) Received: from localhost.localdomain (93-87-109-148.dynamic.isp.telekom.rs. [93.87.109.148]) by smtp.gmail.com with ESMTPSA id va10-20020a17090711ca00b0096ee563f49csm1452387ejb.30.2023.05.18.14.21.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 May 2023 14:21:52 -0700 (PDT) From: Ilya Shipitsin To: openvpn-devel@lists.sourceforge.net Date: Thu, 18 May 2023 23:21:39 +0200 Message-Id: <20230518212139.1261-1-chipitsine@gmail.com> X-Mailer: git-send-email 2.35.3.windows.1 MIME-Version: 1.0 X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "util-spamd-2.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: malloc was not checked against NULL, I was able to get core dump in case of failure Signed-off-by: Ilya Shipitsin --- v2: - style correction src/openvpn/dco_freebsd.c | 4 ++++ 1 file changed, 4 insertions(+) Content analysis details: (-0.2 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [chipitsine[at]gmail.com] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.218.51 listed in list.dnswl.org] 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [209.85.218.51 listed in wl.mailspike.net] 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders -0.0 T_SCC_BODY_TEXT_LINE No description available. X-Headers-End: 1pzl4S-0007Om-1x Subject: [Openvpn-devel] [PATCH v2] src/openvpn/dco_freebsd.c: handle malloc failure X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1766268546405410339?= X-GMAIL-MSGID: =?utf-8?q?1766268546405410339?= malloc was not checked against NULL, I was able to get core dump in case of failure Signed-off-by: Ilya Shipitsin Acked-by: Gert Doering --- v2: - style correction src/openvpn/dco_freebsd.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/openvpn/dco_freebsd.c b/src/openvpn/dco_freebsd.c index 1111abeb..af7776bb 100644 --- a/src/openvpn/dco_freebsd.c +++ b/src/openvpn/dco_freebsd.c @@ -594,6 +594,10 @@ dco_available(int msglevel) } buf = malloc(ifcr.ifcr_total * IFNAMSIZ); + if (!buf) + { + goto out; + } ifcr.ifcr_count = ifcr.ifcr_total; ifcr.ifcr_buffer = buf;