[Openvpn-devel,3/4] unit_tests: Add missing cert_data.h to source list for unit tests

Message ID 20230619132934.76085-4-frank@lichtenheld.com
State Accepted
Headers show
Series Various dist-related fixes | expand

Commit Message

Frank Lichtenheld June 19, 2023, 1:29 p.m. UTC
Document the dependency. Also fixes cert_data.h missing from
distribution.

Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
---
 tests/unit_tests/openvpn/Makefile.am | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Gert Doering June 21, 2023, 12:34 p.m. UTC | #1
Acked-by: Gert Doering <gert@greenie.muc.de>

"make sense".  Verified that it still builds ;-) - and adds this extra
file to the tarball.

The patch does not apply to release/2.6, because the whole pkey_test_utils.c
part is not part of 2.6.

Your patch has been applied to the master branch.

commit 97223cb057a0edfafd28b34427449bb3eda7d0be
Author: Frank Lichtenheld
Date:   Mon Jun 19 15:29:33 2023 +0200

     unit_tests: Add missing cert_data.h to source list for unit tests

     Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
     Acked-by: Gert Doering <gert@greenie.muc.de>
     Message-Id: <20230619132934.76085-4-frank@lichtenheld.com>
     URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg26750.html
     Signed-off-by: Gert Doering <gert@greenie.muc.de>


--
kind regards,

Gert Doering

Patch

diff --git a/tests/unit_tests/openvpn/Makefile.am b/tests/unit_tests/openvpn/Makefile.am
index ccd0e37b..dbf658ac 100644
--- a/tests/unit_tests/openvpn/Makefile.am
+++ b/tests/unit_tests/openvpn/Makefile.am
@@ -162,7 +162,7 @@  cryptoapi_testdriver_CFLAGS  = @TEST_CFLAGS@ \
 cryptoapi_testdriver_LDFLAGS = @TEST_LDFLAGS@ \
 	$(OPTIONAL_CRYPTO_LIBS) -lcrypt32 -lncrypt
 cryptoapi_testdriver_SOURCES = test_cryptoapi.c mock_msg.c \
-	pkey_test_utils.c \
+	pkey_test_utils.c cert_data.h \
 	$(top_srcdir)/src/openvpn/xkey_helper.c \
 	$(top_srcdir)/src/openvpn/xkey_provider.c \
 	$(top_srcdir)/src/openvpn/buffer.c \
@@ -180,7 +180,7 @@  pkcs11_testdriver_CFLAGS  = @TEST_CFLAGS@ \
 pkcs11_testdriver_LDFLAGS = @TEST_LDFLAGS@ \
 	$(OPTIONAL_CRYPTO_LIBS)
 pkcs11_testdriver_SOURCES = test_pkcs11.c mock_msg.c \
-	pkey_test_utils.c mock_get_random.c \
+	pkey_test_utils.c cert_data.h mock_get_random.c \
 	$(top_srcdir)/src/openvpn/xkey_helper.c \
 	$(top_srcdir)/src/openvpn/xkey_provider.c \
 	$(top_srcdir)/src/openvpn/argv.c \