From patchwork Mon Jul 3 15:39:25 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Lichtenheld X-Patchwork-Id: 3270 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7301:3c07:b0:d9:b492:11d6 with SMTP id ki7csp4396818dyb; Mon, 3 Jul 2023 08:40:17 -0700 (PDT) X-Google-Smtp-Source: APBJJlEO7rj3RUYlRHplMXnTU+B0aDLNunbVDgIlEo9PCkSu1PjTGNSA+VpReuMcl81l/0OpdGEw X-Received: by 2002:a92:911:0:b0:346:11d8:b862 with SMTP id y17-20020a920911000000b0034611d8b862mr2334767ilg.9.1688398817406; Mon, 03 Jul 2023 08:40:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688398817; cv=none; d=google.com; s=arc-20160816; b=LUVA46h8h9ztFGSTobUHIhGeRK/BcK4KA6N9/+6vbpatzbv3zqQmiwXaOo/8ARnOrU +PsFW6yXA2uweJNQMk+aL6jOzwxohANrsE8K4lqp45BE7L07Yau/uBTFE4icNn7PKKZH ZT0BFWoJIkCzKBNsj6ZG8DeeOpg/hJT8pCSTu9rLt4BPOoy8zNEKhxubQ7taqy0ELgd9 7drQR3Wd0mCJULYj9KOVAlauPM26Fs8OjnSTyZ1N9fL7MFiooVt5RWgSdEEutEXdAvJH Cfxa4O+UpDM83YfEWA+a+bvLJWEW3C2uX1htHN9b46yDl93gNNwLg0xO8MfgXZ/0XCvZ /o7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:message-id:date:to:from:dkim-signature:dkim-signature :dkim-signature; bh=P57jFggduiuJwCLefEwY0jKaXpx5DtWD7FUKvqxAVO0=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=uK5eSA+WMb3YZLGjh+JHyBFF47gDmRdKL9XSEmZPDgTnr8CRekaOczUSkTFrkH+8hI Y+U1ShHgBvnnmbJTqTF80NwB823tDNYzHuKQCbB8CS6iMtCZ7UCE7J0jZiuRMumzkAO7 7+jIj/4eczsaEeZZ/TniRjiou4/AosrYhFZ1JC9IIkJQYyE+xE/20kptcjzj6QdTcKK+ gMI2HYFk81mf4qUR/R47NtuLcRYnKavDrx+II5+wDurO7VGuulJdd/Mo2g1kUAgzYxfB ccPKl4oN3eCCGdq0FZRcTAVwd8+KS9z822l3F95TeX6cJ1BR85uWj64l4yit3XXHDuH1 4Zvw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=UCCgjqNs; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=TUW9aIdC; dkim=neutral (body hash did not verify) header.i=@lichtenheld.com header.s=MBO0001 header.b=evLL9yDr; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id g13-20020a63520d000000b0054ff8291783si18594121pgb.424.2023.07.03.08.40.16 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Jul 2023 08:40:17 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=UCCgjqNs; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=TUW9aIdC; dkim=neutral (body hash did not verify) header.i=@lichtenheld.com header.s=MBO0001 header.b=evLL9yDr; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1qGLeT-0002yV-8e; Mon, 03 Jul 2023 15:39:46 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1qGLeR-0002yO-Dz for openvpn-devel@lists.sourceforge.net; Mon, 03 Jul 2023 15:39:45 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:Message-Id: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=TZeUDxRsqEwQSui1FtVXFNWgdlVpuUra41IKFda3H/c=; b=UCCgjqNsDea9aU8LBOadjGku2B abnzr6GNA2K4BT69o6hVtDGFU3Ij9r7JhwR1BJcMh35l/kTlDMisauOfUHBQfmg5mGXInj9Ff+QHa L+8S5BRgsdUZD0DECkS0UuYNYFuzecj6gJp+FaGbVNQzmcIt0yptu2v9Hb32sIOQMkGI=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject:To:From: Sender:Reply-To:Cc:Content-Type:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=TZeUDxRsqEwQSui1FtVXFNWgdlVpuUra41IKFda3H/c=; b=T UW9aIdCi4dRYSC5o3w/llzpBB6k5cgW+Gy7mtTXGt38sfb2cO6TEGOKkXyFRrzCxHgbh2uet4RElm Kk8F5i1QpK/aygPfBfi9clmGjSAxqIw4aMONEQLCDwsrYjT59a/lVUC6oR9mIeKwdeJhvu4ksVyoa usVGHNgLRPjo0u+E=; Received: from mout-p-201.mailbox.org ([80.241.56.171]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1qGLeN-0007BE-13 for openvpn-devel@lists.sourceforge.net; Mon, 03 Jul 2023 15:39:44 +0000 Received: from smtp202.mailbox.org (smtp202.mailbox.org [IPv6:2001:67c:2050:b231:465::202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-201.mailbox.org (Postfix) with ESMTPS id 4Qvqq16SjHz9smj for ; Mon, 3 Jul 2023 17:39:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lichtenheld.com; s=MBO0001; t=1688398765; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=TZeUDxRsqEwQSui1FtVXFNWgdlVpuUra41IKFda3H/c=; b=evLL9yDr1RSApiuZmQEw5NIDmO8VLb/qqmrc0EkSQBYnYm6nVyXZsYKTVX/MawpLyDEH3d nFHjKGX54DkjLEKayXuiaFbl5XQTvaKmrMrE5uE+Ir7zLrJiR+1VwNWLm2FDyyk8SEQ3wU ZSp0jjmhMdFudF7dLfgXgndvSUbeBgI2gmKDpegZYCEb38iteGmbBOjKcXzI9MIVSCz0Xa kxfK2Ot7ZG4D1tQx79yYi1dwq0cPLKZ4fGUgOizV9opEIWS1LJLHCDKYcE/acJB82m/+/7 zEWB/+JRR2ouIKmS+fwIgPTa/LN2nrYVoiRaTr2MU0v/kSyXqbx8Pkv9uO0pBQ== From: Frank Lichtenheld To: openvpn-devel@lists.sourceforge.net Date: Mon, 3 Jul 2023 17:39:25 +0200 Message-Id: <20230703153925.48990-1-frank@lichtenheld.com> MIME-Version: 1.0 X-Rspamd-Queue-Id: 4Qvqq16SjHz9smj X-Spam-Score: -0.9 (/) X-Spam-Report: Spam detection software, running on the system "util-spamd-2.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: This causes weird, difficult to debug compilation errors. Usually caused by trying to run CMake against a source that had an in-tree autoconfig build. Note that you're able to do out-of-tree autoconfig builds and they can obviously mix with out-of-tree cmake builds. Content analysis details: (-0.9 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [80.241.56.171 listed in list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.0 T_SCC_BODY_TEXT_LINE No description available. X-Headers-End: 1qGLeN-0007BE-13 Subject: [Openvpn-devel] [PATCH] CMake: Throw a clear error when config.h in top-level source directory X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1770414478692000089?= X-GMAIL-MSGID: =?utf-8?q?1770414478692000089?= This causes weird, difficult to debug compilation errors. Usually caused by trying to run CMake against a source that had an in-tree autoconfig build. Note that you're able to do out-of-tree autoconfig builds and they can obviously mix with out-of-tree cmake builds. Signed-off-by: Frank Lichtenheld Acked-By: Arne Schwabe --- CMakeLists.txt | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/CMakeLists.txt b/CMakeLists.txt index acebbb73..597dc907 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -26,6 +26,10 @@ if (NOT WIN32 AND NOT ${UNSUPPORTED_BUILDS}) message(FATAL_ERROR "Note: on Unix platform the official and supported build method is using autoconfig. CMake based build should be only used for Windows and internal testing/development.") endif() +if (EXISTS "${CMAKE_CURRENT_SOURCE_DIR}/config.h") + message(FATAL_ERROR "The top level source directory has a config.h file. Note that you can't mix in-tree autoconfig builds with out-of-tree cmake builds.") +endif () + option(MBED "BUILD with mbed" OFF) option(WOLFSSL "BUILD with wolfSSL" OFF) option(ENABLE_LZ4 "BUILD with lz4" ON)