From patchwork Wed Jul 5 12:25:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lev Stipakov X-Patchwork-Id: 3273 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7301:3c07:b0:d9:b492:11d6 with SMTP id ki7csp5608937dyb; Wed, 5 Jul 2023 05:26:05 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4NrBu8HXttOL6eMuYvaVdTKy09HUJDcY+jsZGJWIBylPEjL7ayrLDFEPmyLWjztihMMTsK X-Received: by 2002:a05:6a20:3d14:b0:115:83f:fce1 with SMTP id y20-20020a056a203d1400b00115083ffce1mr20683821pzi.5.1688559964998; Wed, 05 Jul 2023 05:26:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688559964; cv=none; d=google.com; s=arc-20160816; b=RsXWVzOeeGYW8EowdQ9e20VyO6/kmaXFXn+0DSG5vnVwjUnGoqERC3xVLZZ15js4JI JV4ZHthvDPZpNy+W7rrvO6OfiQ0T6dF/hPrtB3L7UhOcQ8NjPm4Q1dkk3WF+q0TwHgBV lJUaT8LBNSna4XNNaURIsG7TgxtCMCOUIVklKnyRUebxp28yqC8cC0rf2DemzEXxI1HS 71VhDjcyTp+lMrzEZ3V9TckCnw63iSB6WHBzmp9hpuo0zHHIH1c807GTdg6t123QEbBI TvGmUjfvukUklL+B/T0jToeJ3QQ6cl+jTmv/H4dlxd8J2FcVh6dq967JS/HbeHPxebBz Gg+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:content-transfer-encoding:cc:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=8MNIG4gVeQ7LbADuZhuDYBL0PTD3cEm+pnQGQ4AOJ3c=; fh=ZRBZ3p4fvLYBwsG7McdxRCx2fnmH9YCsPK+JAqT+6LA=; b=KipTMPN/ajUTpNfH5Jhz+NcJlSqcQS0LPfTGrlrjFHlloHYfgS7jgt8xhUqOtR3luC GHKMGA2CFZCaQQrERA55zxd1h2iNU46MXN2Hy+Gi4vUrhkXn/dZJkyuLGtkdHwKIlNkM 3txr/01AfSXa4SQcCOb9U/fvGd4ucFz0B6818uqR7haXRDsKcMT7luCo8bfOJdf+xCkM FdlCLqBjsve1wFsGry05ByexF8Bu3Sax/wk4YsB/0SrKzatZ0VhSkh5/t2BqpCs86Akj tbX9d2G/tT9yKJYB2/kuvuO9N4dcDUqi/9supiA3TEODErBy6sHTJQh8/md76hgIa3XZ niLQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=X35haZ8Q; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=hxq7tj1Y; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20221208 header.b=NCj7Gy7I; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id q23-20020a631f57000000b0055070c6da5bsi21718992pgm.670.2023.07.05.05.26.04 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 05 Jul 2023 05:26:04 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=X35haZ8Q; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=hxq7tj1Y; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20221208 header.b=NCj7Gy7I; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1qH1Zf-0000HY-Tt; Wed, 05 Jul 2023 12:25:36 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1qH1Ze-0000HS-K7 for openvpn-devel@lists.sourceforge.net; Wed, 05 Jul 2023 12:25:34 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Pi/jnhLxEOTBLqCH5SJn/iPbjcw4/GOeVHN2DrBz7P8=; b=X35haZ8QO2p+5DORz1DpykkJz/ 7bfAD5/YXKov5yp2AjDefLaEtVdG52a5KCyOfRmwPgJChX0VVpi2VPoqu5BUxik7DqQFlrQN/Fnt4 UVO5VAuFu3C8ud4n7PmlssQRyjKuUbpov/b6wgj6R0GaILd210Mm8LXR2BQ/N5aiN8nk=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-Id: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Pi/jnhLxEOTBLqCH5SJn/iPbjcw4/GOeVHN2DrBz7P8=; b=hxq7tj1YYlBF4fJfDcyT1M69sZ V24qPqFLqrXf3mW2ysu2fBuKKhlVW2aNTNcid3lA/vuy25tG4QF8sIp5DjqsrpTmsUyatoJ68igdf zZd7thPZOfU7ZxvJZwZlnJOTWCIyHQXiYY4W1sCX6C6edoFMUVEaJOOdmX4+LsGRx/hI=; Received: from mail-lj1-f173.google.com ([209.85.208.173]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1qH1Zd-0003qy-0V for openvpn-devel@lists.sourceforge.net; Wed, 05 Jul 2023 12:25:34 +0000 Received: by mail-lj1-f173.google.com with SMTP id 38308e7fff4ca-2b701dee4bfso5503621fa.0 for ; Wed, 05 Jul 2023 05:25:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688559926; x=1691151926; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Pi/jnhLxEOTBLqCH5SJn/iPbjcw4/GOeVHN2DrBz7P8=; b=NCj7Gy7IxOdq15qxnIlPJMRd1A+rXsjp1QO5I9vYT5N1vCfx5U2iHpdBfu9KXGfeHj VJ1/I+ynEQKa2sPkfYDWudLF9WFqgkw+0BIffIZtzvzNne7cvBk2wBGuf9kkwTdhj/eB SDzImZTZQB0UGVkBVG5B/WcWLQuLK2v76O8Y2dOAxMV8tDjKZt0RsZ354KABrh7Awvym R2Xa2NjRjavGSL77yZR+OOboFS8RWkQ/nuEHEN1vyQ52T4vdAA1ViGDTgxMu6phH3y5z O4YbmUPxmihV+ejuxWxAi54/b4NFjnqbhi3B/Nh7IQsry96aOU0k5k35Z8ogsuNDyG09 o3wA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688559926; x=1691151926; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Pi/jnhLxEOTBLqCH5SJn/iPbjcw4/GOeVHN2DrBz7P8=; b=RGTi3uQAYsLaye5SbfEQHjsIwqaPh/O3YeA432ygdfH4y4b2Z+IC3ygcyrb2i7FH8m Q4/fJqjeGu8ABZeeQkemfTEukd2ImxaYLTDl944n0Z64JXi6OSPujqvYFetMb0AgDTFb CONKuhfdV3v70up+EzZf3Db1d3KkodBsCZfcV0/tLDzrJjBI7Zi4N5rnIcR7sppu1Ala eeZjUiMvLQ1SkQccsb32Bkn4IezxGAHNhbB7l1mOTSRLbvCaOiLv+LsZB2QNpiO9Vhkn y6CF57KR7YLAtKos5cYm8+W+2dMzL5Pd1bV4icwwjzHK8M8qSPdQyPCQ+qxKlUsPR9wJ XmNQ== X-Gm-Message-State: ABy/qLYyKFKTiiEXDU83MTj2kU1I5BQMpLcriswhcOPbvS5yryTPfSIH v8w10/a30pGcSqswV8rflN1Yt0Da1pU= X-Received: by 2002:a2e:94d7:0:b0:2b6:dd78:2a8e with SMTP id r23-20020a2e94d7000000b002b6dd782a8emr7876829ljh.50.1688559925743; Wed, 05 Jul 2023 05:25:25 -0700 (PDT) Received: from localhost.localdomain ([2a00:1d50:3:0:7978:6149:c084:56b2]) by smtp.gmail.com with ESMTPSA id u2-20020a2e9f02000000b002b6e121cf1fsm2445503ljk.4.2023.07.05.05.25.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Jul 2023 05:25:25 -0700 (PDT) From: Lev Stipakov To: openvpn-devel@lists.sourceforge.net Date: Wed, 5 Jul 2023 15:25:28 +0300 Message-Id: <20230705122528.1625-1-lstipakov@gmail.com> X-Mailer: git-send-email 2.38.1.windows.1 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "util-spamd-2.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Lev Stipakov By default CMake links C runtime dynamically, which doesn't work on Windows 7, for example. This is not an issue with other openvpn binaries, since we bundle C runtime, but it is not yet available during installation. Content analysis details: (-0.2 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [lstipakov[at]gmail.com] -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.208.173 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.208.173 listed in wl.mailspike.net] -0.0 T_SCC_BODY_TEXT_LINE No description available. X-Headers-End: 1qH1Zd-0003qy-0V Subject: [Openvpn-devel] [PATCH v2] openvpnmsica: link C runtime statically X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lev Stipakov Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1769940429016002646?= X-GMAIL-MSGID: =?utf-8?q?1770583453786280594?= From: Lev Stipakov By default CMake links C runtime dynamically, which doesn't work on Windows 7, for example. This is not an issue with other openvpn binaries, since we bundle C runtime, but it is not yet available during installation. Change-Id: Ib2b014f075908e7db0d9115abaa2240e47fd27b9 Signed-off-by: Lev Stipakov Acked-by: Frank Lichtenheld --- v2: fix MinGW build (apply changes to MSVC only) src/openvpnmsica/CMakeLists.txt | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/openvpnmsica/CMakeLists.txt b/src/openvpnmsica/CMakeLists.txt index 683d38e0..9126b80f 100644 --- a/src/openvpnmsica/CMakeLists.txt +++ b/src/openvpnmsica/CMakeLists.txt @@ -26,6 +26,14 @@ target_compile_options(openvpnmsica PRIVATE -UNTDDI_VERSION -D_WIN32_WINNT=_WIN32_WINNT_VISTA ) + +if (MSVC) + target_compile_options(openvpnmsica PRIVATE + "$<$:/MT>" + "$<$:/MTd>" + ) +endif () + target_link_libraries(openvpnmsica advapi32.lib ole32.lib msi.lib setupapi.lib iphlpapi.lib shell32.lib shlwapi.lib version.lib newdev.lib) if (MINGW)