From patchwork Thu Jul 6 17:19:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Heiko Hund X-Patchwork-Id: 3275 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7300:1496:b0:d7:3b0f:3938 with SMTP id b22csp659311dyh; Thu, 6 Jul 2023 10:20:14 -0700 (PDT) X-Google-Smtp-Source: APBJJlEKC8bnjOkyf2ceco1do4e9Ve4RdLshnUCqQD378xPj1C6YAFUWTVvo9vMVv58dehDpYZVS X-Received: by 2002:a17:902:d4ce:b0:1b8:7e53:70f with SMTP id o14-20020a170902d4ce00b001b87e53070fmr3230489plg.27.1688664013668; Thu, 06 Jul 2023 10:20:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688664013; cv=none; d=google.com; s=arc-20160816; b=e2Z0FZ9Hax8lpz6JYEZMtBJ9pHn0xkCMhudKxqtWFMtCC+rM49veFNNn3j83ISijnp pASD2y/gULG7Mk0UbAoZxnOJQAzcj7RzhYaCHccu5sMD1FhAt/+SJQkYiP8J6qIr1HZg VpQeZPDvcalkj21SVoBKewmmFwa+sRuEHHlLkmfzsL+JfTvxseeHdz4D6xQXOpKIfNic KWdpG5e8gf0Ky0H5uxfxA8wzvlMfrPmlttz1KTVpCA76RsUDF2JUMwODk85NMdakF1dw nSE0l73ZdhNw/F6pkYZVoE8sVULYbc/CGaRBSITtrTrKShEEexCsFnRdjrdRJ5DWFwNF RLaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:message-id:date:to:from:dkim-signature:dkim-signature; bh=Sy7J13o7JssFeMhzLBwccCYT2ntM8RDAFAsC0n3OT1g=; fh=LgkM68476GG6lLhdBVILP8BnhrCv3k/uvrCJyvC5LQE=; b=Tg28/l4pKRx/OBIYtJ3k9E6tD3KKKclhk6SMKYy7oZrK47k4R285pBl9ptfD40Hgyp ImmhM4px5r84sf14uGDInYosFg+kWbTyJou0prZZNuGzSQqfs702z8rIJmkxl9g6RToQ fet2J26r1unoJQAlXBpAJTiKROmIHDJ1cFqk7exIaoZ50vPmhAgZV5g8tzsAwT1Xn4jA F2VXpF/Uw9UTbs0v4Y9SE9v8V5jS4jtd3/po7hNkHPAd2s1wGMOwKFPB8haP06+VTzPc bsfe8I5UvmEoolw8wKJt1bZz7VUVDhcmZ/LBqMy0WQhzTp15+rUhVS1kfpjbEIfLeU1w f46Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=bsx2U0GB; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=LfCfkzUX; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id h6-20020a170902680600b001b8bced401dsi1756304plk.198.2023.07.06.10.20.13 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 06 Jul 2023 10:20:13 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=bsx2U0GB; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=LfCfkzUX; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1qHSdq-0003FA-Pq; Thu, 06 Jul 2023 17:19:43 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1qHSdo-0003F4-2r for openvpn-devel@lists.sourceforge.net; Thu, 06 Jul 2023 17:19:40 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:MIME-Version :Message-Id:Date:Subject:To:From:Sender:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=A3Wh5Ui0osuXao+O3n8lmwq0T/oC/CN+Eboxq82Vyas=; b=bsx2U0GByyY+CVMAs5yhyoT/42 lejhzThbb3eMcJ6LIkm/nI6LXO+83mHKxr38CQ+5rkCiMrVgYJI0P5VZKyf2MEFU9UkaLG3MJw1hB rvXquWH3MYh6USqzt+N6J1AtajP0mB7TjJJmcGSU3j7C3LuO4DBIhDilWEBejlmf2zWE=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-Id:Date: Subject:To:From:Sender:Reply-To:Cc:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=A3Wh5Ui0osuXao+O3n8lmwq0T/oC/CN+Eboxq82Vyas=; b=L fCfkzUXtGCAHP5IkBvABkawuXzgcAZ57AjR6gvyeaiLhFo8rqVfGTJzTZIW65infmKoWEe6dTAZJG w1VqPI+4amXjbS+/Z5pp1TzSgmG2bJGFGhroAj06ZoIU0O2rVyj/Gp3KX9vQt61xa086VECnmCgWq vQRNVJmxp/6JIxpM=; Received: from exit0.net ([85.25.119.185]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1qHSdm-0002tx-Gc for openvpn-devel@lists.sourceforge.net; Thu, 06 Jul 2023 17:19:40 +0000 Received: from coruscant.fritz.box (i6DFA212E.versanet.de [109.250.33.46]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by exit0.net (Postfix) with ESMTPSA id C487664800FA for ; Thu, 6 Jul 2023 19:19:28 +0200 (CEST) From: Heiko Hund To: openvpn-devel@lists.sourceforge.net Date: Thu, 6 Jul 2023 19:19:22 +0200 Message-Id: <20230706171922.752429-1-heiko@ist.eigentlich.net> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-Spam-Score: 0.2 (/) X-Spam-Report: =?unknown-8bit?q?Spam_detection_software=2C_running_on_the_sy?= =?unknown-8bit?q?stem_=22util-spamd-2=2Ev13=2Elw=2Esourceforge=2Ecom=22=2C?= =?unknown-8bit?q?_has_NOT_identified_this_incoming_email_as_spam=2E__The_ori?= =?unknown-8bit?q?ginal?= =?unknown-8bit?q?_message_has_been_attached_to_this_so_you_can_view_it_or_la?= =?unknown-8bit?q?bel?= =?unknown-8bit?q?_similar_future_email=2E__If_you_have_any_questions=2C_see?= =?unknown-8bit?q?_the_administrator_of_that_system_for_details=2E?= =?unknown-8bit?q?_?= =?unknown-8bit?q?_Content_preview=3A__When_cross_compiling_for_Windows_with_?= =?unknown-8bit?q?Ubuntu_23=2E04_mingw_complains?= =?unknown-8bit?b?IGFib3V0IHJvdXRlLmM6MzQ0OjI2OiB3YXJuaW5nOiDigJhzcGVjaWFs?= =?unknown-8bit?b?LlNfdW4uU19hZGRy4oCZIG1heSBiZSB1c2VkIHVuaW5pdGlhbGl6ZWQ=?= =?unknown-8bit?q?_which_is_wrong_technically=2E_However_the_workaround_isn?= =?unknown-8bit?q?=27t_really_intrusive?= =?unknown-8bit?q?_and_while_there_are_other_warnings_caused_by_libtool=2C_th?= =?unknown-8bit?q?e_cmake_mingw_build?= =?unknown-8bit?q?_completes_with_-Werror_now=2E_?= =?unknown-8bit?q?_?= =?unknown-8bit?q?_Content_analysis_details=3A___=280=2E2_points=2C_6=2E0_req?= =?unknown-8bit?q?uired=29?= =?unknown-8bit?q?_?= =?unknown-8bit?q?_pts_rule_name______________description?= =?unknown-8bit?q?_----_----------------------_------------------------------?= =?unknown-8bit?q?--------------------?= =?unknown-8bit?q?_-0=2E0_SPF=5FPASS_______________SPF=3A_sender_matches_SPF_?= =?unknown-8bit?q?record?= =?unknown-8bit?q?_0=2E2_HEADER=5FFROM=5FDIFFERENT=5FDOMAINS_From_and_Envelop?= =?unknown-8bit?q?eFrom_2nd_level?= =?unknown-8bit?q?_mail_domains_are_different?= =?unknown-8bit?q?_-0=2E0_SPF=5FHELO=5FPASS__________SPF=3A_HELO_matches_SPF_?= =?unknown-8bit?q?record?= =?unknown-8bit?q?_-0=2E0_T=5FSCC=5FBODY=5FTEXT=5FLINE___No_description_avail?= =?unknown-8bit?q?able=2E?= X-Headers-End: 1qHSdm-0002tx-Gc Subject: [Openvpn-devel] [PATCH] work around false positive warning with mingw 12 X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1770692556595531107?= X-GMAIL-MSGID: =?utf-8?q?1770692556595531107?= When cross compiling for Windows with Ubuntu 23.04 mingw complains about route.c:344:26: warning: ‘special.S_un.S_addr’ may be used uninitialized which is wrong technically. However the workaround isn't really intrusive and while there are other warnings caused by libtool, the cmake mingw build completes with -Werror now. Change-Id: I8a0f59707570722eab41af2db76980ced04e6d54 Signed-off-by: Heiko Hund Acked-By: Arne Schwabe --- src/openvpn/route.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/openvpn/route.c b/src/openvpn/route.c index 0d04a5a3..0b369da4 100644 --- a/src/openvpn/route.c +++ b/src/openvpn/route.c @@ -319,7 +319,7 @@ init_route(struct route_ipv4 *r, const in_addr_t default_netmask = IPV4_NETMASK_HOST; bool status; int ret; - struct in_addr special; + struct in_addr special = {0}; CLEAR(*r); r->option = ro;