diff mbox series

[Openvpn-devel] manage.c: document missing KID parameter

Message ID 20230714111802.1773-1-lstipakov@gmail.com
State Accepted
Headers show
Series [Openvpn-devel] manage.c: document missing KID parameter | expand

Commit Message

Lev Stipakov July 14, 2023, 11:18 a.m. UTC 
From: Lev Stipakov <lev@openvpn.net>

Commit a261e173 ("Make sending plain text control message session
aware") added KID parameter to "client-pending-auth" management command,
but forgot to mention it in the output of management help.

Change-Id: I201bdaa5fe4020d15a9dd1674aba5e0c45170731
Signed-off-by: Lev Stipakov <lev@openvpn.net>
---
 src/openvpn/manage.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Arne Schwabe July 14, 2023, 11:21 a.m. UTC | #1 
Am 14.07.23 um 13:18 schrieb Lev Stipakov:
> From: Lev Stipakov <lev@openvpn.net>
> 
> Commit a261e173 ("Make sending plain text control message session
> aware") added KID parameter to "client-pending-auth" management command,
> but forgot to mention it in the output of management help.

My fault.

Acked-By: Arne Schwabe <arne@rfc2549.org>
Gert Doering July 17, 2023, 4:39 p.m. UTC | #2 
Since this is a pure textual change, I haven't tested this any way -
and the change matches "Changes.rst" and "doc/management-notes.txt".

Your patch has been applied to the master and release/2.6 branch.

commit f5201eedd4ea55414bf8310668a3d00e7bf8ea71 (master)
commit d3fe78af5dde169fcb13a6fde3b532e5d1a3a633 (release/2.6)
Author: Lev Stipakov
Date:   Fri Jul 14 14:18:02 2023 +0300

     manage.c: document missing KID parameter

     Signed-off-by: Lev Stipakov <lev@openvpn.net>
     Acked-by: Arne Schwabe <arne@rfc2549.org>
     Message-Id: <20230714111802.1773-1-lstipakov@gmail.com>
     URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg26856.html
     Signed-off-by: Gert Doering <gert@greenie.muc.de>


--
kind regards,

Gert Doering
diff mbox series

Patch

diff --git a/src/openvpn/manage.c b/src/openvpn/manage.c
index d80f9ffd..739ed40f 100644
--- a/src/openvpn/manage.c
+++ b/src/openvpn/manage.c
@@ -106,7 +106,7 @@  man_help(void)
     msg(M_CLIENT, "client-auth-nt CID KID : Authenticate client-id/key-id CID/KID");
     msg(M_CLIENT, "client-deny CID KID R [CR] : Deny auth client-id/key-id CID/KID with log reason");
     msg(M_CLIENT, "                             text R and optional client reason text CR");
-    msg(M_CLIENT, "client-pending-auth CID MSG timeout : Instruct OpenVPN to send AUTH_PENDING and INFO_PRE msg");
+    msg(M_CLIENT, "client-pending-auth CID KID MSG timeout : Instruct OpenVPN to send AUTH_PENDING and INFO_PRE msg");
     msg(M_CLIENT, "                                      to the client and wait for a final client-auth/client-deny");
     msg(M_CLIENT, "client-kill CID [M]    : Kill client instance CID with message M (def=RESTART)");
     msg(M_CLIENT, "env-filter [level]     : Set env-var filter level");