[Openvpn-devel] GHA: do not trigger builds in openvpn-build anymore

Message ID 20230922103936.37230-1-frank@lichtenheld.com
State Accepted
Headers show
Series [Openvpn-devel] GHA: do not trigger builds in openvpn-build anymore | expand

Commit Message

Frank Lichtenheld Sept. 22, 2023, 10:39 a.m. UTC
We do this via explicit PRs now, generated by renovate.
This allows much better control over what state of the
code gets built.

Change-Id: I8b00d7d79a26ad4aaae529cb496e125398169b50
Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
Acked-by: Lev Stipakov <lstipakov@gmail.com>
---

This change was reviewed on Gerrit and approved by at least one
developer. I request to merge it to master.

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/328
This mail reflects revision 1 of this Change.
Acked-by according to Gerrit (reflected above):
lstipakov <lstipakov@gmail.com>

Comments

Gert Doering Sept. 22, 2023, 12:08 p.m. UTC | #1
.. as discussed on the list and on IRC, yes.

Your patch has been applied to the master and release/2.6 branch.

commit 1864a19e85d89bc0b34cb1c6eac186f3fe323c0b (master)
commit cd09e073752fbad5d70adc2af66a29c7ed99a9e9 (release/2.6)
Author: Frank Lichtenheld
Date:   Fri Sep 22 12:39:36 2023 +0200

     GHA: do not trigger builds in openvpn-build anymore

     Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
     Acked-by: Lev Stipakov <lstipakov@gmail.com>
     Message-Id: <20230922103936.37230-1-frank@lichtenheld.com>
     URL: https://www.mail-archive.com/search?l=mid&q=20230922103936.37230-1-frank@lichtenheld.com
     Signed-off-by: Gert Doering <gert@greenie.muc.de>


--
kind regards,

Gert Doering
Gert Doering Sept. 22, 2023, 12:10 p.m. UTC | #2
.. as discussed on the list and on IRC, yes.

*second attempt*, fixing the URL: in both commits, so new commit IDs...

Your patch has been applied to the master and release/2.6 branch.

commit 37d6c61a3decf64d0db1cd3d033483c9db5c4c91 (master)
commit 1782daa48e782469550e37e7cd7dab2ba4e4be8b (HEAD -> release/2.6)
Author: Frank Lichtenheld
Date:   Fri Sep 22 12:39:36 2023 +0200

     GHA: do not trigger builds in openvpn-build anymore

     Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
     Acked-by: Lev Stipakov <lstipakov@gmail.com>
     Message-Id: <20230922103936.37230-1-frank@lichtenheld.com>
     URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg27060.html
     Signed-off-by: Gert Doering <gert@greenie.muc.de>


--
kind regards,

Gert Doering

Patch

diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml
index 1b75a1a..58fbc29 100644
--- a/.github/workflows/build.yaml
+++ b/.github/workflows/build.yaml
@@ -290,19 +290,6 @@ 
             !${{ github.workspace }}/out/**/CMakeFiles/**
             !${{ github.workspace }}/out/**/vcpkg_installed/**
 
-  trigger_openvpn_build:
-    runs-on: windows-latest
-    needs: [checkuncrustify, mingw, ubuntu, ubuntu-clang-asan, macos, msvc]
-    if: ${{ github.event_name != 'pull_request' && github.repository == 'openvpn/openvpn' && github.ref == 'refs/heads/master' }}
-
-    steps:
-    - name: Repository Dispatch
-      uses: peter-evans/repository-dispatch@v2
-      with:
-        token: ${{ secrets.OPENVPN_BUILD_REPO_DISPATCH }}
-        repository: openvpn/openvpn-build
-        event-type: openvpn-commit
-
   libressl:
     strategy:
       fail-fast: false