From patchwork Mon Oct 9 10:57:14 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Lichtenheld X-Patchwork-Id: 3389 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7300:b412:b0:f2:62eb:61c1 with SMTP id dj18csp1948222dyb; Mon, 9 Oct 2023 03:57:50 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGW9qgp9g1AK9ICmXeDiCNwQ8Rbo68wQhCck1zpE2WgLjUiwFMp4o6RTjQsML1y0lrsdJLI X-Received: by 2002:a05:6870:972c:b0:1b7:5e47:5b75 with SMTP id n44-20020a056870972c00b001b75e475b75mr16047260oaq.4.1696849070319; Mon, 09 Oct 2023 03:57:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696849070; cv=none; d=google.com; s=arc-20160816; b=oITat21rmrk1M1Ob3U38Z+xB/0Mww0kGbj5X8Mf18O5tcrGCYJDh4fPidsf2RJDZev 3J51OrrXLbl8Mt0XRDKs/ADsp4rhHunVOXuPe0sgqrccrACozaTxzGXzKxWThG7Wq5hl F3drzQcRH2gIvd50RsE4vG+tHkb3TN35ufg3Quhet/MrnKKEr3IBFPBHMHWP5vHWd2Gf doOJMwfZ96fiBCR17rSyZKEKNuVYkm78p3/3bIbAac0zCEIlC1Ao6N0iz3TfnHrk+bWl UQwVmB0ZyHcttnE8PFGbqWxcjGkCayu6QFG171jPNWCQ59EsdDUTvv9Cu13uKlV1x7V2 MZ7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=l26AxuWOQCvcRkTNhkC6WX4Git9KwznQfQoHP4zPVyE=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=PEUnmh8mPaZCj1d7lvHQdEmOs2sn+T6/5InD8/RPlh+CCAacCiDo4HVQNoOHrDl8QB /eE6TZpQf8AI4pVksFuJbxad/taiSKAiR0fb632/QHibZckxpa/xNNqi4CRYlhwzeAHH BfGleZuNN1pZWBk+Qf1KUiU6UYRtCupdlLrN+7UUtdjqHsVfblyjfb6FW1LYsXsa0a04 rA/TLYrSWxZbBfTJZqaJna9X1WZzrZLnt8CWGAxKzDbsDdi/NAnxZkUM9meVLuhUE2X2 Obh3yrt9IfNV8rid7JM6O+EMl7kyhGS6AfDJGT44fBffYyCpsDdyGqS8cpbG8f96BWnq Dhjg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=QQCGcg+A; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=RlK30jPC; dkim=neutral (body hash did not verify) header.i=@lichtenheld.com header.s=MBO0001 header.b=zgLnMFGb; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id g25-20020a62e319000000b0069026fd5a31si6683786pfh.272.2023.10.09.03.57.50 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 09 Oct 2023 03:57:50 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=QQCGcg+A; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=RlK30jPC; dkim=neutral (body hash did not verify) header.i=@lichtenheld.com header.s=MBO0001 header.b=zgLnMFGb; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1qpnx4-000582-8O; Mon, 09 Oct 2023 10:57:30 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1qpnx1-00057t-Jc for openvpn-devel@lists.sourceforge.net; Mon, 09 Oct 2023 10:57:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=WvethmtmGZHiHN6xBLZR6gdq3MTLFPzQmtUMmQIW1E4=; b=QQCGcg+AbXeExoBb4P2//VhFz7 YkvORB1ARxHjz+vr/Fo2a0H2uSW34KVZa5z30+0kmPJcQWwT9Jr+RvM/FTBxGYW4rkYnZ4Khuqq08 zvlukSH6clf5IodDIG0IHTCUMm6Iecq9CSIKsq/ougOCI2m4N9LPHrvChKpBCxAN8Sgc=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-Id: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=WvethmtmGZHiHN6xBLZR6gdq3MTLFPzQmtUMmQIW1E4=; b=RlK30jPCp3dJoADWDoibQMAHEk nfPwquk+bKSsKlp/MhlDa1lPfXM3GWEedeuCNWTpfQj/jsttLCf+xsuayhI6H6Ra/3DmthdjLFH3Z 8nzkU7qWK0xZxuMQ2xBAVWs3zgYpyxcPY/U8UFuTLWR1jzTDckZ4GoqlJ9rCGC9RKBOM=; Received: from mout-p-201.mailbox.org ([80.241.56.171]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1qpnwz-008K8h-Mg for openvpn-devel@lists.sourceforge.net; Mon, 09 Oct 2023 10:57:27 +0000 Received: from smtp1.mailbox.org (smtp1.mailbox.org [10.196.197.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-201.mailbox.org (Postfix) with ESMTPS id 4S3wwC4Wplz9sW3; Mon, 9 Oct 2023 12:57:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lichtenheld.com; s=MBO0001; t=1696849035; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WvethmtmGZHiHN6xBLZR6gdq3MTLFPzQmtUMmQIW1E4=; b=zgLnMFGbQASl7+eeyzoB+Bf6fuOpwTdz3y28aSTh9IVfcHn2kCkI0YEX+Dxhsizs0Lwyyo PZwKvlH0swG4A4Pf7y8Pj1gDHoYNfqoKPGwigqog2cbcaSQl1qwVQlvEF0qeH5Otl2IQT1 cQWfdUBX6pVx0pk+gnBv7+mqGWz6uGKg3grK7a+rBDj1rI0J7H9xP5c9Eg6hSuxiOX/pjL QOEIoQVR979nQtBwBFGRqfE4gui8FQObLBMNd7P0NEuV13/t8KhxhCzUJPgrpHT17n0yAe ZK7SmZM6+rb15D6lVYe4IQ/tioGnBJDgoN9ZNJGFgiBRM/kxDIR70uo+SnKrow== From: Frank Lichtenheld To: openvpn-devel@lists.sourceforge.net Date: Mon, 9 Oct 2023 12:57:14 +0200 Message-Id: <20231009105714.34598-1-frank@lichtenheld.com> In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: -0.9 (/) X-Spam-Report: Spam detection software, running on the system "util-spamd-2.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Arne Schwabe OpenSSL has a weird way of only reporting EC curves that are implemented in a certain way in the list of all EC curves. Note this fact and point out that also the very important curves X448 and X25519 [...] Content analysis details: (-0.9 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 RCVD_IN_MSPIKE_H5 RBL: Excellent reputation (+5) [80.241.56.171 listed in wl.mailspike.net] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [80.241.56.171 listed in list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-Headers-End: 1qpnwz-008K8h-Mg Subject: [Openvpn-devel] [PATCH] Add warning for the --show-groups command that some groups are missing X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1779275210522488263?= X-GMAIL-MSGID: =?utf-8?q?1779275210522488263?= From: Arne Schwabe OpenSSL has a weird way of only reporting EC curves that are implemented in a certain way in the list of all EC curves. Note this fact and point out that also the very important curves X448 and X25519 are affected. Change-Id: I86641bf60d62a50e9b2719e809d2429d65c00097 Acked-by: Frank Lichtenheld --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Note: I fixed some typos on-the-fly. See my comments in Gerrit for details. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/366 This mail reflects revision 7 of this Change. Acked-by according to Gerrit (reflected above): Frank Lichtenheld diff --git a/src/openvpn/ssl_openssl.c b/src/openvpn/ssl_openssl.c index 686ecf7..2b3f4f4 100644 --- a/src/openvpn/ssl_openssl.c +++ b/src/openvpn/ssl_openssl.c @@ -2359,8 +2359,10 @@ void show_available_curves(void) { - printf("Consider using openssl 'ecparam -list_curves' as\n" - "alternative to running this command.\n"); + printf("Consider using 'openssl ecparam -list_curves' as alternative to running\n" + "this command.\n" + "Note this output does only list curves/groups that OpenSSL considers as\n" + "builtin EC curves. It does not list additional curves nor X448 or X25519\n"); #ifndef OPENSSL_NO_EC EC_builtin_curve *curves = NULL; size_t crv_len = 0;