From patchwork Tue Nov 7 14:17:55 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Lichtenheld X-Patchwork-Id: 3417 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7300:7987:b0:f2:62eb:61c1 with SMTP id a7csp266895dyi; Tue, 7 Nov 2023 06:19:14 -0800 (PST) X-Google-Smtp-Source: AGHT+IHGh3GGOj2U7JkjhM72Fb92iIFbXOl57V5IV2+dPxYDFOooCXGBl7z/S73eTMD7HjaZoneI X-Received: by 2002:a05:6871:646:b0:1e9:b49b:8d7e with SMTP id x6-20020a056871064600b001e9b49b8d7emr39413178oan.0.1699366754737; Tue, 07 Nov 2023 06:19:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699366754; cv=none; d=google.com; s=arc-20160816; b=HRDq//tLTyL9I1LnILUtU6aZqqTGAqUeuGE+ViN6hgARp8VMV/fJ2lFvKekOm1gP6d anfR5KNY459RV41TaU8GjhlqWN7/NDim8mcD41Gc2K+P04LQOhPesPI186GqnMSSRhnk 15MVyMx8ss6X15xunUiYNtjGluI1xuzSqG+K1Iw2DHZIYiNdIQPk07suky2E532jMEyN 1fAXgodOGdLmQg+69igvRBooewaHLqbaCmYK+IPiG33CgOGnd5rP0K1ltCz1m2vJoIil 4z/PolmAdRdjo1iyfDAJLUJOuYJOqNogUpxfQCN4JFpSKsmUIH2sPCGyGe9vJ0J7KpwD YiYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=ZPzMg1E1r3lsbggkXW/CGq/VHVaJ+dpO7fhg4whSlRs=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=Bj7MTm5M1exoB5+TRlh0HRBe7A1gfT1nCfzKYWxqZuxsr95O404u6X6whFANxwprHR CbIR1L2wQCxTz23aWfhzUfj/Q/Axlnuw8m4YAY8nogyyHfqKqRAXrL/14mBFSsMITwjO S4C/2pz26v/jMLlLlRZJZleTFnaV0fugt388WXVjBzXPBubKjGcsVcDANGK2+G8r4+vk fJlBDbnSTpry5sHGxUMAdpF+NSRp3hijv3u1EELSOQhKkHSo3+bo9JAKQgSXVG7HgRKb k0mIHMvDkzm9qlC7hJLrXaOySj4gjwYakmrVQ0QZ/aMUgSWvf+8MMOoarcCV3HzwLQ5d z/pQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=B9cj+Z71; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=dAgb8VKA; dkim=neutral (body hash did not verify) header.i=@lichtenheld.com header.s=MBO0001 header.b=m7kKX3tc; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id ay5-20020a056a00300500b006c31b7dd73fsi10904286pfb.288.2023.11.07.06.19.14 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 07 Nov 2023 06:19:14 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=B9cj+Z71; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=dAgb8VKA; dkim=neutral (body hash did not verify) header.i=@lichtenheld.com header.s=MBO0001 header.b=m7kKX3tc; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1r0MuH-0007R3-DD; Tue, 07 Nov 2023 14:18:17 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1r0MuF-0007Qr-Kn for openvpn-devel@lists.sourceforge.net; Tue, 07 Nov 2023 14:18:15 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=mtI0tUOaFVRRd31ETk9o0mU559kZXnSMyixrN8akE8I=; b=B9cj+Z71uD9+D+w/uLt9xaxzox KAxmBBhP/LBc9XGpKmjxIYGaA3CVrgHq/fuQJE5ahVOkW4YOu5chJlndFoC+m5qpzdcH/C7PYaTPV N80p5s0d3S2V5Isi+0ihNmJ/ZS8IrAZQ0PR9YRd7qooY5NZIIIckK3QoZKdRHNLHFJsU=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-Id: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=mtI0tUOaFVRRd31ETk9o0mU559kZXnSMyixrN8akE8I=; b=dAgb8VKAK2LrFSEwbMU5lNzW04 +8/z4IUkaAAFlj5LigFhJ6qXMUC+GY6XQ34HXW0O/fxjQaPEc2RUQkIfl/h3LY8mZsZJyvC8GmoX+ 1XZ8viD2bWFsI7vGR8bfVuPNksfpMh+/d8ZomnIn5FD3bsOn2Bv/jZiec/EloCIYLwsQ=; Received: from mout-p-102.mailbox.org ([80.241.56.152]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1r0Mu9-00024d-Dw for openvpn-devel@lists.sourceforge.net; Tue, 07 Nov 2023 14:18:15 +0000 Received: from smtp202.mailbox.org (smtp202.mailbox.org [10.196.197.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-102.mailbox.org (Postfix) with ESMTPS id 4SPr0P4gPPz9sWk; Tue, 7 Nov 2023 15:17:57 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lichtenheld.com; s=MBO0001; t=1699366677; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mtI0tUOaFVRRd31ETk9o0mU559kZXnSMyixrN8akE8I=; b=m7kKX3tcukZpQaoK1GURgvIfuUNTBkxEWMTv3JL3CQgmk6mpDTQqK+wtL72yc9J0iteaeE wTc0ozEXmGV76UvHb+7nPK7TD3j04v3XsRSmVznA0w+WVuXc1Xdjx6SO9ZXTlIR5Df+ETl IYTCkeN22mJh5uNWqtjKxjmqshvExCBI9OINb03RK9+36pWw6Xpfcu0jQiAYrW/B7tFuKN 6zj+uDo0CJlfMPOJ2RjfTmWrytoqLC7HY/EyPIdoyy9f3kOsOs74ub3F/EsMNoOjWtVJoI x5LA3s5ZBnOulzO4AvVEWmGA6JbS5cDcpIH/gcQmO4XYex3G3EdXhWrXvNYy7g== From: Frank Lichtenheld To: openvpn-devel@lists.sourceforge.net Date: Tue, 7 Nov 2023 15:17:55 +0100 Message-Id: <20231107141755.30559-1-frank@lichtenheld.com> In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: -0.9 (/) X-Spam-Report: Spam detection software, running on the system "util-spamd-2.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Arne Schwabe This overwrites the default that cmake automatically sets. In the case of debug builds, this breaks debugging as -O1 already optimises many variables away. Change-Id: I3ca6965799b23d542ababc3e38880317cb46a3ac Acked-by: Frank Lichtenheld --- Content analysis details: (-0.9 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [80.241.56.152 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.0 T_SCC_BODY_TEXT_LINE No description available. X-Headers-End: 1r0Mu9-00024d-Dw Subject: [Openvpn-devel] [PATCH v1] Remove CMake custom compiler flags for RELEASE and DEBUG build X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1781915193903945539?= X-GMAIL-MSGID: =?utf-8?q?1781915193903945539?= From: Arne Schwabe This overwrites the default that cmake automatically sets. In the case of debug builds, this breaks debugging as -O1 already optimises many variables away. Change-Id: I3ca6965799b23d542ababc3e38880317cb46a3ac Acked-by: Frank Lichtenheld --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/374 This mail reflects revision 1 of this Change. Acked-by according to Gerrit (reflected above): Frank Lichtenheld diff --git a/CMakeLists.txt b/CMakeLists.txt index 376a060..d21c9bd 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -79,10 +79,6 @@ add_link_options("$<$:/CETCOMPAT>") endif() else () - set(CMAKE_C_FLAGS_RELEASE "-O2") - set(CMAKE_CXX_FLAGS_RELEASE "-O2") - set(CMAKE_C_FLAGS_DEBUG "-g -O1") - set(CMAKE_CXX_FLAGS_DEBUG "-g -O1") add_compile_options(-Wall -Wuninitialized) check_c_compiler_flag(-Wno-stringop-truncation NoStringOpTruncation)