| Message ID | 20231121104037.15307-1-frank@lichtenheld.com |
|---|---|
| State | Accepted |
| Headers |
Return-Path: <openvpn-devel-bounces@lists.sourceforge.net>
Delivered-To: patchwork@openvpn.net
Received: by 2002:a05:7300:53c1:b0:f2:62eb:61c1 with SMTP id u1csp270297dye;
Tue, 21 Nov 2023 02:41:06 -0800 (PST)
X-Google-Smtp-Source:
AGHT+IGi2dq6ygXkHp3NMSVRSYJhdk4dDM1Lp5njzGZi6lCac8Na0u+42yqUGkNhkwM3powM2gi+
X-Received: by 2002:a05:6a20:8e27:b0:186:10ae:152a with SMTP id
y39-20020a056a208e2700b0018610ae152amr13977775pzj.4.1700563266658;
Tue, 21 Nov 2023 02:41:06 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1700563266; cv=none;
d=google.com; s=arc-20160816;
b=DrADRKJxn/btyiqwGHCDK0FD6CoB2XmMXf6SyUIAFUiTrl8VVHQ2PAExYAEuTD+Rm1
wFrO/Mm+WN/M7JPhV9tJ70pm65K4Zxfa+8gZasv7gcocEE1oPbjbBOGMSgnVT/xjdEc/
FZszKx0TXxo44Zx3f7zqYp4y6vxIiVcliFHcB7fWnld5vnvklSbY3Zm09rmW9WbtO+Cp
ahsDOqZ/jeZheV5HwAuiCvYMUtMezKV65hkztAQiVrpUBp7AkaHWlIo4d3w5E0T00OSG
8vyymzBomwe4lZkyMRMvuuRrriPfXxzQB04pLksoaGHMne0IY0aXLA6ynydKlE/cIafh
s1mQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=errors-to:content-transfer-encoding:list-subscribe:list-help
:list-post:list-archive:list-unsubscribe:list-id:precedence:subject
:mime-version:references:in-reply-to:message-id:date:to:from
:dkim-signature:dkim-signature:dkim-signature;
bh=7c3V9nFsup50menJA4skKJWvI6KKLIdoXeo8JKv4TAk=;
fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=;
b=Ym1NKW9Jq/GdmK6fN3px69r0uBELT0eLdNlwV9o+JojlokK7uESBomyE5TyRqE09oC
sjOUbxtuPx8mTdQDEClTQztdIu09Lq6frPy0wvVBUucUons+XPsO/hbd/d96UIWH1m27
NZYZUPgRyIB9yuqJGUp8wh2tNhLM1oWbL5ezUAt8gV2rM6RFWLro9CW8KqXqExs4zmx4
5Ys4cxevuBqwHxmKozrQ2ngbsakrsu1Y7L7z41yUaDQeyg0kbuaChkbm2MhSyVXa6SCw
hFFUOZyHcKmKUM9yRdcAV6hzKwBmJQvQjWNbeJ1CreHoM9qisc8M07mxhguL6BPOsJpW
3ewg==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=neutral (body hash did not verify) header.i=@sourceforge.net
header.s=x header.b=BAYNwu1s;
dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x
header.b=PnSpuWqP;
dkim=neutral (body hash did not verify) header.i=@lichtenheld.com
header.s=MBO0001 header.b=Un51hMNQ;
spf=pass (google.com: domain of
openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as
permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net
Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7])
by mx.google.com with ESMTPS id
s64-20020a625e43000000b006cb651670e1si6020860pfb.77.2023.11.21.02.41.06
(version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
Tue, 21 Nov 2023 02:41:06 -0800 (PST)
Received-SPF: pass (google.com: domain of
openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as
permitted sender) client-ip=216.105.38.7;
Authentication-Results: mx.google.com;
dkim=neutral (body hash did not verify) header.i=@sourceforge.net
header.s=x header.b=BAYNwu1s;
dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x
header.b=PnSpuWqP;
dkim=neutral (body hash did not verify) header.i=@lichtenheld.com
header.s=MBO0001 header.b=Un51hMNQ;
spf=pass (google.com: domain of
openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as
permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net
Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com)
by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95)
(envelope-from <openvpn-devel-bounces@lists.sourceforge.net>)
id 1r5OBV-00041U-5e;
Tue, 21 Nov 2023 10:40:49 +0000
Received: from [172.30.20.202] (helo=mx.sourceforge.net)
by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls
TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95)
(envelope-from <frank@lichtenheld.com>) id 1r5OBT-00041G-MA
for openvpn-devel@lists.sourceforge.net;
Tue, 21 Nov 2023 10:40:47 +0000
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References:
In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:
Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:
Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:
List-Subscribe:List-Post:List-Owner:List-Archive;
bh=j8Ksr9jaeqWHcJlvBYcGAMQ5YLnQMzuilcXaaU4Flds=; b=BAYNwu1sGXL7yolPm5qyt78wEx
eYfne3YXygTySdv8j90RXQB4H+EaNncXEE/6WV2SaluLewAceMlLl8dj5c36cHXx5/LjEgP8VKF8+
Quu9uTg5sd2m4CgCHrwlBqqVzJTPiaAAEIzk5rfwY8oalw1T25umLiSZEYOx7DDy8pt0=;
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x
;
h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-Id:
Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:
Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
List-Post:List-Owner:List-Archive;
bh=j8Ksr9jaeqWHcJlvBYcGAMQ5YLnQMzuilcXaaU4Flds=; b=PnSpuWqP786cKM2USUSq4DBU2H
DJfU/W5IUOgzMRwb4kFKp34NoqaePFlh29JxLqA4D0rLDmQI882Uo6IsU8kWGS7akqTMj4LFEFq3R
fRGS31bZl621WKt+6e8l7JCKg74K3HnathfTT4uozqi561z44rYHJpnHe+po10cVKTYA=;
Received: from mout-p-201.mailbox.org ([80.241.56.171])
by sfi-mx-2.v28.lw.sourceforge.com with esmtps
(TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95)
id 1r5OBS-0001ac-Tw for openvpn-devel@lists.sourceforge.net;
Tue, 21 Nov 2023 10:40:47 +0000
Received: from smtp1.mailbox.org (smtp1.mailbox.org [10.196.197.1])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest
SHA256)
(No client certificate requested)
by mout-p-201.mailbox.org (Postfix) with ESMTPS id 4SZLWB5lvsz9sJ6;
Tue, 21 Nov 2023 11:40:38 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lichtenheld.com;
s=MBO0001; t=1700563238;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:cc:mime-version:mime-version:
content-transfer-encoding:content-transfer-encoding:
in-reply-to:in-reply-to:references:references;
bh=j8Ksr9jaeqWHcJlvBYcGAMQ5YLnQMzuilcXaaU4Flds=;
b=Un51hMNQYyof6+SthS5F/ZKAmnmBifiAvV09FrvHl0GtT07iJ29d0HsQrZwWUq8cUPJi+E
tpnSb1/QpuwthD0OH0xvgyFxJknNrWrXTfyS8i7T9kV85Y2toJg0Pzzrkgx9y1TMpsI9WS
4qqdFfZN4pqPB0qn8OxdDZIx/GbReRjd0dQ7ABicsvAaMlAntwyWKNFQn2/33lcWbnd3W8
SVM/FkA5XidCk94ib57GRlatkTuDWrcWhmXT0fqkCD1Y6EfYMRPzdjavZwNBThj+O2gHvU
GOE4q0xq3XTVFWcGfwoZbwhM2Z33PUhAym0cjMdHUL8JzdpbOV5e1mhQikae6A==
From: Frank Lichtenheld <frank@lichtenheld.com>
To: openvpn-devel@lists.sourceforge.net
Date: Tue, 21 Nov 2023 11:40:37 +0100
Message-Id: <20231121104037.15307-1-frank@lichtenheld.com>
In-Reply-To:
<gerrit.1700480231000.I1141eb7740d8900ed4af0ff5ff52aa3659df99aa@gerrit.openvpn.net>
References:
<gerrit.1700480231000.I1141eb7740d8900ed4af0ff5ff52aa3659df99aa@gerrit.openvpn.net>
MIME-Version: 1.0
X-Spam-Score: -0.9 (/)
X-Spam-Report: Spam detection software,
running on the system "util-spamd-1.v13.lw.sourceforge.com",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: From: Arne Schwabe <arne@rfc2549.org> Change-Id:
I1141eb7740d8900ed4af0ff5ff52aa3659df99aa
Acked-by: Frank Lichtenheld <frank@lichtenheld.com> --- This change was
reviewed
on Gerrit and approved by at least one developer. I request to merge it to
master. Content analysis details: (-0.9 points, 6.0 required)
pts rule name description
---- ----------------------
--------------------------------------------------
-0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/,
low trust [80.241.56.171 listed in list.dnswl.org]
-0.0 SPF_PASS SPF: sender matches SPF record
0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record
-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from
author's domain
-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature
0.1 DKIM_SIGNED Message has a DKIM or DK signature,
not necessarily
valid
-0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from
envelope-from domain
-0.0 T_SCC_BODY_TEXT_LINE No description available.
X-Headers-End: 1r5OBS-0001ac-Tw
Subject: [Openvpn-devel] [PATCH v1] Remove unused function prototype
crypto_adjust_frame_parameters
X-BeenThere: openvpn-devel@lists.sourceforge.net
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: <openvpn-devel.lists.sourceforge.net>
List-Unsubscribe: <https://lists.sourceforge.net/lists/options/openvpn-devel>,
<mailto:openvpn-devel-request@lists.sourceforge.net?subject=unsubscribe>
List-Archive:
<http://sourceforge.net/mailarchive/forum.php?forum_name=openvpn-devel>
List-Post: <mailto:openvpn-devel@lists.sourceforge.net>
List-Help: <mailto:openvpn-devel-request@lists.sourceforge.net?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/openvpn-devel>,
<mailto:openvpn-devel-request@lists.sourceforge.net?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: openvpn-devel-bounces@lists.sourceforge.net
X-getmail-retrieved-from-mailbox: Inbox
X-GMAIL-THRID: =?utf-8?q?1783169827938614080?=
X-GMAIL-MSGID: =?utf-8?q?1783169827938614080?=
|
| Series |
[Openvpn-devel,v1] Remove unused function prototype crypto_adjust_frame_parameters
|
|
Commit Message
Frank Lichtenheld
Nov. 21, 2023, 10:40 a.m. UTC
From: Arne Schwabe <arne@rfc2549.org> Change-Id: I1141eb7740d8900ed4af0ff5ff52aa3659df99aa Acked-by: Frank Lichtenheld <frank@lichtenheld.com> --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/451 This mail reflects revision 1 of this Change. Acked-by according to Gerrit (reflected above): Frank Lichtenheld <frank@lichtenheld.com>
Comments
This was an easy one. Quick local review and test compile, and ship it :-)
Your patch has been applied to the master and release/2.6 branch
(because it really is no actual *code* change at all, and keeping changes
between branches small is desirable).
commit 66f109117649237947e3e5cd33a36f81bde71a2b (master)
commit d25b408db680be0ffc357126cc421231b880f18b (release/2.6)
Author: Arne Schwabe
Date: Tue Nov 21 11:40:37 2023 +0100
Remove unused function prototype crypto_adjust_frame_parameters
Acked-by: Frank Lichtenheld <frank@lichtenheld.com>
Message-Id: <20231121104037.15307-1-frank@lichtenheld.com>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg27524.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>
--
kind regards,
Gert Doering
diff --git a/src/openvpn/crypto.h b/src/openvpn/crypto.h index c5fd253..9255d38 100644 --- a/src/openvpn/crypto.h +++ b/src/openvpn/crypto.h @@ -429,12 +429,6 @@ struct gc_arena *gc); -/** Calculate crypto overhead and adjust frame to account for that */ -void crypto_adjust_frame_parameters(struct frame *frame, - const struct key_type *kt, - bool packet_id, - bool packet_id_long_form); - /** Calculate the maximum overhead that our encryption has * on a packet. This does not include needed additional buffer size *