[Openvpn-devel,v1] Remove unused function prototype crypto_adjust_frame_parameters

Message ID 20231121104037.15307-1-frank@lichtenheld.com
State Accepted
Headers show
Series [Openvpn-devel,v1] Remove unused function prototype crypto_adjust_frame_parameters | expand

Commit Message

Frank Lichtenheld Nov. 21, 2023, 10:40 a.m. UTC
From: Arne Schwabe <arne@rfc2549.org>

Change-Id: I1141eb7740d8900ed4af0ff5ff52aa3659df99aa
Acked-by: Frank Lichtenheld <frank@lichtenheld.com>

This change was reviewed on Gerrit and approved by at least one
developer. I request to merge it to master.

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/451
This mail reflects revision 1 of this Change.
Acked-by according to Gerrit (reflected above):
Frank Lichtenheld <frank@lichtenheld.com>


Gert Doering Nov. 21, 2023, 11:01 a.m. UTC | #1
This was an easy one.  Quick local review and test compile, and ship it :-)

Your patch has been applied to the master and release/2.6 branch
(because it really is no actual *code* change at all, and keeping changes
between branches small is desirable).

commit 66f109117649237947e3e5cd33a36f81bde71a2b (master)
commit d25b408db680be0ffc357126cc421231b880f18b (release/2.6)
Author: Arne Schwabe
Date:   Tue Nov 21 11:40:37 2023 +0100

     Remove unused function prototype crypto_adjust_frame_parameters

     Acked-by: Frank Lichtenheld <frank@lichtenheld.com>
     Message-Id: <20231121104037.15307-1-frank@lichtenheld.com>
     URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg27524.html
     Signed-off-by: Gert Doering <gert@greenie.muc.de>

kind regards,

Gert Doering


diff --git a/src/openvpn/crypto.h b/src/openvpn/crypto.h
index c5fd253..9255d38 100644
--- a/src/openvpn/crypto.h
+++ b/src/openvpn/crypto.h
@@ -429,12 +429,6 @@ 
                          struct gc_arena *gc);
-/** Calculate crypto overhead and adjust frame to account for that */
-void crypto_adjust_frame_parameters(struct frame *frame,
-                                    const struct key_type *kt,
-                                    bool packet_id,
-                                    bool packet_id_long_form);
 /** Calculate the maximum overhead that our encryption has
  * on a packet. This does not include needed additional buffer size