[Openvpn-devel,v1] configure.ac: Remove unused AC_TYPE_SIGNAL macro

Message ID 20231128103740.61160-1-frank@lichtenheld.com
State Accepted
Headers show
Series [Openvpn-devel,v1] configure.ac: Remove unused AC_TYPE_SIGNAL macro | expand

Commit Message

Frank Lichtenheld Nov. 28, 2023, 10:37 a.m. UTC
Recent autoconf warns:
configure.ac:448: warning: The macro `AC_TYPE_SIGNAL' is obsolete.

And it turns out that we do not actually use RETSIGTYPE.
Additionally, there is no reason to do so since as the
autoconf documentation says:
"These days, it is portable to assume C89, and that signal
handlers return void, without needing to use this macro or

Change-Id: I7da7c2d7d34c7e5efd52d448646b4398a1005e77
Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
Acked-by: Arne Schwabe <arne-openvpn@rfc2549.org>

This change was reviewed on Gerrit and approved by at least one
developer. I request to merge it to master.

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/453
This mail reflects revision 1 of this Change.
Acked-by according to Gerrit (reflected above):
Arne Schwabe <arne-openvpn@rfc2549.org>


Gert Doering Dec. 2, 2023, 4:02 p.m. UTC | #1
"makes sense" :-) - removing cruft from autoconf, and so on.

Your patch has been applied to the master branch and release/2.6
(long-term compat).

commit be05b590e8d5edebd8e35d97af34b0ba7e5350e6 (master)
commit 64703e72df371dabecc8ab83a19621fd9f27c56b (release/2.6)
Author: Frank Lichtenheld
Date:   Tue Nov 28 11:37:40 2023 +0100

     configure.ac: Remove unused AC_TYPE_SIGNAL macro

     Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
     Acked-by: Arne Schwabe <arne-openvpn@rfc2549.org>
     Message-Id: <20231128103740.61160-1-frank@lichtenheld.com>
     URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg27572.html
     Signed-off-by: Gert Doering <gert@greenie.muc.de>

kind regards,

Gert Doering


diff --git a/configure.ac b/configure.ac
index 84eaad6..5cc55c3 100644
--- a/configure.ac
+++ b/configure.ac
@@ -445,7 +445,6 @@ 
 AC_CHECK_SIZEOF([unsigned int])
 AC_CHECK_SIZEOF([unsigned long])