From patchwork Fri Dec 1 11:17:17 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Lichtenheld X-Patchwork-Id: 3492 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7301:d588:b0:fb:b703:d903 with SMTP id ev8csp263816dyc; Fri, 1 Dec 2023 03:18:16 -0800 (PST) X-Google-Smtp-Source: AGHT+IFI5W0u8Bm3eCce3NoAHQ1bvXYHyux9H3JxB+NsNLWwdlCLN4BXQkO+qlxCoHi4j2GIhLNf X-Received: by 2002:a05:6a20:5482:b0:18d:4821:f785 with SMTP id i2-20020a056a20548200b0018d4821f785mr4209977pzk.4.1701429496647; Fri, 01 Dec 2023 03:18:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701429496; cv=none; d=google.com; s=arc-20160816; b=i9lG/6HzvJMSh8L6McgQtW5KJnIrOuO4YIZw9YowCJm6iGEXnQgxelE4prgIQY9nwY 1zPwvjfohciS4tQbpD8Pm1Y/hRbWkUY7Am1EjiZbhI3Jm6F84frYviJF4zxfcY1tcbZ9 Z1yck93btsF6rYDYu+JiU4mV2HgV3uMmZ1TlC3p+iv+H2LoPiTn9ZFxWDQfpgBd8XY3D JuOZ5NoQ1pioL7FDGS0sqdrqfLBKajUGbIQ4DA4wTZKvJRZTTiOywxYo5VxkFwDr/cBD XV9yRIlLpfcXadzM3b8t3EL6NKbFC3BA9BZ1ABt+018s3Njqf9vaJcjhO2SF2q0/h5IR k+KA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=i78XrdDshJZPbRrshuydQrtnML/esA+8IBfzIdFragQ=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=hzOUIn4tJl3IXfwxZX3OqFiVVXfiaV/YfWZ/kro3++29WnYN55wDjzsfjLvbV3Mm/Y jKhcFfM+ORwxoPOwwjavYitc2iuKHium4BidxS3BpSzLj4xqBTRhtdrdUXAx5hq845/g cx3q6uk4jQHVwtiEQp8uvcCKlKc6Hqb9r6oOBDaX7bk5IfeNUJ1P1NWJ91VRoPpfRqEf jflSjIHlL48KFDfAzD1PjdqGENxI/0PdDvgLILTUqhEeTmexWe20niy2xNuISp1u5TUb m5hhxvMyBmGg7BJZhXLxOV/JmdQ1f45DjMfIt0QNFg/7q3c6lACNtKWE2RGX41+gfqgz iL7Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=KBwPd+hz; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=SgoksYOl; dkim=neutral (body hash did not verify) header.i=@lichtenheld.com header.s=MBO0001 header.b=FfhnoJpD; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id a192-20020a6390c9000000b005ace065e52csi3275138pge.336.2023.12.01.03.18.16 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 01 Dec 2023 03:18:16 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=KBwPd+hz; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=SgoksYOl; dkim=neutral (body hash did not verify) header.i=@lichtenheld.com header.s=MBO0001 header.b=FfhnoJpD; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1r91Wu-0003Lm-FC; Fri, 01 Dec 2023 11:17:55 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1r91Wq-0003Le-0e for openvpn-devel@lists.sourceforge.net; Fri, 01 Dec 2023 11:17:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=vUUfRl3AGfceNXN0MNUdgN+lMIhpLat8ViEg108ei3w=; b=KBwPd+hzr4DqTBPgQi5Q/EojXT cBorYXIncS7Ld2z6MpscOHOICBSrluUS1DF5mFz7GCuezWNMIJ31Hwgr3x+VCteDo9chaFqDs/pW/ PSyc2A3hJc6Unfev7C7G6MUhxO0547M7xtWU3oFF/mcYYurx56RQsef9ITSvrz/sMhTM=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-Id: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=vUUfRl3AGfceNXN0MNUdgN+lMIhpLat8ViEg108ei3w=; b=SgoksYOlAojrGZKqViuvg15ins RhwS84qzvBHcNBZA+21Z0EzFrZpbTzdKFSN4CXKSgxSaBQv+ieO8wVU2mq2F4NlEVdsaHVVaVq4lz UKQfXqJ/1M21ZEdYyaqLEoW0cA7g1YWs2Oxl25XBRqotRvUieDKpHdUPdjdOV9oEP3qM=; Received: from mout-p-102.mailbox.org ([80.241.56.152]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1r91Wf-00081f-1T for openvpn-devel@lists.sourceforge.net; Fri, 01 Dec 2023 11:17:47 +0000 Received: from smtp2.mailbox.org (smtp2.mailbox.org [IPv6:2001:67c:2050:b231:465::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-102.mailbox.org (Postfix) with ESMTPS id 4ShVrx46PCz9smr; Fri, 1 Dec 2023 12:17:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lichtenheld.com; s=MBO0001; t=1701429441; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vUUfRl3AGfceNXN0MNUdgN+lMIhpLat8ViEg108ei3w=; b=FfhnoJpDtykAMmsh4Mmdi4hGdomf1u+ogtjAX+75a/BwDEen4ZsH/PkXE34rj0rA75kvkS +ZzwX/KFXrsLIVzdieR1LmHoXMGGm2gcnqU5hwjKhbCTdoAivBUrwlN8hiKWT0CteqEqWN HnItlqBwfHt0akFX6oP/i2iTlTP4ZkzH5dK4GQYlXqWFhrhnOx4HG/kt6OhyD7ZFHqymVu WM42E2tLL+8rQWtdaJ00Td5xdPpIMireH2P8mw/AXWPawme14jcWcv/W6JuTeIqk0KPWDf Gy71PtZJbYq0RI+TSIMQVJwJgG92AxH+Ufn2B+E67johc61kQ4D0il8wqlxjjQ== From: Frank Lichtenheld To: openvpn-devel@lists.sourceforge.net Date: Fri, 1 Dec 2023 12:17:17 +0100 Message-Id: <20231201111717.14940-1-frank@lichtenheld.com> In-Reply-To: References: MIME-Version: 1.0 X-Rspamd-Queue-Id: 4ShVrx46PCz9smr X-Spam-Score: -0.9 (/) X-Spam-Report: Spam detection software, running on the system "util-spamd-1.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Arne Schwabe This debug code is not very useful as it is outdated and the same functionality is provided by --show-gateway Change-Id: Ie7fd59cc84e2eb024086c28c2ec2a5606a2b2e7c Signed-off-by: Arne Schwabe Acked-by: Frank Lichtenheld --- Content analysis details: (-0.9 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: openvpn.net] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [80.241.56.152 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.0 T_SCC_BODY_TEXT_LINE No description available. X-Headers-End: 1r91Wf-00081f-1T Subject: [Openvpn-devel] [PATCH v1] Remove TEST_GET_DEFAULT_GATEWAY as it duplicates --show-gateway X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1784078135686083144?= X-GMAIL-MSGID: =?utf-8?q?1784078135686083144?= From: Arne Schwabe This debug code is not very useful as it is outdated and the same functionality is provided by --show-gateway Change-Id: Ie7fd59cc84e2eb024086c28c2ec2a5606a2b2e7c Signed-off-by: Arne Schwabe Acked-by: Frank Lichtenheld --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/463 This mail reflects revision 1 of this Change. Acked-by according to Gerrit (reflected above): Frank Lichtenheld diff --git a/src/openvpn/init.c b/src/openvpn/init.c index abba748..fdab26b 100644 --- a/src/openvpn/init.c +++ b/src/openvpn/init.c @@ -885,17 +885,6 @@ return false; #endif -#ifdef TEST_GET_DEFAULT_GATEWAY - { - struct route_gateway_info rgi; - struct route_ipv6_gateway_info rgi6; - get_default_gateway(&rgi); - get_default_gateway_ipv6(&rgi6, NULL); - print_default_gateway(M_INFO, &rgi, &rgi6); - return false; - } -#endif - #ifdef GEN_PATH_TEST { struct gc_arena gc = gc_new();