From patchwork Fri Dec 1 12:32:11 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Lichtenheld X-Patchwork-Id: 3497 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7301:d588:b0:fb:b703:d903 with SMTP id ev8csp304352dyc; Fri, 1 Dec 2023 04:33:01 -0800 (PST) X-Google-Smtp-Source: AGHT+IEGWFvyXgeqT2rYK75YtRncb1whkbHKuvDkiyCm/DzfBZdqFhwCuiIT9ThH+nkuljd+1Ih2 X-Received: by 2002:a17:90a:b013:b0:285:e55:68b8 with SMTP id x19-20020a17090ab01300b002850e5568b8mr4960986pjq.1.1701433980948; Fri, 01 Dec 2023 04:33:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701433980; cv=none; d=google.com; s=arc-20160816; b=Eq/dUwftWqBI3XDoKiT2JjT1AwY2QVrXGSBJodvpjBe8ErIAfC5m2fA2h+MVpGMitT 1mQZPA6JPwfSBbwxUFIFjjo/EMsEaf4byxGD2QzS42LQ9mct+Q4pxDbqmk4XmMbJNjkO 1a1Rz8QQSliBejJtaK2dUwh4pvSMort9XB6hz0UT3McwjJvH+S0vktTD2pJ+VoCEjC3o mOoO2fOcQhb6Gt6LbH4w9RCdnwaJ0g7FTXgrAlU1cDPAWTcTDmYs0kB3TLzeoRS0SmLa luUJs4wcOmbAkVYAYyxaPabXF2cebFBPIXj3rgdI3fbiaWeSEtPrg9LNLtIqfL1Bzlpx 3uPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=1M3pEGJVGi4PFjnFrTOce965V9dt2BN97lNO53cnM3s=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=ZjTV+uRhvpXQ/yR7ZEadMnRp9Su81AuGyvMNOJXTILlhmOrk2syRhzrVcUmakoA6yp 8fE/cF800nCd4tcU6fjzOIO1BMsbtQ8CU0EONNVQYzet2eaINkvI4NR43gXU5JG//MUi DllqoqlMg/13vbrqb4GxEibLTDSCLfqrUgvwZ3NqfXZfVxlSkyKfdJL+6BgQRa7fj3O6 b0pdLuuHNUDGE7B22wRIDrVcoyfoksRnUsCB3Z12rBmO2hNMrI05pz0I5frUvNVjBOXT krF2MkPBUtlqnBHRsB/wAfCtjZ4kd8VKd5zsh3I6cSvOCDnypg24wEcu2MtHIBt5efGN E6rg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=gCozIU0p; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b="gnLY/NBZ"; dkim=neutral (body hash did not verify) header.i=@lichtenheld.com header.s=MBO0001 header.b=PnPJFO1H; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id h2-20020a170902704200b001d0519835d9si1378700plt.112.2023.12.01.04.33.00 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 01 Dec 2023 04:33:00 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=gCozIU0p; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b="gnLY/NBZ"; dkim=neutral (body hash did not verify) header.i=@lichtenheld.com header.s=MBO0001 header.b=PnPJFO1H; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1r92hC-0001Gb-7e; Fri, 01 Dec 2023 12:32:38 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1r92h9-0001GT-SI for openvpn-devel@lists.sourceforge.net; Fri, 01 Dec 2023 12:32:37 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=CRA+ckn47vRs7ASmJsN1UEGjeeYf/zjcA5CDm8CB4iE=; b=gCozIU0p/3zp0bH1N9plz7SnWA kONLwj2X04B2G2mNcjpYPlo1qvkH1cHU7M2WMspSM67JYl+fLovKPkZp9C3cIbArM7aSffjqO8PrC x7YYV8X+sDUmlUgZjw6KxuZ0xSQKnKV+boYHRYH+lUH7aq7ndqxaqmJ3P0EUv58Fz0IQ=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-Id: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=CRA+ckn47vRs7ASmJsN1UEGjeeYf/zjcA5CDm8CB4iE=; b=gnLY/NBZYbg7F00Aja72PUWjAh JbsdMibsK8Kglfm3faTUwEDCBF078cPy+eNZIe354hSjZL/1DO3IYO6WbqlD5xcmu+ABk5kCpNCZ8 /QGVtNT6anFT8USCnZ1z3kqywDw4wDkam/c3JKjsTmt3uAu7DYtutN16RigqCZMIAKc4=; Received: from mout-p-101.mailbox.org ([80.241.56.151]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1r92h5-0004l9-Q1 for openvpn-devel@lists.sourceforge.net; Fri, 01 Dec 2023 12:32:36 +0000 Received: from smtp102.mailbox.org (smtp102.mailbox.org [IPv6:2001:67c:2050:b231:465::102]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4ShXWJ403jz9sTR; Fri, 1 Dec 2023 13:32:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lichtenheld.com; s=MBO0001; t=1701433932; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CRA+ckn47vRs7ASmJsN1UEGjeeYf/zjcA5CDm8CB4iE=; b=PnPJFO1HGCXaTMAzyF21S7nkWVzSpvdKfUkVC5xl9COFV7GFcCEE6WItk61IReWSGNbwd/ 2I+RfqEd8IaS9HSg2VvPIo5Alepi68wl/4VGuegNa9YLAQVpAI9XDasL82OmFkin+L0UR/ r+VFzF4rOe8/ndK4T4vEYLFkKuAaowbq9S0yOXJaYVeSQcyL/AWebaNd+w+k28cG5bJ3lM g9694qnaVSRGpHaaacN57ZieEA+DEtEzH2AU8g86gwed7dcpVNtkYx4f6ve7lc+D1IeNBU T69yUL+6A4f7o17sJI24uVi3J2d92415Da5udCwZO3b0D/PwYia58+SvS9ZN2A== From: Frank Lichtenheld To: openvpn-devel@lists.sourceforge.net Date: Fri, 1 Dec 2023 13:32:11 +0100 Message-Id: <20231201123211.17619-1-frank@lichtenheld.com> In-Reply-To: References: MIME-Version: 1.0 X-Rspamd-Queue-Id: 4ShXWJ403jz9sTR X-Spam-Score: -0.9 (/) X-Spam-Report: Spam detection software, running on the system "util-spamd-1.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Arne Schwabe Change-Id: Ifd0376b36d4050dc22bc93b8fcf7ed29faef0021 Signed-off-by: Arne Schwabe Acked-by: Frank Lichtenheld --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Content analysis details: (-0.9 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: openvpn.net] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [80.241.56.151 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.0 T_SCC_BODY_TEXT_LINE No description available. X-Headers-End: 1r92h5-0004l9-Q1 Subject: [Openvpn-devel] [PATCH v5] Remove unused/unneeded/add missing defines from configure/cmake X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1784082837780960299?= X-GMAIL-MSGID: =?utf-8?q?1784082837780960299?= From: Arne Schwabe Change-Id: Ifd0376b36d4050dc22bc93b8fcf7ed29faef0021 Signed-off-by: Arne Schwabe Acked-by: Frank Lichtenheld --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/443 This mail reflects revision 5 of this Change. Acked-by according to Gerrit (reflected above): Frank Lichtenheld diff --git a/CMakeLists.txt b/CMakeLists.txt index d21c9bd..4aa9793 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -167,6 +167,7 @@ check_symbol_exists(getgrnam grp.h HAVE_GETGRNAM) check_symbol_exists(getpwnam pwd.h HAVE_GETPWNAM) check_symbol_exists(getsockname sys/socket.h HAVE_GETSOCKNAME) +check_symbol_exists(getrlimit "sys/time.h;sys/resource.h" HAVE_GETRLIMIT) # Some OS (e.g. FreeBSD) need some basic headers to allow # including network headers diff --git a/config.h.cmake.in b/config.h.cmake.in index 19b79bc..848c505 100644 --- a/config.h.cmake.in +++ b/config.h.cmake.in @@ -140,7 +140,7 @@ #cmakedefine HAVE_GETPWNAM /* Define to 1 if you have the `getrlimit' function. */ -#undef HAVE_GETRLIMIT +#cmakedefine HAVE_GETRLIMIT /* Define to 1 if you have the `getsockname' function. */ #cmakedefine HAVE_GETSOCKNAME @@ -235,8 +235,6 @@ /* Define to 1 if you have the header file. */ #cmakedefine HAVE_PWD_H -/* Define to 1 if you have the `readv' function. */ -#undef HAVE_READV /* Define to 1 if you have the `recvmsg' function. */ #cmakedefine HAVE_RECVMSG @@ -383,9 +381,6 @@ /* Define to 1 if you have the header file. */ #undef HAVE_VFORK_H -/* Define to 1 if you have the `vsnprintf' function. */ -#undef HAVE_VSNPRINTF - /* we always assume a recent mbed TLS version */ #define HAVE_MBEDTLS_PSA_CRYPTO_H 1 #define HAVE_MBEDTLS_SSL_TLS_PRF 1 diff --git a/configure.ac b/configure.ac index 84eaad6..141acc6 100644 --- a/configure.ac +++ b/configure.ac @@ -655,7 +655,7 @@ AC_CHECK_FUNCS([ \ daemon chroot getpwnam setuid nice system dup dup2 \ syslog openlog mlockall getrlimit getgrnam setgid \ - setgroups flock readv writev time gettimeofday \ + setgroups flock time gettimeofday \ setsid chdir \ chsize ftruncate execve getpeereid basename dirname access \ epoll_create strsep \