From patchwork Wed Dec 13 10:53:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Lichtenheld X-Patchwork-Id: 3523 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7300:8d12:b0:fc:24ac:f0cb with SMTP id i18csp6420683dys; Wed, 13 Dec 2023 02:53:49 -0800 (PST) X-Google-Smtp-Source: AGHT+IHpcbu1xNbLhIdwxKt7N2XtfaNS5Sz/cmfHYIwQLZrmD6T4mlxw3ChkpnS4GG1M4Deuu3i1 X-Received: by 2002:a05:6e02:1aa6:b0:35d:8107:b47d with SMTP id l6-20020a056e021aa600b0035d8107b47dmr13730643ilv.1.1702464829435; Wed, 13 Dec 2023 02:53:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702464829; cv=none; d=google.com; s=arc-20160816; b=qVXvMEMe8ZKmErxQYF8FXWEveHold/oU45ZyYPQxxoxuhmYM7J+sh7O17vXZoFH5/N +Z+jcmZaxe6vYHl1ABKuixbDCN/OBMM76gnX+jMqlHQBuQ2+Tukt4Y6z59TyzOJLoCoD 5IEx9xW1Vx+dwv9+EWjzE9EmQA277D3WSH/16MrQLcsB3KfMJDB825SdnJtD5DJ9cTuA Hzq5JPM29aFNrWyqjrzNo7O/uXVlS4EYpFW17jc9ZeIyQngsllOBDpoDMOKTQriNEAiG 0RXvJoOJ8sPSZGzU3x6hoSB9W4XKaIj/QP9xTPcHrCVnJAvfFhzMrGAHvFtRU3Ph0cCm uiGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=1lJTxUmok6uGT7fkNXaKVprNYrqOgYwioO+ySXge/t4=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=F3ZCiZ/T2Av5e8pAfzZJIT0jEC9GHq1CTUV640OsjzSG7RinoB97e0ivQ5HwY9x298 xHiw4FBudTC79zYvMicdY6H/HG7WGrLgekijrrNjq8LxxAYV2PyUTuSZ9xbPvQDNvLOT vYPdjfCNd7HfkqBkZZooFmGXq/K6sSuYqVKW9ZSmSB06OpkrJkWy7qjjjdAERCGD2LoM EXdWFS4K0qPqvAmPpSAl8X2iNNiWeubHB6uQdnWF0DlEYy0jPBMBYnDMTAwCXZaYpIh+ UHeZUdighUmac+JWmBXoebzfhuffDZK2iEpuvwQaxhJhR4EohepKQzW6WuItbiBRiOxe T7qw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=B+edxktJ; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=P6JmdJ5g; dkim=neutral (body hash did not verify) header.i=@lichtenheld.com header.s=MBO0001 header.b=qHbQLLjl; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id r69-20020a632b48000000b005ca4098bf5esi1847913pgr.613.2023.12.13.02.53.49 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 13 Dec 2023 02:53:49 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=B+edxktJ; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=P6JmdJ5g; dkim=neutral (body hash did not verify) header.i=@lichtenheld.com header.s=MBO0001 header.b=qHbQLLjl; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1rDMro-0002hc-B0; Wed, 13 Dec 2023 10:53:28 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1rDMrk-0002hV-OY for openvpn-devel@lists.sourceforge.net; Wed, 13 Dec 2023 10:53:25 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=eANuKovixeoyJuj1rR7N+XhDWZuoHlfFtTU3fWx1nNg=; b=B+edxktJSlvG4u0Bj0VM3nIVeO UmSseJeWbuChzH69bhCrlV05f3E8JgclUGr+n4pW03k34rg0cYCQO+8cdxAACysRyKKYTdc5SA5yl TyOGEj5RbwpUTQCDTDWS1qvlt6TlC8JLCM7+yK68Q80RMnEckeaNQfo6X/2RhBAHuFhQ=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-Id: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=eANuKovixeoyJuj1rR7N+XhDWZuoHlfFtTU3fWx1nNg=; b=P6JmdJ5gdSpgUhOSaLuuv1JnWU eQaLX9gCO1R73GkgZJ7UzqxXIlbALbjfeFtY/yPV0Ru5sRCldQwiL7vs+SV7E8miP4Nj+XIXUJ6zl YEh0cTP2A3acHpmDBDSIPs7WMtx78cUNb2hMxKRcOh0BSBSc1qNYpNZ4hMSfMWmU1H2A=; Received: from mout-p-202.mailbox.org ([80.241.56.172]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1rDMrg-0004ue-R8 for openvpn-devel@lists.sourceforge.net; Wed, 13 Dec 2023 10:53:23 +0000 Received: from smtp1.mailbox.org (smtp1.mailbox.org [IPv6:2001:67c:2050:b231:465::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-202.mailbox.org (Postfix) with ESMTPS id 4SqslT4MSJz9sTK; Wed, 13 Dec 2023 11:53:09 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lichtenheld.com; s=MBO0001; t=1702464789; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eANuKovixeoyJuj1rR7N+XhDWZuoHlfFtTU3fWx1nNg=; b=qHbQLLjliXjD5Rp6sPXn2V6EL/Y2r8nmDg47I2Xfausvtay7Zd0HoOsqB21a9vnIrX1eJL G8avJeM6R+N0vuy7Jx9G2hvLlr+3/+I5bFT/Bwg7xrGPWDUqYokBNARRE0OM3pkUDGqkXR yMObNKrIKXBHOxliDbqj+NtLyqTW1hWuxSzVznQ5LxvEUHKBKzsDjZ+55YIhYwjSQuu6Wy CCwHhJuuqiqyoU5e5VM5jZ7U4kJFQ1KyEvz/yy+MaegY/hD6muVy8vJcaFWnfB7pJAHFUH 89Kht+6/j5l900Azww8YCrtJVRRn20KWinDsLU9rTbHIygtL7HImWOxGXwya1w== From: Frank Lichtenheld To: openvpn-devel@lists.sourceforge.net Date: Wed, 13 Dec 2023 11:53:08 +0100 Message-Id: <20231213105308.121460-1-frank@lichtenheld.com> In-Reply-To: References: MIME-Version: 1.0 X-Rspamd-Queue-Id: 4SqslT4MSJz9sTK X-Spam-Score: -0.9 (/) X-Spam-Report: Spam detection software, running on the system "util-spamd-1.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Arne Schwabe This error will probably become more and more common in the future when more and more systems will drop TLS 1.0 PRF support. We are already seeing people stumbling upon this (see GitHub issue #460) Content analysis details: (-0.9 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 RCVD_IN_MSPIKE_H5 RBL: Excellent reputation (+5) [80.241.56.172 listed in wl.mailspike.net] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [80.241.56.172 listed in list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders -0.0 T_SCC_BODY_TEXT_LINE No description available. X-Headers-End: 1rDMrg-0004ue-R8 Subject: [Openvpn-devel] [PATCH v8] Extend the error message when TLS 1.0 PRF fails X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1785163760983375870?= X-GMAIL-MSGID: =?utf-8?q?1785163760983375870?= From: Arne Schwabe This error will probably become more and more common in the future when more and more systems will drop TLS 1.0 PRF support. We are already seeing people stumbling upon this (see GitHub issue #460) The current error messages TLS Error: PRF calcuation failed TLS Error: generate_key_expansion failed are not very helpful for people that do not have deep understanding of TLS or the OpenVPN protocol. Improve this message to give a normal user a chance to understand that the peer needs to be OpenVPN 2.6.x or newer. Change-Id: Ib3b64b52beed69dc7740f191b0e9a9dc9af5b7f3 Signed-off-by: Arne Schwabe Acked-by: Frank Lichtenheld --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/456 This mail reflects revision 8 of this Change. Acked-by according to Gerrit (reflected above): Frank Lichtenheld diff --git a/src/openvpn/ssl.c b/src/openvpn/ssl.c index 6eddb68..7597412 100644 --- a/src/openvpn/ssl.c +++ b/src/openvpn/ssl.c @@ -1477,7 +1477,12 @@ { if (!generate_key_expansion_openvpn_prf(session, &key2)) { - msg(D_TLS_ERRORS, "TLS Error: PRF calcuation failed"); + msg(D_TLS_ERRORS, "TLS Error: PRF calculation failed. Your system " + "might not support the old TLS 1.0 PRF calculation anymore or " + "the policy does not allow it (e.g. running in FIPS mode). " + "The peer did not announce support for the modern TLS Export " + "feature that replaces the TLS 1.0 PRF (requires OpenVPN " + "2.6.x or higher)"); goto exit; } }