From patchwork Thu Dec 14 11:16:35 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Lichtenheld X-Patchwork-Id: 3527 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7300:8d12:b0:fc:24ac:f0cb with SMTP id i18csp7118050dys; Thu, 14 Dec 2023 03:17:21 -0800 (PST) X-Google-Smtp-Source: AGHT+IFrJphhwTLOS0K9ciJavl0dPLSER6fXv1ZBSpfDGbdPACdGUUrGDsWKmpuEIVx4W+i06oTB X-Received: by 2002:a05:6e02:1caf:b0:35d:692c:5968 with SMTP id x15-20020a056e021caf00b0035d692c5968mr16676120ill.3.1702552641309; Thu, 14 Dec 2023 03:17:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702552641; cv=none; d=google.com; s=arc-20160816; b=GVahC5rpzFObfwoXJB4eqAgorV5ctc7vLrtvCRMVmRDvG0EAE+G3WhXO9G9uIitmp4 RCYYLET/dl9Fn3NNbYYzNO34yUoFAH/KInX4x+iL4gMdrYvsQ9S46PelJOx8b30vmgX6 OvIx+jNoF27GwxjxjCKz/rx/56Fr/LKczJdnWTqosI8PXq8l2R+RB6m+gtEtARHNWpIy SH628rzZuL9ApxG7tIE4Bb82+jM+Wfbye1IzGr7bIc/fGIa0mIcQgNfMDt1xL5I7ZvNR uTi4OUnaIY3Zl/LAbN67W/v9mtCGtIbnydMjpUso1zRhpZ93cVVp94Xg/+Jtlm3DZhWl BUZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:content-transfer-encoding:cc:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=vSo5FRcO2+L+beuQEgqOAdM89eTAShn/ZWMp1d3e3/A=; fh=CfxSpwd5kfiMJoL3kcov7PTxVKT7pGe/79idnx9XlBs=; b=nIzyoyuY3fntQt4ultCxs/m9KUyJfLHPzEanKktIUAywC8VhXYABOg7syAlgVrPpAd 3JmIijU7636BkWV6GIHHthfDJs2XmvUEk7yYNCJCeIkxQfff/GQ89ESsrSY37n4uc4Lh CZyimEpThL9etYCB9UtTh/tci9H+hmyfUZ6cbUsWdcCmPZIoP2VLxObcfjcWImW0sm1X 8DcSqHxCsN2Sbt7WiS3tI4PgxOKCNslsm/pYI+53kp3zgTqK1PV4cQvkztrTYtRqqqiY 7/8BGnZvqpX+xH/Tbc984Ikkw8qq9QFDvT2k+9u9qloFGy0zFd51v1sUHxUwF5lrR4BI 9cDg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=EbnlsRXe; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=Ta2TnMhe; dkim=neutral (body hash did not verify) header.i=@lichtenheld.com header.s=MBO0001 header.b=xIcINZlG; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id x20-20020a631714000000b0057e21f51ab3si11001870pgl.665.2023.12.14.03.17.21 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 14 Dec 2023 03:17:21 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=EbnlsRXe; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=Ta2TnMhe; dkim=neutral (body hash did not verify) header.i=@lichtenheld.com header.s=MBO0001 header.b=xIcINZlG; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1rDji4-0001go-Tt; Thu, 14 Dec 2023 11:16:55 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1rDji3-0001gg-Aq for openvpn-devel@lists.sourceforge.net; Thu, 14 Dec 2023 11:16:54 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=e6FmDL6xW7zdsOspPmv/MHXxdtuflbAhtQ73kBfsVzA=; b=EbnlsRXeNG+4BxC0+JwUfsQ8VC zhy5RJ3QD2CAE7skvxJ7VpHeBpyeNwFfDd2KsEFd2+/d+YN1lT70WSWu0quZoQ/vnNiUeoprGXAbo hDJs1x9NPLZaIzRpG7M7AOhhw+PpNyv7rRnGuovdjDZlFnar3E8gOh10Pi5fEkBfInHA=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-Id: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=e6FmDL6xW7zdsOspPmv/MHXxdtuflbAhtQ73kBfsVzA=; b=Ta2TnMhekFG/z4Lom6g2jK+jxn VtfdSSUpxKRrtjrWGqai7WWIuSe2RzSOqRSbBsKnkjD47NlS9TYGdp2h79PS5TVasfvev9BMYqCsg tE2YYcgNvAVfKiGpIyQIHeeSarJvicw8LI0DseeLR9bu+15dQB7J650knyeW9fX/vDe8=; Received: from mout-p-102.mailbox.org ([80.241.56.152]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1rDjhx-0003i0-4I for openvpn-devel@lists.sourceforge.net; Thu, 14 Dec 2023 11:16:53 +0000 Received: from smtp1.mailbox.org (smtp1.mailbox.org [IPv6:2001:67c:2050:b231:465::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-102.mailbox.org (Postfix) with ESMTPS id 4SrVD52Hzbz9slS; Thu, 14 Dec 2023 12:16:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lichtenheld.com; s=MBO0001; t=1702552597; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=e6FmDL6xW7zdsOspPmv/MHXxdtuflbAhtQ73kBfsVzA=; b=xIcINZlGh/H/hCQRU/Tzue30KSBMAZ6s04bk2hBPf1WSGkTzmHzznPGMOcvYITkcB19FIZ wuncEuFtp3mqLQwxx32WliSbuks47k+ZEqJpoOXpLwvJ/e2m89kKWkPqRlNePkCINsRqOO TA5p6ia4iIkmGDfJp0PNymhaxqND1/zW4Y2lgudg+8kK0ACbWCNovV48JxlZ8o5/2jEMha 1HHHY44cftgJVlpwntZDpIUSKoDjsdeeiT7HyUdWmSLYmcXd0zduSTuSaq3AOghVXPN/33 gYelaQiSVREt73V0VaFOyxIJC6kaGBVw3ANClluto/PjjaOhl0uKx50+kUAkKA== From: Frank Lichtenheld To: openvpn-devel@lists.sourceforge.net Date: Thu, 14 Dec 2023 12:16:35 +0100 Message-Id: <20231214111635.237429-1-frank@lichtenheld.com> In-Reply-To: References: MIME-Version: 1.0 X-Rspamd-Queue-Id: 4SrVD52Hzbz9slS X-Spam-Score: -0.9 (/) X-Spam-Report: Spam detection software, running on the system "util-spamd-2.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Serial mode is the old one and offers much less options for running the tests. Generally our tests seem to work fine with the newer parallel mode. The only reason we stuck with serial_tests seems to b [...] Content analysis details: (-0.9 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [80.241.56.152 listed in list.dnswl.org] 0.0 RCVD_IN_MSPIKE_H5 RBL: Excellent reputation (+5) [80.241.56.152 listed in wl.mailspike.net] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.0 T_SCC_BODY_TEXT_LINE No description available. 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-Headers-End: 1rDjhx-0003i0-4I Subject: [Openvpn-devel] [PATCH v2] tests: disable automake serial_tests X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Arne Schwabe Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1785255838427562169?= X-GMAIL-MSGID: =?utf-8?q?1785255838427562169?= Serial mode is the old one and offers much less options for running the tests. Generally our tests seem to work fine with the newer parallel mode. The only reason we stuck with serial_tests seems to be that we didn't like that it doesn't output the test output by default. We could fix that with a custom test driver. But will put that into a separate commit. Change-Id: Ic7265d89142637b0963a6847c6beb06d9163bbb1 Signed-off-by: Frank Lichtenheld Acked-by: Arne Schwabe --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/477 This mail reflects revision 2 of this Change. Acked-by according to Gerrit (reflected above): Arne Schwabe diff --git a/configure.ac b/configure.ac index 54f79ab..2823f04 100644 --- a/configure.ac +++ b/configure.ac @@ -41,20 +41,6 @@ AC_CONFIG_SRCDIR([src/openvpn/syshead.h]) AC_CONFIG_MACRO_DIR([m4]) -dnl Initialize automake. automake < 1.12 didn't have serial-tests and -dnl gives an error if it sees this, but for automake >= 1.13 -dnl serial-tests is required so we have to include it. Solution is to -dnl test for the version of automake (by running an external command) -dnl and provide it if necessary. Note we have to do this entirely using -dnl m4 macros since automake queries this macro by running -dnl 'autoconf --trace ...'. -m4_define([serial_tests], [ - m4_esyscmd([automake --version | - head -1 | - awk '{split ($NF,a,"."); if (a[1] == 1 && a[2] >= 12) { print "serial-tests" }}' - ]) -]) - dnl Automake 1.14+ warns if sources are in sub-directories but subdir-objects dnl options is not enabled. However, automake before 1.15a has a bug that causes dnl variable expansion to fail in foo_SOURCES when this option is used. @@ -69,7 +55,7 @@ # This foreign option prevents autoreconf from overriding our COPYING and # INSTALL targets: -AM_INIT_AUTOMAKE(foreign serial_tests subdir_objects 1.9) dnl NB: Do not [quote] this parameter. +AM_INIT_AUTOMAKE(foreign subdir_objects 1.9) dnl NB: Do not [quote] this parameter. AC_CANONICAL_HOST AC_USE_SYSTEM_EXTENSIONS diff --git a/tests/Makefile.am b/tests/Makefile.am index 80673d5..6c71067 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -14,6 +14,8 @@ SUBDIRS = unit_tests +AM_TESTSUITE_SUMMARY_HEADER = ' for $(PACKAGE_STRING) System Tests' + if !WIN32 test_scripts = t_client.sh t_lpback.sh t_cltsrv.sh if HAVE_SITNL diff --git a/tests/unit_tests/example_test/Makefile.am b/tests/unit_tests/example_test/Makefile.am index 24eb0ba..1ae80c8 100644 --- a/tests/unit_tests/example_test/Makefile.am +++ b/tests/unit_tests/example_test/Makefile.am @@ -1,5 +1,7 @@ AUTOMAKE_OPTIONS = foreign +AM_TESTSUITE_SUMMARY_HEADER = ' for $(PACKAGE_STRING) example Unit-Tests' + check_PROGRAMS = example_testdriver example2_testdriver if !CROSS_COMPILING diff --git a/tests/unit_tests/openvpn/Makefile.am b/tests/unit_tests/openvpn/Makefile.am index ef45b11..cecf4dc 100644 --- a/tests/unit_tests/openvpn/Makefile.am +++ b/tests/unit_tests/openvpn/Makefile.am @@ -1,5 +1,7 @@ AUTOMAKE_OPTIONS = foreign +AM_TESTSUITE_SUMMARY_HEADER = ' for $(PACKAGE_STRING) Unit-Tests' + test_binaries= if HAVE_LD_WRAP_SUPPORT diff --git a/tests/unit_tests/plugins/auth-pam/Makefile.am b/tests/unit_tests/plugins/auth-pam/Makefile.am index de5e96e..ba32013 100644 --- a/tests/unit_tests/plugins/auth-pam/Makefile.am +++ b/tests/unit_tests/plugins/auth-pam/Makefile.am @@ -1,5 +1,7 @@ AUTOMAKE_OPTIONS = foreign +AM_TESTSUITE_SUMMARY_HEADER = ' for $(PACKAGE_STRING) auth_pam Plugin Unit-Tests' + if ENABLE_PLUGIN_AUTH_PAM check_PROGRAMS = auth_pam_testdriver TESTS = $(check_PROGRAMS)